nextcloud-server

Commit Graph

Author	SHA1	Message	Date
Robin Appelman	111fa47f10	remove ReconnectWrapper dbal now handles it's own reconnections: https://github.com/doctrine/dbal/blob/3.0.x/UPGRADE.md#the-pingableconnection-interface-is-removed Signed-off-by: Robin Appelman <robin@icewind.nl>	5 years ago
Christoph Wurst	2c9cdc1cdb	Add our own DB exception abstraction Right now our API exports the Doctrine/dbal exception. As we've seen with the dbal 3 upgrade, the leakage of 3rdparty types is problematic as a dependency update means lots of work in apps, due to the direct dependency of what Nextcloud ships. This breaks this dependency so that apps only need to depend on our public API. That API can then be vendor (db lib) agnostic and we can work around future deprecations/removals in dbal more easily. Right now the type of exception thrown is transported as "reason". For the more popular types of errors we can extend the new exception class and allow apps to catch specific errors only. Right now they have to catch-check-rethrow. This is not ideal, but better than the dependnecy on dbal. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	5 years ago
Christoph Wurst	8b64e92b92	Bump doctrine/dbal from 2.12.0 to 3.0.0 Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	5 years ago
Christoph Wurst	d89a75be0b	Update all license headers for Nextcloud 21 Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	5 years ago
Joas Schilling	fbda2d1d25	Don't try to update on NotNullConstraintViolationException, only on unique or foreign key Signed-off-by: Joas Schilling <coding@schilljs.com>	5 years ago
Joas Schilling	1aa9c9164d	Fix comparing the empty string for global credentials Signed-off-by: Joas Schilling <coding@schilljs.com>	5 years ago
Julius Härtl	f49630f48c	Replace prefix in executeUpdate Signed-off-by: Julius Härtl <jus@bitgrid.net>	5 years ago
Roeland Jago Douma	fe46149560	Psalm fixes Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	5 years ago
Roeland Jago Douma	28be188fbc	Update internal connection class executeUpdate is deprecated in favor of executeStatement. We overwrote the old one hence the prefix was no longer replaced. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	5 years ago
Morris Jobke	f12e7e0e95	Fetch the logger and system config once for all query builder instances Signed-off-by: Morris Jobke <hey@morrisjobke.de>	5 years ago
Christoph Wurst	d9015a8c94	Format code to a single space around binary operators Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	5 years ago
Joas Schilling	3212c074b9	Log the number of queries built and executed Signed-off-by: Joas Schilling <coding@schilljs.com>	5 years ago
Morris Jobke	99c9423766	Remove @suppress SqlInjectionChecker Signed-off-by: Morris Jobke <hey@morrisjobke.de>	5 years ago
Christoph Wurst	caff1023ea	Format control structures, classes, methods and function To continue this formatting madness, here's a tiny patch that adds unified formatting for control structures like if and loops as well as classes, their methods and anonymous functions. This basically forces the constructs to start on the same line. This is not exactly what PSR2 wants, but I think we can have a few exceptions with "our" style. The starting of braces on the same line is pracrically standard for our code. This also removes and empty lines from method/function bodies at the beginning and end. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	14c996d982	Use elseif instead of else if Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	44577e4345	Remove trailing and in between spaces Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	afbd9c4e6e	Unify function spacing to PSR2 recommendation Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	1a9330cd69	Update the license headers for Nextcloud 19 Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	b80ebc9674	Use the short array syntax, everywhere Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	74936c49ea	Remove unused imports Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Daniel Kesselberg	9e699a8d21	Add event subscriber for transaction isolation level Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>	6 years ago
Christoph Wurst	5bf3d1bb38	Update license headers Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Roeland Jago Douma	68748d4f85	Some php-cs fixes * Order the imports * No leading slash on imports * Empty line before namespace * One line per import * Empty after imports * Emmpty line at bottom of file Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	6 years ago
Daniel Kesselberg	9cb7252880	Connection::TRANSACTION_READ_COMMITTED is deprecated Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>	6 years ago
Ole Ostergaard	0d778fcc4e	Code cleanup. Signed-off-by: Ole Ostergaard <ole.c.ostergaard@gmail.com>	7 years ago
Ole Ostergaard	a48ea8cffa	Add insertIgnoreConflict to Adapter and use it for for executing the file locking. Signed-off-by: Ole Ostergaard <ole.c.ostergaard@gmail.com>	7 years ago
Morris Jobke	5273639d0e	Add deprecation message ofr insertIfNotExist Signed-off-by: Morris Jobke <hey@morrisjobke.de>	7 years ago
Morris Jobke	230e93f575	Catch UniqueConstraintViolationException inside insertIfNotExist This is the most common case for the usage of this method. See also https://github.com/nextcloud/server/issues/12369 and the linked tickets. Signed-off-by: Morris Jobke <hey@morrisjobke.de>	7 years ago
Robin Appelman	335619f6a4	Check connection status and attempt to reconnect each each minute Signed-off-by: Robin Appelman <robin@icewind.nl>	8 years ago
Robin Appelman	aad01894e3	refactor user searching add additional user searching tests Signed-off-by: Robin Appelman <robin@icewind.nl>	8 years ago
Morris Jobke	0eebff152a	Update license headers Signed-off-by: Morris Jobke <hey@morrisjobke.de>	8 years ago
Lukas Reschke	3d2600b039	Add Phan plugin to check for SQL injections This adds a phan plugin which checks for SQL injections on code using our QueryBuilder, while it isn't perfect it should already catch most potential issues. As always, static analysis will sometimes have false positives and this is also here the case. So in some cases the analyzer just doesn't know if something is potential user input or not, thus I had to add some `@suppress SqlInjectionChecker` in front of those potential injections. The Phan plugin hasn't the most awesome code but it works and I also added a file with test cases. Signed-off-by: Lukas Reschke <lukas@statuscode.ch>	9 years ago
Joas Schilling	15eec7b83c	Start migrations Fixme: - Install and update of apps - No revert on live systems (debug only) - Service adjustment to our interface - Loading via autoloader Signed-off-by: Joas Schilling <coding@schilljs.com>	9 years ago
Piotr Mrówczyński	9fec4031b3	Adjust query/event logging code in favour of more complex owncloud/diagnostics (#27643 ) * Adjust query/event logging code in favour of more complex owncloud/diagnostics * Add descriptions to IQueryLogger and IEventLogger interfaces	9 years ago
Morris Jobke	3329f44a76	Address comments * fix URL to documentation * improve logic of UTF8mb4 check * fix connection parameter creation - it's done already in ConnectionFactory::createConnectionParams * remove unused attributes of MDB2SchemaReader Signed-off-by: Morris Jobke <hey@morrisjobke.de>	9 years ago
Morris Jobke	713f684a8b	Adding tests for 4 byte unicode characters * success on SQLite and Postgres * failure on MySQL due to the limited charset that only supports up to 3 bytes Add config option to update charset of mysql to utf8mb4 * fully optional * requires additional options set in the database only disable unicode test on mysql Fixing ctor call Adding docker based unit test execution for mysql utf8mb4 Add mysqlmb4 test configuration to Jenkinsfile fix collation on utf8mb4 Properly setup charset and collation in the doctrine connection Allow files containing 4-byte chars in case the database supports it During setup of a mysql database we try to detect if charset 'utf8mb4' can be used Fix mysql settings Add console command to migrate the charset Set ROW_FORMAT before setting collation to mb4 Also select tables with wrong collation Faster MySQL docker Signed-off-by: Morris Jobke <hey@morrisjobke.de>	9 years ago
Philipp Schaffrath	2ccf544ad7	Fixed failing test which was ignoring a required (not null) column (#26303 ) * Fixed failing test which was ignoring a required (not null) column * restored test to original, catching DriverException which also catches ConstraintViolationException * catch ConstraintViolationException again * removed unnecessary field from this test * clobfield should be nullable * clobfield now is nullable * removed autoincrement since whenever this strategy is enabled, oracle would not throw constraint violation exceptions (needed for setValues), which mysql still does * this field does not auto increment anymore * mark integerfield as primary, since it is not getting marked as such through auto increment anymore, integerfield default always has been 0 instead of null Signed-off-by: Morris Jobke <hey@morrisjobke.de>	9 years ago
Roeland Jago Douma	f07d75a4dd	@since 9.2.0 to @since 11.0.0 Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	9 years ago
Joas Schilling	2c4035e806	Inject config and logger Signed-off-by: Joas Schilling <coding@schilljs.com>	9 years ago
Robin Appelman	3a8e75a814	Allow 4byte unicode filenames on supported platforms Signed-off-by: Robin Appelman <robin@icewind.nl>	9 years ago
Joas Schilling	0215b004da	Update with robin	10 years ago
Joas Schilling	ba87db3fcc	Fix others	10 years ago
Lukas Reschke	aba539703c	Update license headers	10 years ago
Joas Schilling	7e3ce83526	Add a method to lock a table	10 years ago
Roeland Jago Douma	893204ef4a	Fix broken exception naming	10 years ago
Roeland Jago Douma	d09f835dca	Move \OC\DB to PSR-4 Besides the statement wrapper that is moved to the legacy folder (namepsace of shame folder)	10 years ago
Robin McCorkell	1b2f1cc272	Prevent certain DBs throwing exceptions on same-value updates A PreconditionNotMetException must only be thrown if explicit preconditions are specified for setValues(), not if the value is merely the same as was already in the DB.	10 years ago
Lukas Reschke	933f60e314	Update author information Probably nice for the people that contributed to 9.0 to see themselves in the AUTHORS file :)	10 years ago
Joas Schilling	01164e89a4	Move parameter to the right function call	10 years ago
Joas Schilling	76f506e264	Use our OCP constants	10 years ago

48 Commits (5cd1880daa048a685da689c7f41a2e50486494de)