nextcloud-server

Commit Graph

Author	SHA1	Message	Date
Christoph Wurst	2a054e6c04	Update the license headers for Nextcloud 20 Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	5 years ago
Scott Dutton	b12a390220	Always try and show pre rendered preview Currently if the following situation happens Server generates preview Server has command removed which allows a preview to be shown Client asks for preview, gets a 404 error when preview exists (Mime checked before preview) This happens more often with documents, or video as the commands are not native PHP, they require a binary on the server. After the fix the following would happen Server generates preview Server has command removed which allows a preview to be shown Client asks for preview, gets preview which has been generated (Mime checked after preview) This would also allow offline generation (for example a docker image containing the extra binaries), allowing a reduction in attack surface of the instance serving the preview data. Signed-off-by: Scott Dutton <scott@exussum.co.uk>	5 years ago
Morris Jobke	f510da139f	Use class that actually has the destroy() method in preview generator Signed-off-by: Morris Jobke <hey@morrisjobke.de>	5 years ago
Elijah Martin-Merrill	56ed563b0c	fix memory leak caused by not destroying image in Preview/Generate.php Signed-off-by: Elijah Martin-Merrill <elijah@nyp-itsours.com>	6 years ago
Christoph Wurst	cb057829f7	Update license headers for 19 Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Robin Appelman	8f9bac26f8	fix preview generation tests Signed-off-by: Robin Appelman <robin@icewind.nl>	6 years ago
Christoph Wurst	14c996d982	Use elseif instead of else if Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Robin Appelman	7d386872e5	optimize batch generation of previews by allowing the generation of multiple previews at once we save on having to find, open and decode the max-preview for every preview of the same file the main use case for this is the preview generator app (pr for that comming next) in my local testing this saves about 25% of time when using the preview generator app Signed-off-by: Robin Appelman <robin@icewind.nl>	6 years ago
Robin Appelman	5cd12cd7c3	allow generating multiple preview sizes for a single file at once this saves having to do some of the overhead multiple times Signed-off-by: Robin Appelman <robin@icewind.nl>	6 years ago
Christoph Wurst	2fbad1ed72	Fix (array) indent style to always use one tab Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	74936c49ea	Remove unused imports Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
John Molakvoæ (skjnldsv)	6df44e407a	Also center vertically when cropping previews Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	6 years ago
Christoph Wurst	5bf3d1bb38	Update license headers Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Roeland Jago Douma	68748d4f85	Some php-cs fixes * Order the imports * No leading slash on imports * Empty line before namespace * One line per import * Empty after imports * Emmpty line at bottom of file Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	6 years ago
Robin Appelman	5e082f8946	allow keeping multiple preview "versions" of the same file The main use case here is storage provided versioning where we dont have separate file ids for all the versions, by allowing a prefix for the version we can store separate previews for all the versions. Additionally, by keeping all the version previews in the same folder as the "normal" previews they will be cleaned up properly when the file is deleted Signed-off-by: Robin Appelman <robin@icewind.nl>	7 years ago
John Molakvoæ (skjnldsv)	4505afe184	Allow IProviderV2 for previews as well Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	7 years ago
Robin Appelman	6150614374	Add new Provider interface for preview providers the main difference is passing the `File` object to the provider instead of a `View` + path Old providers will still continue to work as before Signed-off-by: Robin Appelman <robin@icewind.nl>	7 years ago
Roeland Jago Douma	ce10f8b8c4	Only generate previews in powers of 4 and set min Before we'd round up all preview request to their nearest power of two. This resulted still in a lot of possible images. Generating a lot of server load and taking up a lot of space. This moves it to previews to be powers of 4: 64, 256, 1024 and 4096 Also the first two powers are always skipped (4, 16) as it doesn't make sense to generate previews for that. We cache preview pretty agressively and I feel this is a better tradeoff. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	7 years ago
Roeland Jago Douma	5b103744c8	Check if a preview provider is available before using it Else if a preview provider is registerd but not available (for example missing support in some external lib). It will do 💥. This way the providers can at least do the sanity checks required. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	7 years ago
Roeland Jago Douma	14acded171	Make sure the file is readable before attempting to create a preview Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	8 years ago
Roeland Jago Douma	8703df3233	If the preview is size 0 it is invalid * delete it * throw a NotFound Exception - This should a proper 404 to the user - Next time it is then regenerated Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	8 years ago
Morris Jobke	e4b3ee8d8f	Fix float/integer handling in image API * IImage::crop/preciseResize now have type hinting for integers * found while testing strict typing for PHP 7+ Signed-off-by: Morris Jobke <hey@morrisjobke.de>	8 years ago
Roeland Jago Douma	e2352cc06f	Max preview size to 4096x4096 With HiDPI screens. And even normal HD screens you want more detail from your pictures. Or the ability to somewhat zoom on you previews. For this we need somewhat larger previews. Moving the default to 4096x4096 is a step up. Users that want the old behavior can still set the values in config.php Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	8 years ago
Roeland Jago Douma	faa68b28cb	Only return 1 type Throw proper exception if we can't get the mimetype for a preview. Catch it later on so we can just return a not found for the preview. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	8 years ago
Roeland Jago Douma	5b21650097	Don't lie about the preview mimetype For legacy reasons we stored all the previews with a png extention. However we did not put png data in them all the time. This caused the preview endpoints to always report that a preview is a png file. Which was a lie. Since we abstract away from the storage etc in the previewmanager. There is no need anymore to store them as .png files and instead we can use the actual file extention. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	8 years ago
Morris Jobke	0eebff152a	Update license headers Signed-off-by: Morris Jobke <hey@morrisjobke.de>	8 years ago
Roeland Jago Douma	29fb315ffc	Allow requesting the max preview Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	8 years ago
Morris Jobke	6aac094091	Add PHPDoc Signed-off-by: Morris Jobke <hey@morrisjobke.de>	9 years ago
Robin Appelman	4dfd90abc4	better handling of preview generation errors Signed-off-by: Robin Appelman <robin@icewind.nl>	9 years ago
Roeland Jago Douma	0ad4b89d41	Some code cleanup As suggested by the inspector Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	9 years ago
Roeland Jago Douma	4cd13e7668	Don't generate max preview twice If you request a preview of X by Y. And after calculating X and Y are equal to maxWidth and maxHeight then there is no reason to create a preview of that size. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	9 years ago
Roeland Jago Douma	99ada40df4	Dispatch event on preview request Fixes: #73 Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	9 years ago
Roeland Jago Douma	87855aa97b	Added genertor helper & tests Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	9 years ago
Roeland Jago Douma	d720a2fb57	Moved over files_versions Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	9 years ago
Roeland Jago Douma	5466fbf761	Move Ipreview to more of DI thingy Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	9 years ago
Roeland Jago Douma	8468212386	Fix name conflict Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	9 years ago
Roeland Jago Douma	d6f1287ae6	Move file Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	9 years ago
Roeland Jago Douma	02525fd98b	Move preview endpoint to controller Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	9 years ago
Roeland Jago Douma	743132650a	Move to AppData Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	9 years ago
Roeland Jago Douma	958c1289b1	New preview generator Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	9 years ago

39 Commits (5cd1880daa048a685da689c7f41a2e50486494de)