107 Commits (5cd1880daa048a685da689c7f41a2e50486494de)

Author	SHA1	Message	Date
Maxence Lange	e0bafb7475	deleteChildren only returns array ... Signed-off-by: Maxence Lange <maxence@artificial-owl.com>	5 years ago
Julius Härtl	85e6cbc87a	Extend dummy factory in tests ... Signed-off-by: Julius Härtl <jus@bitgrid.net>	5 years ago
Daniel Calviño Sánchez	4d3cb1533e	Add unit tests for "validateExpirationDateInternal" ... They were copied and adjusted as needed from the tests for "validateExpirationDate". Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	baaaacd650	Add explicit time to test date for clarity ... This shows in a clearer way that the expected expiration date is the original one, but without time. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	578b57837a	Add unit test for expiration date with date and with default ... This adds back what was being actually tested in the unit test fixed in the previous commit. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	70018ddabf	Fix unit test for expiration date without date but with default ... The expiration date was explicitly given, so it was not testing what it should. Moreover, "link_defaultExpDays" needs to be mapped when testing the default value (even if it will just fallback to the value of "shareapi_expire_after_n_days"). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	3a53c2b6e5	Fix unit test method name ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	e997f0fa46	Fix unit test for verifying enforced valid expiration date. ... The enforced expiration date was not actually enabled, as for that "shareapi_default_expire_date" needs to be explicitly set to "yes". Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	8f1fff40e8	Fix unit test for verifying enforced expire date too far in the future ... The test should fail if no exception was thrown, and no exception was thrown due to a missing configuration parameter. However, the use of "addToAssertionCount(1)" made the test pass even if no exception was thrown and, therefore, to silently fail. Now the missing configuration parameter was added and the test will fail if the expected exception is not thrown. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	ec92e82571	Add unit tests to enforce a relaxed default share expiration date ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	4dbeab5cff	Remove wrong and misleading comment ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	72f51422ec	Remove extra spaces ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	7cfa2701b9	Fix typo in variable name ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	c8dc51f0ba	Fix typos in method names ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Robin Appelman	de7026f6e4	use file name instead of path in 'not allowed to share' message ... Signed-off-by: Robin Appelman <robin@icewind.nl>	5 years ago
Christoph Wurst	d9015a8c94	Format code to a single space around binary operators ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	5 years ago
Morris Jobke	234b510652	Change PHPDoc type hint from PHPUnit_Framework_MockObject_MockObject to \PHPUnit\Framework\MockObject\MockObject ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	5 years ago
Roeland Jago Douma	43efac345e	Use the correct mountpoint to calculate ... If we use the owners mount point this results in null. And then the rest of the checks get called with null. Which doesn't work. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	6 years ago
Joas Schilling	89ed2c37bf	Update share type constant usage ... Signed-off-by: Joas Schilling <coding@schilljs.com>	6 years ago
Joas Schilling	95652d4469	Fix language in share notes email for users ... Signed-off-by: Joas Schilling <coding@schilljs.com>	6 years ago
Joas Schilling	69eda9c0f6	Prevent harder to share your root ... Signed-off-by: Joas Schilling <coding@schilljs.com>	6 years ago
Daniel Calviño Sánchez	45de42a6b8	Fix disabling send password by Talk without new password in mail shares ... When "send password by Talk" was disabled in a mail share it was possible to keep the same password as before, as it does not pose any security issue (unlike keeping it when "send password by Talk" is enabled, as in that case the password was already disclosed by mail). However, if a mail share is updated but the password is not set again only the hashed password will be available. In that case it would not make sense to send the password by mail, so now the password must be changed when disabling "send password by Talk". Note that, even if explicitly setting the same password again along with the "send password by Talk" property would work, this was also prevented for simplicity. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	6 years ago
Daniel Calviño Sánchez	a426f84dbe	Fix enabling send password by Talk with same password in mail shares ... When "send password by Talk" is enabled in a mail share a new password must be also set. However, when the passwords of the original and the new share were compared it was not taken into account that the original password is now hashed, while the new one is not (unless no new password was sent, in which case the password of the original share was set in the new share by the controller, but that was already prevented due to both passwords being literally the same), so it was possible to set the same password again. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	6 years ago
Daniel Calviño Sánchez	7569590514	Fix enabling send password by Talk with empty password in link shares ... When "send password by Talk" is enabled in a link share now a non empty password is enforced. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	6 years ago
Morris Jobke	16f4b43d94	Adjust tests to only return group IDs ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	6 years ago
Roeland Jago Douma	f4b8623d33	Allow specifying a default expiration date ... This overrides the max expiration date. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	6 years ago
Julius Härtl	397ab1c3c5	Remove unneeded test since links have resharing permissions by default ... Signed-off-by: Julius Härtl <jus@bitgrid.net>	6 years ago
Christoph Wurst	caff1023ea	Format control structures, classes, methods and function ... To continue this formatting madness, here's a tiny patch that adds unified formatting for control structures like if and loops as well as classes, their methods and anonymous functions. This basically forces the constructs to start on the same line. This is not exactly what PSR2 wants, but I think we can have a few exceptions with "our" style. The starting of braces on the same line is pracrically standard for our code. This also removes and empty lines from method/function bodies at the beginning and end. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	afbd9c4e6e	Unify function spacing to PSR2 recommendation ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	2fbad1ed72	Fix (array) indent style to always use one tab ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	2ee65f177e	Use the shorter phpunit syntax for mocked return values ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Joas Schilling	e97d643969	Strip of users home path from share api message ... Signed-off-by: Joas Schilling <coding@schilljs.com>	6 years ago
Roeland Jago Douma	bb4264c565	config.php setting to always accept internal shares ... Part of #18255 Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	6 years ago
Roeland Jago Douma	3a7cf40aaa	Mode to modern phpunit ... Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	6 years ago
Roeland Jago Douma	078f4efb20	Fix tests ... Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	6 years ago
Roeland Jago Douma	8d4346d656	Fix more tests ... Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	6 years ago
Roeland Jago Douma	c007ca624f	Make phpunit8 compatible ... Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	6 years ago
Christoph Wurst	1a886b1472	Add typed events for password_policy ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Roeland Jago Douma	68748d4f85	Some php-cs fixes ... * Order the imports * No leading slash on imports * Empty line before namespace * One line per import * Empty after imports * Emmpty line at bottom of file Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	6 years ago
Daniel Calviño Sánchez	2f49806c20	Add unit tests for "getAllShares()" ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	6 years ago
Julius Härtl	22b81ac1e4	Fix permission check on incoming federated shares ... Since federated shares have their permissions set on the node, we do not need to check for parent share permissions. Otherwise reshares of incoming federated have no permission variable defined and creating them will fail Signed-off-by: Julius Härtl <jus@bitgrid.net>	7 years ago
Julius Härtl	857fae288c	Always set the display name for user shares ... Signed-off-by: Julius Härtl <jus@bitgrid.net>	7 years ago
Joas Schilling	85a80b05ac	Unify the permission checking in one place only ... Signed-off-by: Joas Schilling <coding@schilljs.com>	7 years ago
Joas Schilling	e4addbae3e	Better check reshare permissions when creating a share ... Signed-off-by: Joas Schilling <coding@schilljs.com>	7 years ago
Christoph Wurst	3174012adf	Add event dispatcher to OCP ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	7 years ago
Joas Schilling	f66c37bdb8	Correctly determinate the owner in case of shared external storages ... Signed-off-by: Joas Schilling <coding@schilljs.com>	7 years ago
Roeland Jago Douma	372f3d2a60	Remove deprecated functions from SecureRandom ... Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	7 years ago
Joas Schilling	ee545d6840	Fix typo in "incoming" ... Signed-off-by: Joas Schilling <coding@schilljs.com>	7 years ago
Daniel Calviño Sánchez	fe8a67f517	Store "sendPasswordByTalk" property of link shares in the database ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	7 years ago
Daniel Calviño Sánchez	00e4c8aee4	Fix update share tests ... The update share tests only checked that the share returned by "update()" had the expected values. However, as "update()" returns the same share that was given as a parameter the tests were not really verifying that the values were updated in the database. In a similar way, the test that checked that a password was removed did not set a password first, so even if the database returned null it could be simply returning the default value for the share; a password must be set first to ensure that it is removed. Besides that, a typo was fixed too that made the checks on the original share instead of on the one returned by "update()"; right now it is the same share, so the change makes no difference, but it is how the check should be done anyway. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	7 years ago