6728 Commits (6ee7e433da2b9f75fe41ca4dfd6b5296c120287f)

Author	SHA1	Message	Date
Ferdinand Thiessen	44c1fc5b46	feat(setup): allow to pass SSL/TLS config for database connection ... Allow to set the database configuration for SSL/TLS connection also during the setup. This is needed to allow installation with proper SSL configuration when using the AUTOCONFIG approach. Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	1 week ago
Ferdinand Thiessen	5084b58fd2	fix(NavigationManager): properly register closures ... Lately there were quite some issues with the NavigationManager, so this tries to clarifies the implementation a bit. But more important this fixes an issue when closures are registered after the setup was already done (see added unit test). Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	1 week ago
Robin Appelman	55e1270b94	refactor: use Share for most SharingManager parameters instead of just the id ... Signed-off-by: Robin Appelman <robin@icewind.nl> # Conflicts: # tests/lib/Sharing/AbstractSharingManagerTests.php # Conflicts: # apps/sharing/tests/Controller/ApiV1ControllerTest.php # tests/lib/Sharing/AbstractSharingManagerTests.php	1 week ago
Git'Fellow	4920bd1725	refactor: add PHP 8.3 types to BC-safe class constants ... PHP 8.3 allows class constants to declare a type. Adopt it where doing so cannot break third-party apps. Typing an inheritable constant is a hard BC break: a subclass that redeclares it untyped fails to load with "Type of C::FOO must be compatible with P::FOO of type string". Changes are therefore limited to constants that cannot be redeclared by a subclass: - private const (not inherited) - final public/protected const - constants declared in a final class or an enum Interface constants, trait constants, and public/protected constants in non-final (including abstract) classes are left untyped, as is all of lib/public (OCP) and lib/unstable (NCU). One review-requested exception: the public OBJECT_PREFIX/OBJECT_SUFFIX constants of the app-internal CalDAV import helpers (TextImporter, XmlImporter) are typed as well; these classes are not public API and have no subclasses. Only string, int and array are used. float is avoided because it would silently coerce an int literal and change === comparisons. No constant name or value is modified: every changed line adds only the type token, so runtime behaviour is unchanged. Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>	1 week ago
Côme Chilliet	d9867d73b2	chore(sharing): Improve typing in tests to please psalm:strict ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	1 week ago
Côme Chilliet	3728c88521	fix(32bits): Store timestamp in ms in a string to avoid int overflow ... Same strategy as for snowflake ids. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	1 week ago
Jan C. Borchardt	2c34ed878f	feat(core): sort the app menu by topic for a default install ... Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Jan C. Borchardt <925062+jancborchardt@users.noreply.github.com>	2 weeks ago
Côme Chilliet	66fed88006	fix: Revert using setValueBool in User class ... Too many code relies on the value being stored as a true/false string. setValueBool currently stores 1/0 and breaks things. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	2 weeks ago
Côme Chilliet	7f4e722c6b	feat: Use a class to materialize user config entries ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	2 weeks ago
Côme Chilliet	00d58abd0b	chore: Adapt UserTest to IUserConfig ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	2 weeks ago
Côme Chilliet	4e34261967	chore: merge valueDetails into fastCache and lazyCache to avoid out-of-sync issues ... It feels like a UserConfigEntry class would make sense instead of the currently used array to represent an entry. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	2 weeks ago
Côme Chilliet	4967f7bf48	fix: Use a CappedMemoryCache for UserConfig to avoid memory exhaustion ... When moving user preferences from AllConfig to UserConfig, the CappedMemoryCache became an array, which means memory can be filled with user preferences if you loop on all users and check a preference on them. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	2 weeks ago
Michel Le Bihan	25afab8968	feat(webauthn): Skip 2FA for user verified logins ... A WebAuthn login with user verification is already a second factor, so do not ask for an additional 2FA challenge Signed-off-by: Michel Le Bihan <michel@lebihan.pl>	2 weeks ago
Micke Nordin	3dcf085f64	test(OCM): Throw IdentityNotFoundException ... Signed-off-by: Micke Nordin <kano@sunet.se>	2 weeks ago
nextcloud-command	641c4b8c0d	refactor: Apply rector changes ... Signed-off-by: GitHub <noreply@github.com>	2 weeks ago
Micke Nordin	41cc0a4ed6	chore(http-sig): Simplify implementation ... Signed-off-by: Micke Nordin <kano@sunet.se>	2 weeks ago
Micke Nordin	f0edd14c3a	chore(cloud_federation_api): move jwks ... Move from .well-known/jwks.json to the TokenController Signed-off-by: Micke Nordin <kano@sunet.se>	2 weeks ago
Micke Nordin	dae8a36460	fix(ocm): treat RFC 9421 keyid as opaque, verify by sender origin ... RFC 7517 §4.5 leaves the keyid structure unspecified, so the receiver must not parse it. The signer origin now comes from the trusted OCM share/sender identity; the JWK Set is resolved against that origin and the keyid is matched opaquely to the JWKS kid. Aligns with the OCM verification procedure and fixes the origin-mismatch / flaky-kid failures in the two-port integration rig. Reverts the per-request host-based kid back to a stable persisted kid, drops keyid->host parsing, threads a sender-origin parameter through verification, and resolves that origin in every OCM inbound entry point (notifications, shares, token exchange, OCM requests) and the federation rate limiter. Cavage is unchanged. Assisted-by: ClaudeCode:glm-5.2 Signed-off-by: Micke Nordin <kano@sunet.se>	2 weeks ago
Micke Nordin	2abd52caaa	fix(ocm): derive JWKS signing keyId per request, not from a frozen host ... The JWKS signing keyId was persisted as a full URL, frozen at whichever host provisioned the key first. An instance addressed by more than one host (the two-port integration rig, or a port change behind a proxy) then signed with a keyId whose host no longer matched its federated share identity, so receivers rejected the request with an origin mismatch. Persist only a stable opaque key id (ecdsa-p256-sha256-<n>) and rebuild the full keyId per request from the current URL, in both the signing signatory and the published JWK Set. The signature keyid and the JWKS kid still match, since both are built from the same opaque id and the current request host. Rotation still works: slots differ by the counter, and the host is just fresh context. Drops the resolveKidBase/canonicalKid hostname machinery and the ocm_jwks_kid_base appconfig, which are no longer needed. Assisted-by: ClaudeCode:glm-5.2 Signed-off-by: Micke Nordin <kano@sunet.se>	2 weeks ago
Micke Nordin	f602a7aff8	fix(ocm): allow plain-http jwksUri for http-only peers ... The spec mandates https for jwksUri but allows an HTTP fallback in testing setups. Advertise the scheme the instance actually serves, and accept an http jwksUri only from a peer whose own endpoint is http: integration tests and http intranets work without configuration, while an https peer advertising an http jwksUri is still rejected, since that downgrade would let a path attacker swap the key material. An https jwksUri is always accepted, also from http-only peers, and it may live on a different host than the peer. Signed-off-by: Micke Nordin <kano@sunet.se>	2 weeks ago
Micke Nordin	410d8c144b	feat(ocm): align RFC 9421 http-sig with updated OCM spec ... Implements the changes from cs3org/OCM-API#391 and closes the remaining gaps with the HTTP Message Signatures section: - discover peer JWK Sets via the new `jwksUri` discovery field instead of the fixed /.well-known/jwks.json path; advertise our own jwksUri and require it (https) from peers advertising the `http-sig` capability - stop covering the Date header; freshness is anchored on the `created` signature parameter - mark and select the OCM signature by its integrity-protected tag="ocm" parameter instead of the dictionary label - require the JWK `alg` parameter and derive the signature algorithm from it, accepting fully-specified RFC 9864 names - reject signed requests whose verification key cannot be resolved instead of treating them as unsigned - derive the signer origin from the spec-canonical fqdn#id keyid form Signed-off-by: Micke Nordin <kano@sunet.se>	2 weeks ago
Robin Appelman	03c110c772	feat: keep a classname mapping instead of always storing the full name ... Signed-off-by: Robin Appelman <robin@icewind.nl> # Conflicts: # lib/private/Sharing/SharingBackend.php # lib/private/Sharing/SharingManager.php	2 weeks ago
Maxence Lange	8ef3951fa9	fix(lookup-server): accept self-signed lus on globalscale ... Signed-off-by: Maxence Lange <maxence@artificial-owl.com>	2 weeks ago
Robin Appelman	5964aa55f7	refactor: use DateTimeImmutable in unified sharing api instead of timestamp ... Signed-off-by: Robin Appelman <robin@icewind.nl> # Conflicts: # apps/files/tests/Sharing/Source/NodeShareSourceTypeTest.php	2 weeks ago
Robin Appelman	2cc819aef9	chore: psalm fixes ... Signed-off-by: Robin Appelman <robin@icewind.nl>	2 weeks ago
Robin Appelman	6be6d9e695	perf: fetch share source metadata in bulk ... Signed-off-by: Robin Appelman <robin@icewind.nl>	2 weeks ago
Robin Appelman	426142d427	refactor: use IUser for IShareSourceType::getSourceInteractionResource instead of user id string ... Signed-off-by: Robin Appelman <robin@icewind.nl>	2 weeks ago
Carl Schwan	80046aae1d	test(sharing): sort recipients before asserting in testGetShareWithPublicSecret ... The error in question ```diff ApiV1ControllerTest::testGetShareWithPublicSecret with data set #0 (true) Failed asserting that two arrays are equal. --- Expected +++ Actual @@ @@ Array ( - 'class' => 'Test\Sharing\TestShareRecipientType1' - 'value' => 'recipient1' + 'class' => 'Test\Sharing\TestShareRecipientTypePublicSecret' + 'value' => 'recipient2' 'instance' => null - 'display_name' => 'Recipient 1' + 'display_name' => 'Recipient 2' 'icon' => [...] 'secret' => Array ( 'updatable' => false + 'value' => '47BN3fes63WP0usnjUyF3pUYJh36RHMl' + 'url' => 'http://localhost/index.php/s/...36RHMl' ) 'initiator' => [...] ) ``` Signed-off-by: Carl Schwan <carl@carlschwan.eu>	2 weeks ago
Joas Schilling	cd12e73710	fix: Handle 2fa enforcement earlier ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2 weeks ago
Robin Appelman	04bd425859	refactor: introduce a separate class for holding share source metadata ... Signed-off-by: Robin Appelman <robin@icewind.nl>	2 weeks ago
Kent Delante	d7b0c3d49e	test: add test for new getDisplayUser() method in OC\User\Manager ... Signed-off-by: Kent Delante <kent@delante.me> Assisted-by: ClaudeCode:claude-sonnet-5	2 weeks ago
Ferdinand Thiessen	38c4b384ce	fix(setup): de-duplicate host parsing allowing IPv6 connections ... The de-duplicates the connection params parsing, previously it used `explode` to get host + port but this fails for IPv6 like `[::1]:80`. But a proper parsing is already available in the `ConnectionFactory`, so adjusted the code to reuse that. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	2 weeks ago
Kent Delante	b562f282cb	test(files_sharing): add tests for fetching remote avatars ... Signed-off-by: Kent Delante <kent@delante.me> Assisted-by: ClaudeCode:claude-sonnet-5	2 weeks ago
Stefan Dietrich	7912a85722	fix: tests wrongly assumed ordered items ... Signed-off-by: Stefan Dietrich <5716289+stediefan@users.noreply.github.com>	2 weeks ago
Carl Schwan	779b45f57f	feat: Add setting to bypass password confirmation on a selected ip ranges ... Signed-off-by: Carl Schwan <carl@carlschwan.eu>	2 weeks ago
Carl Schwan	c4f3912c3e	feat: Allow to check user existence outside specific user backends ... Signed-off-by: Carl Schwan <carl@carlschwan.eu>	2 weeks ago
Jan C. Borchardt	1fdc9fde66	fix(core): hide personal settings of apps not enabled for the user ... Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Jan C. Borchardt <925062+jancborchardt@users.noreply.github.com>	2 weeks ago
Edmond	12ff385bbf	fix(core): handle parameter limits in files metadata deletion ... Bind each existing MAX_IN_PARAMETERS chunk in dropMetadataForFiles instead of passing the full file ID array to every query. Add a regression test that verifies the exact chunks sent to the query builder. Resolves: #62325 Signed-off-by: Edmond <edmnd@users.noreply.github.com>	2 weeks ago
Robin Appelman	256c4c3d1b	fix: strip trailing dots from hostnames and ips before validation ... Signed-off-by: Robin Appelman <robin@icewind.nl>	2 weeks ago
Robin Appelman	5dc786b937	fix: handle additional ipv6/ipv4 translation mechanisms when checking if remote is local ... Signed-off-by: Robin Appelman <robin@icewind.nl> # Conflicts: # tests/lib/Net/IpAddressClassifierTest.php	2 weeks ago
Daniel Kesselberg	f32ffce370	test(net): Add more ip classifier test cases ... Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>	2 weeks ago
Stefan Dietrich	faf66fef7b	fix(teams): add consumable and implementable annotations ... fix: tests for TeamFolderProvider and TeamManager Assisted-by: GitHub Copilot:GPT-5.6 Terra Signed-off-by: Stefan Dietrich <5716289+stediefan@users.noreply.github.com>	2 weeks ago
Stefan Dietrich	43f83ed3c9	feat: introduce a function to bind a teamfolder to a team ... Assisted by: GitHub Copilot:Claude Sonnet 5 Assisted by: GitHub Copilot:GPT-5.6 Terra Assisted by: GitHub Copilot:Kimi K2.7 Code Signed-off-by: Stefan Dietrich <5716289+stediefan@users.noreply.github.com>	2 weeks ago
Peter Ringelmann	4735e29c85	fix(provisioning_api): read newUser.sendEmail as a boolean ... Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>	3 weeks ago
Daniel Kesselberg	cf01026fc6	fix(imip): don't report success when a calendar cannot process iMip ... handleIMip() checked IHandleImipMessage only inside the match, so a writable calendar unable to process iMip returned true without doing anything. Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>	3 weeks ago
David Dreschner	acf233c33a	fix(Database): Use real idle-timer to prevent `lastInsertId` being reset on MariaDB/MySQL ... The previous implementation of the idle timer runs on a strict 30 second interval and sends a dummy `SELECT` statement to keep the connection open. This generates issues with the `lastInsertId` on long-running tasks (like our CI pipeline), as the MariaDB documentation clearly states: > If the last query wasn't an INSERT or UPDATE statement or if the modified table does not have a column with the AUTO_INCREMENT attribute and LAST_INSERT_ID was not used, this function will return zero. Source: https://mariadb.com/docs/connectors/mariadb-connector-c/api-functions/mysql_insert_id To mitigate that, this commit now uses a real idle-timer per connection instead. Assisted-by: ClaudeCode:claude-fable-5 Signed-off-by: David Dreschner <david.dreschner@nextcloud.com>	3 weeks ago
Carl Schwan	7335eaf897	refactor: Use GlobalScale/IConfig everywhere ... Signed-off-by: Carl Schwan <carl@carlschwan.eu>	3 weeks ago
provokateurin	8c92be9c2c	refactor(Sharing): Always store shares in unified sharing backend and only use legacy backends to process updates ... Signed-off-by: provokateurin <kate@provokateurin.de> Conflicts: apps/sharing/lib/AppInfo/Application.php lib/private/Sharing/SharingManager.php lib/private/Sharing/SharingRegistry.php lib/unstable/Sharing/ISharingBackend.php lib/unstable/Sharing/ISharingRegistry.php	3 weeks ago
provokateurin	f7be3383de	refactor(Sharing): Move SharingBackend to OC ... Signed-off-by: provokateurin <kate@provokateurin.de> # Conflicts: # apps/sharing/lib/AppInfo/Application.php	3 weeks ago
Marcel Müller	07e123e2de	test: Add PHP_AUTH_PW test for strict password confirmation ... Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>	3 weeks ago