nextcloud-server

Commit Graph

Author	SHA1	Message	Date
Stephen Cuppett	b6fddabf6c	fix(encryption): Address review feedback and fix zero-byte size consistency Apply come-nc's reviewer suggestions on Scanner.php: - Simplify cached unencrypted_size skip condition to explicit == 0 check - Remove redundant !isset guard on new-file path Fix remaining > 0 / !== 0 guards that treated zero as "no unencrypted_size": - FileInfo constructor: use encrypted flag for rawSize (getSize(false) path) - FileInfo::addSubEntry: use encrypted flag for sub-mount accumulation - Cache::calculateFolderSizeInner: use encrypted column instead of > 0 Add tests covering zero-byte encrypted file scenarios: - FileInfoTest: getSize(true/false) for zero-byte encrypted files - CacheTest: getUnencryptedSize and calculateFolderSize with encrypted=1,size=0 - EncryptionTest: verifyUnencryptedSize data provider cases for header-only files Assisted-by: ClaudeCode:claude-opus-4-6 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Stephen Cuppett <scuppett@redhat.com>	1 month ago
Enrique Pérez Arnaud	3616212ba2	feat(files_sharing): store and refresh OCM access tokens for external shares Co-authored-by: Micke Nordin <kano@sunet.se> Signed-off-by: Micke Nordin <kano@sunet.se> Signed-off-by: Enrique Pérez Arnaud <enrique@cazalla.net>	2 months ago
Côme Chilliet	1ab09ec753	chore: Apply new coding standard to all files The diff can be checked using: git diff --ignore-all-space --ignore-blank-lines To see only the changes not related to blank lines. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 months ago
nextcloud-command	fd14234a6a	refactor: Apply rector changes Signed-off-by: GitHub <noreply@github.com>	3 months ago
Robin Appelman	9f5535d01b	fix: apply quota with writeStream Signed-off-by: Robin Appelman <robin@icewind.nl>	4 months ago
Robin Appelman	f3a5bc8c17	fix: block writing empty files with 0 quota Signed-off-by: Robin Appelman <robin@icewind.nl>	4 months ago
Ferdinand Thiessen	e5b1799079	chore: add missing `Override` attribute to test files Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	4 months ago
Josh	2d39c5a179	test(Storage): avoid falsy directory/filename checks (for now) Signed-off-by: Josh <josh.t.richards@gmail.com>	6 months ago
Josh	ace9eb21e6	test(Storage): expand file / directory name tests Signed-off-by: Josh <josh.t.richards@gmail.com>	6 months ago
Robin Appelman	bd8f251ad8	test: add test for calling filesize on non-existing files Signed-off-by: Robin Appelman <robin@icewind.nl>	6 months ago
provokateurin	4eada2d804	refactor(Files): Modernize Wrapper Signed-off-by: provokateurin <kate@provokateurin.de>	6 months ago
provokateurin	5f4a5d8c67	refactor(Files): Remove deprecated streamCopy method Signed-off-by: provokateurin <kate@provokateurin.de>	6 months ago
provokateurin	f12cecb684	feat(rector): Enable SafeDeclareStrictTypesRector Signed-off-by: provokateurin <kate@provokateurin.de>	6 months ago
Carl Schwan	c96ece0bcb	refactor: Add more typing - repairs job - database - redis And remove Helpertest which was unused outside of some tests. Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	7 months ago
Robin Appelman	2970232790	fix: make failed availability check apply in the same request Signed-off-by: Robin Appelman <robin@icewind.nl>	10 months ago
Ferdinand Thiessen	d6d6747a73	refactor: apply rector rules for PHPUnit 10 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	10 months ago
Carl Schwan	b0357663b9	perf(preview): Optimize migration and simplify DB layout * Simplify migration by not moving the actual files and just updating the DB * Don't store the storageid in the preview table as it is not needed * Start adding tests Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	11 months ago
Carl Schwan	8e5eef24d2	refactor: Remove OC_Helper::streamCopy Replace by Files::streamCopy, also deprecated but since less long Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	11 months ago
Ferdinand Thiessen	660f3f6fd1	refactor: use logical `&&` `\|\|` instead of weak `and` `or` operators Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	11 months ago
Côme Chilliet	bc5e29f9f2	fix(tests): Fix type issues and other problems with encryption tests Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	12 months ago
Robin Appelman	aa15f9d16d	chore: run rector Signed-off-by: Robin Appelman <robin@icewind.nl>	1 year ago
Ferdinand Thiessen	5981b7eb51	chore: apply new CSFixer rules Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de> # Conflicts: # apps/settings/lib/SetupChecks/PhpOpcacheSetup.php	1 year ago
Robin Appelman	3561937816	chore: run rector on tests with new rule Signed-off-by: Robin Appelman <robin@icewind.nl>	1 year ago
Robin Appelman	29e39c0a2e	chore: run rector on tests Signed-off-by: Robin Appelman <robin@icewind.nl>	1 year ago
Joas Schilling	a425a1affc	test: Add a hint message on boolean comparison Signed-off-by: Joas Schilling <coding@schilljs.com>	1 year ago
Côme Chilliet	9560e00cf3	chore: Remove useless legacy autoloader for tests Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	1 year ago
Ferdinand Thiessen	494a079321	test: replace `OC_Helper:rmdirr` with `OCP\Files::rmdirr` Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	1 year ago
Joas Schilling	5283e9a5e2	test: Cleanup tests/lib/Files/* Signed-off-by: Joas Schilling <coding@schilljs.com>	1 year ago
Côme Chilliet	a79b5dea7c	fix(encryption): Improve Update class and event listenening to avoid back&forth between path and Node object Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	1 year ago
Joas Schilling	c24f5fb256	test: Finish migrating tests/Core/ to PHPUnit 10 compatible code Signed-off-by: Joas Schilling <coding@schilljs.com>	1 year ago
Louis Chemineau	8fdf2a7eae	fix: Transfer ownership with S3 as primary When using S3 as primary storage, transferring ownership with the `--move` option fail with the following error: `SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '8-45b963397aa40d4a0063e0d85e4fe7a1' for key 'fs_storage_path_hash'` The `--move` option moves the entire home folder from one account to another. The error means that the move failed because the destination folder already exist in `oc_filecache`. - With S3 as primary storage, folders only exists as entries in `oc_filecache`. - With S3 as primary storage, `moveFromStorage(...)` only moves the cache entry, as nothing needs to be moved on disk. This cache move does not delete potentially pre-existing destination folder. - With Local storage, `moveFromStorage(...)` calls `rename(...)` which delete pre-existing folder. - `transfer(...)`: `687a4d9ac7/apps/files/lib/Service/OwnershipTransferService.php (L112)` - `oneTimeUserSetup(...)`: `687a4d9ac7/lib/private/Files/SetupManager.php (L261-L262)` - `mkdir(...)`: `687a4d9ac7/lib/private/Files/ObjectStore/ObjectStoreStorage.php (L91-L135)` - `moveFromStorage(...)`: `687a4d9ac7/lib/private/Files/ObjectStore/ObjectStoreStorage.php (L635-L636)` Delete pre-existing folder in `moveFromStorage(...)` Signed-off-by: Louis Chemineau <louis@chmn.me>	1 year ago
Ferdinand Thiessen	b48ee2e924	fix: Harden files scanner for invalid null access Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de> Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com> Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	2 years ago
provokateurin	0de4843b73	refactor(Storage): Align all Storage constructors Signed-off-by: provokateurin <kate@provokateurin.de>	2 years ago
Robin Appelman	7cb07bf306	test: add test for nested jail cross-storage move Signed-off-by: Robin Appelman <robin@icewind.nl>	2 years ago
provokateurin	f28e74b7a8	refactor(Storage): Make all parameter types strong types Signed-off-by: provokateurin <kate@provokateurin.de>	2 years ago
provokateurin	4412b2b8a8	refactor(Wrapper\Encryption): Migrate to strong types Signed-off-by: provokateurin <kate@provokateurin.de>	2 years ago
provokateurin	256a8d8903	test: Fix IStorage return types Signed-off-by: provokateurin <kate@provokateurin.de>	2 years ago
Louis Chemineau	22d5d29c01	fix(users): Don't crash if disabled user is missing in the database Signed-off-by: Louis Chemineau <louis@chmn.me>	2 years ago
provokateurin	9836e9b164	chore(deps): Update nextcloud/coding-standard to v1.3.1 Signed-off-by: provokateurin <kate@provokateurin.de>	2 years ago
Côme Chilliet	cfca7e7911	fix(tests): Fix most obvious errors in ObjectStore tests Some are still failing Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	2 years ago
Côme Chilliet	22822d5e9b	fix: Fix other uses of removed Storage interface Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	2 years ago
Christoph Fiehe	9597072ada	perf(ObjectStoreStorage): Improve (slow) move on same object bucket This commit fixes the issue #47856. When you upload a file into a group folder and when you use a single S3 bucket as primary storage, the final move operation hangs for a long time. In the background, Nextcloud initiates a copy-delete sequence from the bucket into the bucket, with causes a lot unnecessary overhead. Nextcloud thinks that the file must be imported to another storage and does not recognize that everything is done on the same object bucket. In that case, the import step can be completely skipped, which saves time, network bandwidth and reduces the load on the object storage. The behavior improves a lot with https://github.com/nextcloud/server/pull/46013. However, there are still some put messages that are being sent to the object storage when you use an object storage as primary storage and upload files into a group folder. Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com> Signed-off-by: Christoph Fiehe <c.fiehe@eurodata.de>	2 years ago
Christoph Wurst	49dd79eabb	refactor: Add void return type to PHPUnit test methods Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	2 years ago
Daniel Kesselberg	af6de04e9e	style: update codestyle for coding-standard 1.2.3 Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>	2 years ago
Ferdinand Thiessen	69341e4306	refactor: Migrate filename validation logic from `Storage` to `FilenameValidator` Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	2 years ago
Andy Scherzinger	1f7e2ba599	chore: Add SPDX header Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>	2 years ago
Ferdinand Thiessen	27642d3e6d	fix: Enforce forbidden filename characters on backend Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	3 years ago
Robin Appelman	5aea3f4d76	make storage directory test be a bit less strict about mtimes sometimes the clock ticks over during the test Signed-off-by: Robin Appelman <robin@icewind.nl>	3 years ago
Joas Schilling	aa5f037af7	chore: apply changes from Nextcloud coding standards 1.1.1 Signed-off-by: Joas Schilling <coding@schilljs.com> Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>	3 years ago
Robin Appelman	ccf8843d9f	apply known mtime wrapper for external storages Signed-off-by: Robin Appelman <robin@icewind.nl>	3 years ago

1 2 3

128 Commits (6ee7e433da2b9f75fe41ca4dfd6b5296c120287f)