nextcloud-server

Commit Graph

Author	SHA1	Message	Date
Git'Fellow	4920bd1725	refactor: add PHP 8.3 types to BC-safe class constants PHP 8.3 allows class constants to declare a type. Adopt it where doing so cannot break third-party apps. Typing an inheritable constant is a hard BC break: a subclass that redeclares it untyped fails to load with "Type of C::FOO must be compatible with P::FOO of type string". Changes are therefore limited to constants that cannot be redeclared by a subclass: - private const (not inherited) - final public/protected const - constants declared in a final class or an enum Interface constants, trait constants, and public/protected constants in non-final (including abstract) classes are left untyped, as is all of lib/public (OCP) and lib/unstable (NCU). One review-requested exception: the public OBJECT_PREFIX/OBJECT_SUFFIX constants of the app-internal CalDAV import helpers (TextImporter, XmlImporter) are typed as well; these classes are not public API and have no subclasses. Only string, int and array are used. float is avoided because it would silently coerce an int literal and change === comparisons. No constant name or value is modified: every changed line adds only the type token, so runtime behaviour is unchanged. Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>	1 week ago
Carl Schwan	9dad62c6eb	fix(db): Adapt migrations to new OCP\DB\Schema Signed-off-by: Carl Schwan <carl@carlschwan.eu>	2 weeks ago
Joas Schilling	e7004a5387	chore(workflows): Migrate to CappedMemoryCache Signed-off-by: Joas Schilling <coding@schilljs.com>	1 month ago
Joas Schilling	c0f8fa87bd	chore(workflow): Simplify code in URL check Signed-off-by: Joas Schilling <coding@schilljs.com>	1 month ago
Joas Schilling	75a6822b15	perf(workflows): Fix cache in request time check Signed-off-by: Joas Schilling <coding@schilljs.com>	1 month ago
Joas Schilling	21d7937a20	perf(workflow): Implement result cache for IP checks Signed-off-by: Joas Schilling <coding@schilljs.com>	1 month ago
Carl Schwan	da0928827a	refactor: Expose a public exception when no user is found And use this new exception everywhere outside of where the old one was throw. Signed-off-by: Carl Schwan <carlschwan@kde.org>	2 months ago
Ferdinand Thiessen	248054dc9a	fix(workflowengine): GROUP BY alias not cast expression (SQL) Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	2 months ago
Côme Chilliet	1ab09ec753	chore: Apply new coding standard to all files The diff can be checked using: git diff --ignore-all-space --ignore-blank-lines To see only the changes not related to blank lines. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 months ago
Salvatore Martire	2a9036a5b7	feat(wfe): add runtime operations Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com> # Conflicts: # apps/workflowengine/lib/Manager.php	3 months ago
Ferdinand Thiessen	d8e8703796	chore: add missing `Override` attribute to app code Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	4 months ago
Côme Chilliet	94774ca5c3	chore: Remove long-time deprecated things from workflowengine Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	4 months ago
Ferdinand Thiessen	645350d4b2	fix(workflowengine): remove non existing script loading - resolves https://github.com/nextcloud/server/issues/59385 The script does not exist anymore, so remove it. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	5 months ago
Côme Chilliet	2c068f3683	fix: Remove static vars from applications Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	5 months ago
Joas Schilling	1bc0bd7611	fix(workflowengine): Fix list of checks being a list instead of array<int, …> Signed-off-by: Joas Schilling <coding@schilljs.com>	6 months ago
Ferdinand Thiessen	a32168b01e	chore!(core): remove legacy `OC.Files.Client` Use the DAV client from `@nextcloud/files/dav` instead. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	6 months ago
Joas Schilling	4134df9eda	feat(workflowengine): Add openapi for workflow engine Signed-off-by: Joas Schilling <coding@schilljs.com>	6 months ago
provokateurin	f12cecb684	feat(rector): Enable SafeDeclareStrictTypesRector Signed-off-by: provokateurin <kate@provokateurin.de>	6 months ago
Louis Chmn	315241fb44	fix: Migrate `getById` to `getFirstNodeById` Signed-off-by: Louis Chmn <louis@chmn.me>	7 months ago
Daniel Kesselberg	bf5c11a8fa	fix(workflowengine): use constant to render template Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>	7 months ago
Carl Schwan	11cf69d8ba	fix(psalm): Fix static analysis issues in apps/*/tests There are still 1200 more to fix before we can enable static analysis for the tests. Signed-off-by: Carl Schwan <carlschwan@kde.org>	7 months ago
Carl Schwan	7541afae07	refactor(workflowengine): Check if class is correct Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	9 months ago
Carl Schwan	4d47fdaa85	chore: Run rector with new rules for fetch Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	9 months ago
rakekniven	ee39b5093d	chore(l10n): Use numbered placeholders Reported in Transifex. Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>	10 months ago
Josh	f5039750b3	chore: fix formatting Signed-off-by: Josh <josh.t.richards@gmail.com>	11 months ago
Josh	5131897997	fix(workflowenigne): stricter length headler handling Fixes #55276 and tidies things up a bit more for future maintenance. Signed-off-by: Josh <josh.t.richards@gmail.com>	11 months ago
Carl Schwan	6154bfa823	chore(psalm): Fix most issues with the workflowengine This found a real bug where we were catching an Doctrine exception instead of a OCP\DB\Exception. This will be backported separately. Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	11 months ago
Carl Schwan	7e1c49ad9d	refactor: Port away from IQueryBuilder::execute in apps/ Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	11 months ago
Carl Schwan	0e7d5dce1c	refactor: Port away from changeColumn Replace by the drop-in replacement modifyColumn Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	11 months ago
Joas Schilling	78dcf3744d	Revert "feat: Implement Directory Check" This reverts commit `feae8ba16a`.	1 year ago
Robin Windey	feae8ba16a	feat: Implement Directory Check * Partially implements #27591 Signed-off-by: Robin Windey <ro.windey@gmail.com>	1 year ago
Ferdinand Thiessen	5981b7eb51	chore: apply new CSFixer rules Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de> # Conflicts: # apps/settings/lib/SetupChecks/PhpOpcacheSetup.php	1 year ago
Côme Chilliet	cd3a88805b	fix: Remove legacy hacky workaround in OCA\WorkflowEngine\Listener It is not needed anymore since OCP\Util::addScript is used directly now, and not the function "script" from template functions. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	1 year ago
Côme Chilliet	64863c9d46	chore: Apply new rector configuration to apps folder Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	2 years ago
provokateurin	f25a71806b	fix(apps): Fix wrong or missing casts Signed-off-by: provokateurin <kate@provokateurin.de>	2 years ago
provokateurin	381077028a	refactor(apps): Use constructor property promotion when possible Signed-off-by: provokateurin <kate@provokateurin.de>	2 years ago
Git'Fellow	c254855222	chore(db): Correctly apply query types fix: psalm fix: error fix: add batch fix: fatal error fix: add batch chore: add batch chore: add batch fix: psalm fix: typo fix: psalm fix: return bool fix: revert Manager	2 years ago
Côme Chilliet	1a4978c4ea	chore: Apply rector configuration to apps folder Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	2 years ago
provokateurin	9836e9b164	chore(deps): Update nextcloud/coding-standard to v1.3.1 Signed-off-by: provokateurin <kate@provokateurin.de>	2 years ago
provokateurin	c2fb7a72da	fix(psalm): Fix @throws annotations Signed-off-by: provokateurin <kate@provokateurin.de>	2 years ago
Daniel Kesselberg	af6de04e9e	style: update codestyle for coding-standard 1.2.3 Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>	2 years ago
provokateurin	e64667df37	refactor(workflowengine): Replace security annotations with respective attributes Signed-off-by: provokateurin <kate@provokateurin.de>	2 years ago
Joas Schilling	a2a0a5afcb	fix(workflows): Fix file systemtag cache Signed-off-by: Joas Schilling <coding@schilljs.com>	2 years ago
Andy Scherzinger	cc1686dba9	chore: Add SPDX header Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>	2 years ago
Côme Chilliet	ec5133b739	fix: Apply new coding standard to all files Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	2 years ago
Côme Chilliet	8bcc2d352e	chore: Fix missing template parameter for IEventListener Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 years ago
Joas Schilling	aa5f037af7	chore: apply changes from Nextcloud coding standards 1.1.1 Signed-off-by: Joas Schilling <coding@schilljs.com> Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>	3 years ago
Joas Schilling	d8ffbed2c2	fix(workflows): Finish password confirmation Signed-off-by: Joas Schilling <coding@schilljs.com>	3 years ago
Arthur Schiwon	93505b2cdd	fix(workflowengine): use andWhere() not second where() - an unconditional where() condition is added right before - fixes also wrongly named methods in the Exception message Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>	3 years ago
Joas Schilling	997a1c46fb	fix(workflow): Fix "Call to a member function getUID() on null" with appdata Signed-off-by: Joas Schilling <coding@schilljs.com>	3 years ago

1 2 3 4 5

250 Commits (78d33182a01bb4da4d3d8afc6fcaa1b29fcd44c7)