186 Commits (7c6a692669cf18895665c19f2ee47cdbdc1c72cc)

Author	SHA1	Message	Date
Git'Fellow	4920bd1725	refactor: add PHP 8.3 types to BC-safe class constants ... PHP 8.3 allows class constants to declare a type. Adopt it where doing so cannot break third-party apps. Typing an inheritable constant is a hard BC break: a subclass that redeclares it untyped fails to load with "Type of C::FOO must be compatible with P::FOO of type string". Changes are therefore limited to constants that cannot be redeclared by a subclass: - private const (not inherited) - final public/protected const - constants declared in a final class or an enum Interface constants, trait constants, and public/protected constants in non-final (including abstract) classes are left untyped, as is all of lib/public (OCP) and lib/unstable (NCU). One review-requested exception: the public OBJECT_PREFIX/OBJECT_SUFFIX constants of the app-internal CalDAV import helpers (TextImporter, XmlImporter) are typed as well; these classes are not public API and have no subclasses. Only string, int and array are used. float is avoided because it would silently coerce an int literal and change === comparisons. No constant name or value is modified: every changed line adds only the type token, so runtime behaviour is unchanged. Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>	1 week ago
Lukas Schaefer	a17fb0725a	Feat: Add MultimodalChatWithTools and MultimodalContextAgentInteraction ... Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>	1 month ago
nextcloud-command	cbbbe5ac14	refactor: Apply rector changes ... Signed-off-by: GitHub <noreply@github.com>	1 month ago
Git'Fellow	fcc63b9603	refactor(dbal): move to modern calls ... Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> Signed-off-by: Carl Schwan <carlschwan@kde.org>	1 month ago
Marcel Klehr	1c88b39343	fix(TaskProcessing): Claim tasks atomically in both SynchronousBackgroundJob and TaskProcessingApiController ... see #61053 Signed-off-by: Marcel Klehr <mklehr@gmx.net>	1 month ago
Marcel Klehr	c5c7b98e91	fix(TaskProcessing): Sanitize file extension and remove mimetype property ... Signed-off-by: Marcel Klehr <mklehr@gmx.net>	1 month ago
Marcel Klehr	950ef2dcd5	fix(TaskProcessing): Fix file output validation ... Signed-off-by: Marcel Klehr <mklehr@gmx.net>	1 month ago
Marcel Klehr	1a5d59937a	fix: Add dot before file extension ... Signed-off-by: Marcel Klehr <mklehr@gmx.net>	1 month ago
Marcel Klehr	f961edf5e5	feat(TaskProcessing): Store output files with extension to ease mimetype guessing ... Signed-off-by: Marcel Klehr <mklehr@gmx.net>	1 month ago
Lukas Schaefer	9f719d00a4	fix: Output shape validation will delete keys when there is a list of files ... Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>	1 month ago
Lukas Schaefer	a4a753c952	feat(TaskProcessing): add TextToTextImprove to improve or iterate on text ... Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>	2 months ago
Julien Veyssier	76551aa69a	feat(TaskProcessing): add AudioToAudioTranslate TaskType ... Signed-off-by: Julien Veyssier <julien-nc@posteo.net>	2 months ago
Edward Ly	2d01dd6327	feat(TaskProcessing): add AudioToTextSubtitles TaskType ... Signed-off-by: Edward Ly <contact@edward.ly>	2 months ago
Yoan Bozhilov	df2368896f	docs(taskprocessing): document lockTask semantic change ... Per review feedback: note in the lockTask docblock that the guard changed from `status != RUNNING` to `status = SCHEDULED`, and that callers must now treat a 0 return as "the task is no longer claimable" rather than assuming success. Signed-off-by: Yoan Bozhilov <bygadd@gmail.com> Assisted-by: Claude Code:claude-opus-4-8	2 months ago
Yoan Bozhilov	022531b997	fix(taskprocessing): guard lockTask on scheduled, record started_at, Oracle fallback ... Address review feedback (@marcelklehr, Copilot): - lockTask claims only SCHEDULED tasks (was status != RUNNING) and stamps started_at in the same atomic UPDATE, so a finished task cannot be re-claimed and the external-provider claim path records started_at as well. - claimWithBoundedRetry re-reads after lockTask instead of a follow-up UPDATE. - Oracle joins SQLite on the bounded-retry fallback: Oracle cannot combine a row-limiting clause with FOR UPDATE (ORA-02014), which failed the claim tests on Oracle CI. - Reword the worker docblock/comments to "prefer oldest available" (parallel SKIP LOCKED does not guarantee a strict global order). - Add a regression test that lockTask does not resurrect a finished task. Signed-off-by: Yoan Bozhilov <bygadd@gmail.com> Assisted-by: Claude Code:claude-opus-4-8	2 months ago
Marcel Klehr	66826df860	fix: Address review comments ... Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Marcel Klehr <mklehr@gmx.net>	2 months ago
Yoan Bozhilov	0799454a1f	fix(taskprocessing): claim tasks atomically with SKIP LOCKED + composite index ... Replace the worker retry/ignore-list claim-loop with a single atomic SELECT ... FOR UPDATE SKIP LOCKED claim (SQLite bounded-retry fallback), preserving the no-duplicate guarantee while removing the thundering-herd contention that throttled backlog draining. Add a (status,type,last_updated) index via the table-creating migration + db:add-missing-indices listener. Signed-off-by: Yoan Bozhilov <bygadd@gmail.com> Assisted-by: Claude Code:claude-opus-4-8	2 months ago
Marcel Klehr	041013bb58	fix(TaskProcessing): Check $progress value is in (0,1) in setTaskProgress ... Signed-off-by: Marcel Klehr <mklehr@gmx.net>	2 months ago
Marcel Klehr	573ecd0e81	feat(TaskProcessing): Update completionExpectedAt in Manager#setTaskProgress ... Assisted-by: ClaudeCode:claopus-4-7 Signed-off-by: Marcel Klehr <mklehr@gmx.net>	2 months ago
Julien Veyssier	76709d7efc	feat(task-streaming): address review comments ... Signed-off-by: Julien Veyssier <julien-nc@posteo.net>	2 months ago
Julien Veyssier	3f4eae2d0b	feat(task-streaming): only send notify_push status updates after we actually apply the change in the db ... Signed-off-by: Julien Veyssier <julien-nc@posteo.net>	2 months ago
Julien Veyssier	c7d8369b5f	feat(task-streaming): adjust notify push messages, add sort of a namespace ... Signed-off-by: Julien Veyssier <julien-nc@posteo.net>	2 months ago
Julien Veyssier	4da89e92dd	feat(task-streaming): send a notify_push message whenever a task status changes ... Signed-off-by: Julien Veyssier <julien-nc@posteo.net>	2 months ago
Julien Veyssier	8ee02812ef	feat(task-streaming): rename ISynchronousOptionsProvider to ISynchronousOptionsAwareProvider ... Signed-off-by: Julien Veyssier <julien-nc@posteo.net>	2 months ago
Julien Veyssier	b04de05805	fix(task-streaming): fix psalm issues, run cs:fix, gen openapi specs ... Signed-off-by: Julien Veyssier <julien-nc@posteo.net>	2 months ago
Julien Veyssier	207f347afc	feat(task-streaming): add new provider interface ... Signed-off-by: Julien Veyssier <julien-nc@posteo.net>	2 months ago
Julien Veyssier	ddf914231b	feat(task-streaming): add preferStreaming boolean attribute to taskprocessing tasks. pass it to ISynchronousProgressiveProvider::process ... Signed-off-by: Julien Veyssier <julien-nc@posteo.net>	2 months ago
Julien Veyssier	a6e6d92103	feat(task-streaming): do not update the task in DB when setting intermediate result if notify_push is available ... Signed-off-by: Julien Veyssier <julien-nc@posteo.net>	2 months ago
Julien Veyssier	d65252b8af	fix(task-streaming): make the notify_push message shorter ... Signed-off-by: Julien Veyssier <julien-nc@posteo.net>	2 months ago
Julien Veyssier	e4bea82c86	feat(task-streaming): add an endpoint to set a task intermediate output ... Signed-off-by: Julien Veyssier <julien-nc@posteo.net>	2 months ago
Julien Veyssier	74d078e6e4	fix(task-streaming): and test sending data via notify_push ... Signed-off-by: Julien Veyssier <julien-nc@posteo.net>	2 months ago
Julien Veyssier	7870537d01	feat(task-streaming): allow the Php providers to set intermediate results with a callback in process ... Signed-off-by: Julien Veyssier <julien-nc@posteo.net>	2 months ago
El Mehdi Abenhazou	e8c101fac8	fix(TaskProcessing): restrict allowed_classes in Manager cache deserialization ... The availableTaskTypes cache stores serialized arrays containing ShapeDescriptor objects, ShapeEnumValue objects, and EShapeType enum values. The unserialize() call did not restrict which classes could be instantiated. Restrict deserialization to the three known types: - OCP\TaskProcessing\ShapeDescriptor - OCP\TaskProcessing\ShapeEnumValue - OCP\TaskProcessing\EShapeType This prevents PHP Object Injection if an attacker gains write access to the distributed cache backend. Signed-off-by: El Mehdi Abenhazou <mehdiananas007@gmail.com>	3 months ago
XananasX7	d0cce3da70	fix(TaskProcessing): add allowed_classes to unserialize() in Manager cache ... The availableTaskTypes cache stores serialized arrays containing ShapeDescriptor objects, ShapeEnumValue objects, and EShapeType enum values. The unserialize() call did not restrict which classes could be instantiated. Restrict deserialization to the three known types: - OCP\TaskProcessing\ShapeDescriptor - OCP\TaskProcessing\ShapeEnumValue - OCP\TaskProcessing\EShapeType This prevents PHP Object Injection if an attacker gains write access to the distributed cache backend (e.g., a Redis instance without authentication or with weak ACLs), which is a known real-world attack vector in shared hosting and container environments.	3 months ago
Côme Chilliet	0d90f4272a	chore: Remove types from const properties ... Support was added in PHP 8.3 and we need to support 8.2 Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 months ago
Côme Chilliet	b44f6a2957	fix: Remove static vars in TaskProcessing, TextProcessing, TextToImage ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 months ago
Côme Chilliet	1ab09ec753	chore: Apply new coding standard to all files ... The diff can be checked using: git diff --ignore-all-space --ignore-blank-lines To see only the changes not related to blank lines. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 months ago
Côme Chilliet	9680004b58	chore: Remove almost all uses of deprecated IServerContainer in lib/private ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 months ago
Lukas Schaefer	574243fab3	feat(TaskProcessing): add TextToTextReformatParagraphs task type ... Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>	4 months ago
Ferdinand Thiessen	e0ba4d71b6	chore: add missing `Override` attribute to `OC` ... Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	4 months ago
Oleksander Piskun	f573285040	feat(taskprocessing): Add queue_stats API endpoint for external autoscalers ... Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>	5 months ago
provokateurin	f12cecb684	feat(rector): Enable SafeDeclareStrictTypesRector ... Signed-off-by: provokateurin <kate@provokateurin.de>	6 months ago
Carl Schwan	c96ece0bcb	refactor: Add more typing ... - repairs job - database - redis And remove Helpertest which was unused outside of some tests. Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	7 months ago
Carl Schwan	7b6078875b	refactor: Run rector on lib/private ... Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	7 months ago
Marcel Klehr	c13d95809a	Fix: Run cs:fix	7 months ago
Marcel Klehr	c48a09f27d	fix(TaskProcessing): Refactor TextToImage fallback ... Signed-off-by: Marcel Klehr <mklehr@gmx.net>	7 months ago
Marcel Klehr	25044f82ae	fix(TaskProcessing): Adjust OCR task type to allow for multiple files and pdfs ... Signed-off-by: Marcel Klehr <mklehr@gmx.net>	9 months ago
Julien Veyssier	b4f7fe2cb6	feat(taskprocessing): add a boolean 'includeWatermark' to taskprocessing tasks and pass it to ISynchronousWatermarkingProvider::process ... Signed-off-by: Julien Veyssier <julien-nc@posteo.net>	9 months ago
Marcel Klehr	3ee6999682	fix: Use substr to cut error messages ... This allows for cutting them to longer lengths Signed-off-by: Marcel Klehr <mklehr@gmx.net>	10 months ago
Marcel Klehr	7f15598083	fix: address review comments ... Signed-off-by: Marcel Klehr <mklehr@gmx.net>	10 months ago