nextcloud-server

Commit Graph

Author	SHA1	Message	Date
John Molakvoæ	32c1aebaae	fix(cypress): formatFileSize change revert from files library Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>	2 years ago
John Molakvoæ	e1112c93ec	fix: remove old fileUploadSpec jsunit test Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>	2 years ago
John Molakvoæ	e3bac437c2	chore: remove old favorites view Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>	3 years ago
John Molakvoæ	f060e5a72f	fix(tests): update jsunit tests after dep and files update Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>	3 years ago
julia.kirschenheuter	dc0a95cce0	Adjust breadcrumb navigation structure to the navigation list Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>	3 years ago
John Molakvoæ	0a3ef8b74b	Fixing tests Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>	3 years ago
luz paz	9d26671f05	Fix typos in apps/ subdirectory Found via `codespell -q 3 -S l10n,./apps/files_external/3rdparty -L adn,ba,boxs,keypair,jus,optionel,ressource,tabel ./apps/` Signed-off-by: luz paz <luzpaz@github.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>	3 years ago
Julius Härtl	6ad600ea8a	Fix jsunit tests Signed-off-by: Julius Härtl <jus@bitgrid.net>	3 years ago
Vincent Petry	00066cbeaf	Remove more legacy ids Remove more unused legacy ids from early ownCloud times. This reduces the number of duplicate ids in the DOM. Signed-off-by: Vincent Petry <vincent@nextcloud.com>	4 years ago
Vincent Petry	8be9b04981	Remove legacy #dir element in files list Removed legacy "#dir" input element in the DOM. Apps should use OCA.Files.App.currentFileList or OCA.Sharing.PublicApp.fileList and call getCurrentDirectory() to retrieve the current directory and changeDirectory() to change it. Signed-off-by: Vincent Petry <vincent@nextcloud.com>	4 years ago
Vincent Petry	bb2557c389	Replace files app ids to classes Replaced ids to classes for the following: - #filestable -> .files-filestable - #fileList -> .files-fileList - #controls -> .files-controls - #emptycontent -> .emptyfilelist.emptycontent Signed-off-by: Vincent Petry <vincent@nextcloud.com>	4 years ago
Carl Schwan	c1499519d4	Improve accessibility with more visible focus indication for non vue apps - Add visible-focus effect on each header entry - Show focus outline when using focus-visible (keyboard navigation) - Add polyfy for focus-visible since it's only very recently available on webkit - Change text for link to home button to describe the destination and not the current page - Improve focus effect in app sidebar navigation Signed-off-by: Carl Schwan <carl@carlschwan.eu>	4 years ago
Simon L	66e61be9ca	Revert "Show the child folders in the breadcrumb menu when on a parent entry." Signed-off-by: szaimen <szaimen@e.mail.de>	4 years ago
Robin Appelman	6c04076a85	fix filelist not loading after refresh in firefox Signed-off-by: Robin Appelman <robin@icewind.nl>	4 years ago
Christian Paier	0942aed8db	Show the parent folders in the breadcrumb menu when on a child entry. Previously, clicking on an menu item in the breadcrumb menu removed the parent entries of the path, i.e.: Clicking on the "to" entry in "/path/to/some/folder" changed the breadcrumb menu to show only the "/path/to" entries. With this change the breadcrumb menu changes this behaviour as the full path is still visible (and usable) but with the "to" entry beeing highlighted. Signed-off-by: Christian Paier <hallo+git@cpaier.com>	4 years ago
Louis Chemineau	14e57bf70a	Replace license information to SPDX expression Signed-off-by: Louis Chemineau <louis@chmn.me>	4 years ago
pjft	5c8e7be4a7	Fix bug introduced on drag and drop external files Drag and drop of external (OS filesystem) to subdirectories in the browser would fail on specific cases, mainly when the subdirectory was no longer off the root folder. This seemed to have been an issue introduced with the subdirectory free space calculation [here](`f9536b0809`) and it seems to fail for any subdirectory that doesn't belong to the root folder. Bug reports: - https://help.nextcloud.com/t/drag-drop-into-subfolders/120731 - https://github.com/nextcloud/server/issues/24720 I couldn't find any reference on scenarios or quota management that would suggest when a subdirectory's free space would be different to the parent's free space, other than when on the root folder, where subdirectories can be external mounts. As such, if my understanding is correct (please review), this calculation can - and should - be made by getting the free space from the first subdirectory in the total path, which caters for all subdirectory scenarios. Please advise, happy to help improve this. Co-authored-by: John Molakvoæ <skjnldsv@users.noreply.github.com> Signed-off-by: pjft <pjft@users.noreply.github.com>	4 years ago
Valdnet	99e6849906	Change the values in test Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>	5 years ago
Valdnet	73a616101b	Change the values in the test	5 years ago
John Molakvoæ (skjnldsv)	3e624dc399	Bump js licenses Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	5 years ago
Julius Härtl	f9536b0809	Check for target folder available quota when uploading Signed-off-by: Julius Härtl <jus@bitgrid.net> Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	5 years ago
Christoph Wurst	ae0a496da8	Bump jquery from 2.2.4 to 3.1.0 Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	5 years ago
Azul	43f0d2a3b5	Allow opening files for editing in new tabs In a file list files with a default action have an href that will trigger the action. This way ctrl-click and middle button click open the default action in a new tab. In order to achieve this a new param `openfile` was introduced to the files app. It will make the files app trigger the default action for the file in question. This also allows linking to file content rather than just the details display. Introduce fileList.getDefaultActionUrl() to create a link with that param set. It's overwritten in the trashbin fileList so that anchors continue to have `#` as a href. Fix the link generation for subfolders of public shares: `58a87d0` was the last commit that touched the linkTo function in public.js. It included the params as arguments to the generateUrl function. Turns out this completely ignores the dir parameter now. The inclusion was reverted in other places so revert it here as well. Also change `dir` to `path` in the param as that is respected when following the link. Add Test for the new link url for files with default action. Remove test for multiple selects with ctrl-click as that is not what we are doing anymore. Signed-off-by: Azul <azul@riseup.net>	6 years ago
John Molakvoæ (skjnldsv)	a48359ac02	Adjust unit tests to new OCA.Sidebar Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	6 years ago
Julius Härtl	5e4eda1ae0	Remove deprecated legacy file actions Signed-off-by: Julius Härtl <jus@bitgrid.net>	6 years ago
John Molakvoæ (skjnldsv)	ff164db935	Add link icon for public link too Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	7 years ago
Tomasz Grobelny	701f7902d2	Fix unit tests Signed-off-by: Tomasz Grobelny <tomasz@grobelny.net>	7 years ago
Morris Jobke	a938f0ea9d	Add abort stub in JSUnit Signed-off-by: Morris Jobke <hey@morrisjobke.de>	7 years ago
Tomasz Grobelny	04d326f95f	Fix unit tests Signed-off-by: Tomasz Grobelny <tomasz@grobelny.net>	7 years ago
Morris Jobke	c09560627f	Enhance jsunit tests Signed-off-by: Morris Jobke <hey@morrisjobke.de>	7 years ago
Julius Härtl	c48722c201	Fix file move tests Signed-off-by: Julius Härtl <jus@bitgrid.net>	7 years ago
Tomasz Grobelny	41687ef00f	Fix move related tests Signed-off-by: Tomasz Grobelny <tomasz@grobelny.net>	7 years ago
Jan-Christoph Borchardt	39ff82f707	Use grid view in other file views too Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>	7 years ago
Julius Härtl	c316eb6b97	Tests: Properly compare the file action label Signed-off-by: Julius Härtl <jus@bitgrid.net>	7 years ago
Christoph Wurst	9af69ca2a5	Fix usage of deprecated OC.webroot Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	7 years ago
Michael Weimann	2de34d7778	Improves the tests Signed-off-by: Michael Weimann <mail@michael-weimann.eu>	8 years ago
Michael Weimann	f18fc851c0	Adds a test to check that the sorting isn't stored without an user Signed-off-by: Michael Weimann <mail@michael-weimann.eu>	8 years ago
Jan-Christoph Borchardt	a2ad1b9aa9	Fix ability to open file or folder via keyboard, fix #10008 Before, the file or folder was opened when clicking on the name span, but not when clicking on the link that contains the name; clicking on the link highlighted the file and opened the sidebar, just like clicking on the file size or date. Now clicking on the link opens the file or folder, so the unit tests that tested clicks on the link were changed to test clicking on the file size instead. Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>	8 years ago
John Molakvoæ (skjnldsv)	8d3f58c391	Jsunit fixes 1 Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	8 years ago
John Molakvoæ (skjnldsv)	bd1929a3b1	Fixed tests Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	8 years ago
Abijeet	419d72e0ee	Adds a test case for the loading symbol in deleted files. Signed-off-by: Abijeet <abijeetpatro@gmail.com>	8 years ago
Abijeet	e89f6590e2	Fixed failing test cases for the new actions menu. Signed-off-by: Abijeet <abijeetpatro@gmail.com>	8 years ago
Julius Härtl	951ac518e1	Fix jsunit tests Signed-off-by: Julius Härtl <jus@bitgrid.net>	8 years ago
John Molakvoæ (skjnldsv)	cee5be6ff2	Fixed jsunit Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	8 years ago
Daniel Calviño Sánchez	ad71abca6f	Update comments in tests Menu and home are not always visible; home is always visible, but menu is shown only when needed. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	10e9eeec45	Fix menu visibility The crumb for the menu was shown like any other crumb when calling "_showCrumb", but it was also shown when other crumbs were hidden without taking into account the available width. This caused several related problems, like the breadcrumbs taking too much space when the menu was sometimes shown after the rest of the crumbs were adjusted to the available width, or the menu being shown instead of the last crumb even if there was room for it when the available width was increased. Now the menu is always hidden before starting the resizing of the crumbs to ensure that whether it was previously shown or not does not affect the result. In a similar way, the menu will no longer be shown by "_showCrumb", as it is not a regular crumb that has to be shown simply if there is enough room. The menu is now shown as soon as any other crumb is hidden; this ensures that the menu width will be taken into account in further width checks. As when _updateMenu" is called it no longer needs to take care of showing the menu this fixes the issue revealed when fixing the test setup in the previous commit. Finally, this implicitly fixes the failure in the breadcrumbs tests when run on Firefox, as it was caused by the menu interfering in the calculations of the other crumbs when increasing the width. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	1bcba56d8f	Fix setup to test the breadcrumbs menu The "Shows only items not in the breadcrumb" test was failing when run on Firefox, but not on PhantomJS. This was caused by the differences in the starting width between both browsers and an incorrect setup of the test (the width set for the crumbs was overriden when the breadcrumbs were rendered again, and the breadcrumb was resized to 300 from an indeterminate initial width). Now the crumbs are rendered and then its width, padding and margin are set to a known value. Then it is resized to 1000px, which ensures that there will be enough room for all the crumbs and thus the menu will be hidden, and finally it is resized to 300, which causes the middle crumb to be hidden and the menu to be shown. Note, however, that the test now always fails, no matter if it is run on PhantomJS or on Firefox; if the menu crumb is hidden when "_updateMenu" is called it will show it, but it will also wrongly try to add the menu itself to the menu. As the "crumb-id" of the menu crumb is "-1" this causes the last regular crumb to be added to the menu. This will be fixed with other related issues in the next commit. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	92345f2c38	Take padding and margins of crumbs into account When calculating the total width of the crumbs only its padding was taken into account; now the margin is too. In a similar way, before showing a crumb only its width was taken into account; now its padding and margin are taken into account too. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	29c924f74b	Use hard-coded values for paddings and margins This ensures that the resize tests do not depend on the values set in the CSS files. Note that this change causes a test to fail with Firefox, but not with PhantomJS. This is due to a difference in the starting width used by Firefox and by PhantomJS, and it will be fixed in a following commit. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	acdf091f84	Compress siblings before calculating the available width for crumbs When the parent element of the breadcrumbs was resized to a larger width and the siblings of the breadcrumbs expanded to fill all the available width some crumbs could be hidden even if there was enough room for them. The reason was that the width of the siblings being used to calculate the available width for the breadcrumbs was the expanded width of the siblings. Now as many crumbs as possible (that is, fitting in the parent, no matter the siblings) are first shown so the expanding siblings are compressed before calculating the available width. Due to the lack of support for flexboxes in PhantomJS the related unit test is skipped; it has to be run in other browser, like Firefox. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago

1 2 3 4 5 ...

274 Commits (8904bf645b30fbdfdcb00a2ea607d752ee69d865)