59 Commits (a2572ffec79f7bd2fa7aa29ed48d9b011836759d)

Author	SHA1	Message	Date
Joas Schilling	0235a79b4e	Initialise the printcss array	10 years ago
Lukas Reschke	29ce56ed07	Check if admin user ... We should not add the JS for not admin users.	10 years ago
Lukas Reschke	abc675d87e	Move update notification code into app ... Moves the update notification code in a single app. This is required since we want to use SSO for the new updater and for this have some code running in ownCloud as well (and we don't want that in core neccessarily). This app can provide that in the future, right now it's only the update notification itself. Will continue working on the SSO right away but wanted to keep the PR small. Furthermore also makes some more code unit-testable...	10 years ago
Morris Jobke	1601d9235a	Make enable_avatars setting more robust ... * handles the setting in the same way everywhere * fixes #21949	10 years ago
Morris Jobke	2ecc202843	Fix setup page ... * fixes #21897	10 years ago
Hendrik Leppelsack	99b9ec41c1	support print stylesheets	10 years ago
Thomas Müller	682821c71e	Happy new year!	10 years ago
Morris Jobke	fa97e3a5a3	OC_TemplateLayout -> OC\TemplateLayout	10 years ago
Morris Jobke	ed98cdf532	Use OCP\Util::getVersion instead of the internal private implementation	10 years ago
Roeland Jago Douma	9fe3d2f1f8	OC_Helper::linkToRoute is deprecated ... Replaced all calls to OC_Helper::linkToRoute with OC::$server->getURLGenerator()->linkToRoute	10 years ago
Roeland Jago Douma	19eeb23b91	OC_Helper::linkTo is deprecated ... Replaced with suggested (and calling body of)	10 years ago
Roeland Jago Douma	db95c8d512	Do not try to get the avatar if there is no user	10 years ago
Lukas Reschke	4971015544	Add code integrity check ... This PR implements the base foundation of the code signing and integrity check. In this PR implemented is the signing and verification logic, as well as commands to sign single apps or the core repository. Furthermore, there is a basic implementation to display problems with the code integrity on the update screen. Code signing basically happens the following way: - There is a ownCloud Root Certificate authority stored `resources/codesigning/root.crt` (in this PR I also ship the private key which we obviously need to change before a release 😉). This certificate is not intended to be used for signing directly and only is used to sign new certificates. - Using the `integrity:sign-core` and `integrity:sign-app` commands developers can sign either the core release or a single app. The core release needs to be signed with a certificate that has a CN of `core`, apps need to be signed with a certificate that either has a CN of `core` (shipped apps!) or the AppID. - The command generates a signature.json file of the following format: ```json { "hashes": { "/filename.php": "2401fed2eea6f2c1027c482a633e8e25cd46701f811e2d2c10dc213fd95fa60e350bccbbebdccc73a042b1a2799f673fbabadc783284cc288e4f1a1eacb74e3d", "/lib/base.php": "55548cc16b457cd74241990cc9d3b72b6335f2e5f45eee95171da024087d114fcbc2effc3d5818a6d5d55f2ae960ab39fd0414d0c542b72a3b9e08eb21206dd9" }, "certificate": "-----BEGIN CERTIFICATE-----MIIBvTCCASagAwIBAgIUPvawyqJwCwYazcv7iz16TWxfeUMwDQYJKoZIhvcNAQEF\nBQAwIzEhMB8GA1UECgwYb3duQ2xvdWQgQ29kZSBTaWduaW5nIENBMB4XDTE1MTAx\nNDEzMTcxMFoXDTE2MTAxNDEzMTcxMFowEzERMA8GA1UEAwwIY29udGFjdHMwgZ8w\nDQYJKoZIhvcNAQEBBQADgY0AMIGJAoGBANoQesGdCW0L2L+a2xITYipixkScrIpB\nkX5Snu3fs45MscDb61xByjBSlFgR4QI6McoCipPw4SUr28EaExVvgPSvqUjYLGps\nfiv0Cvgquzbx/X3mUcdk9LcFo1uWGtrTfkuXSKX41PnJGTr6RQWGIBd1V52q1qbC\nJKkfzyeMeuQfAgMBAAEwDQYJKoZIhvcNAQEFBQADgYEAvF/KIhRMQ3tYTmgHWsiM\nwDMgIDb7iaHF0fS+/Nvo4PzoTO/trev6tMyjLbJ7hgdCpz/1sNzE11Cibf6V6dsz\njCE9invP368Xv0bTRObRqeSNsGogGl5ceAvR0c9BG+NRIKHcly3At3gLkS2791bC\niG+UxI/MNcWV0uJg9S63LF8=\n-----END CERTIFICATE-----", "signature": "U29tZVNpZ25lZERhdGFFeGFtcGxl" } ``` `hashes` is an array of all files in the folder with their corresponding SHA512 hashes (this is actually quite cheap to calculate), the `certificate` is the certificate used for signing. It has to be issued by the ownCloud Root Authority and it's CN needs to be permitted to perform the required action. The `signature` is then a signature of the `hashes` which can be verified using the `certificate`. Steps to do in other PRs, this is already a quite huge one: - Add nag screen in case the code check fails to ensure that administrators are aware of this. - Add code verification also to OCC upgrade and unify display code more. - Add enforced code verification to apps shipped from the appstore with a level of "official" - Add enfocrced code verification to apps shipped from the appstore that were already signed in a previous release - Add some developer documentation on how devs can request their own certificate - Check when installing ownCloud - Add support for CRLs to allow revoking certificates **Note:** The upgrade checks are only run when the instance has a defined release channel of `stable` (defined in `version.php`). If you want to test this, you need to change the channel thus and then generate the core signature: ``` ➜ master git:(add-integrity-checker) ✗ ./occ integrity:sign-core --privateKey=resources/codesigning/core.key --certificate=resources/codesigning/core.crt Successfully signed "core" ``` Then increase the version and you should see something like the following:  As you can see a failed code check will not prevent the further update. It will instead just be a notice to the admin. In a next step we will add some nag screen. For packaging stable releases this requires the following additional steps as a last action before zipping: 1. Run `./occ integrity:sign-core` once 2. Run `./occ integrity:sign-app` _for each_ app. However, this can be simply automated using a simple foreach on the apps folder.	10 years ago
Lukas Reschke	f3e9106864	Don't trust update server ... In case the update server may deliver malicious content this would allow an adversary to inject arbitrary HTML into the response. So very bad stuff. While signing the response would be better and something we can also do in the future (considering the code signing work), this is already a good first start.	10 years ago
Thomas Müller	4cb5970947	Always pass in ILogger	10 years ago
Thomas Müller	766b69a0c8	User upstream class SeparatorFilter	10 years ago
Thomas Müller	d40867d855	Suer JSqueezeFilter instead of JSMinFilter	10 years ago
Thomas Müller	2ea2ec0004	Show 'Apps' in the browser title when app management is open	10 years ago
Morris Jobke	f63915d0c8	update license headers and authors	11 years ago
Clark Tomlinson	62286f00a1	fixing setting page titles	11 years ago
Morris Jobke	cd516eedcd	Use OC.Notification for update notifications ... * instead of a static rendering inside PHP use the JS OC.Notification.showTemporary to hide the notification after 7 seconds automatically * fixes #14811	11 years ago
Lukas Reschke	0816cf9142	Add experimental applications switch ... Allows administrators to disable or enabled experimental applications as well as show the trust level.	11 years ago
Jenkins for ownCloud	b585d87d9d	Update license headers	11 years ago
Adam Williamson	fa1be7d296	fall back to absolute path for pipelined assets (#14940) ... If the asset is, for example, in an apps directory that is outside the $SERVERROOT, we won't be able to get a relative path. We shouldn't just fail hard in this case. Fall back to using the absolute path instead (as we used to).	11 years ago
Joas Schilling	716ba49a82	Log errors and create 404 in network list when a css or js is missing	11 years ago
Morris Jobke	06aef4e8b1	Revert "Updating license headers" ... This reverts commit 6a1a4880f0.	11 years ago
Thomas Müller	bbf7f56f94	3rd-party apps are disabled on upgrade - refs #14026	11 years ago
Jenkins for ownCloud	6a1a4880f0	Updating license headers	11 years ago
Lukas Reschke	886bda5f81	Refactor OC_Request into TrustedDomainHelper and IRequest ... This changeset removes the static class `OC_Request` and moves the functions either into `IRequest` which is accessible via `\OC::$server::->getRequest()` or into a separated `TrustedDomainHelper` class for some helper methods which should not be publicly exposed. This changes only internal methods and nothing on the public API. Some public functions in `util.php` have been deprecated though in favour of the new non-static functions. Unfortunately some part of this code uses things like `__DIR__` and thus is not completely unit-testable. Where tests where possible they ahve been added though. Fixes https://github.com/owncloud/core/issues/13976 which was requested in https://github.com/owncloud/core/pull/13973#issuecomment-73492969	11 years ago
Thomas Müller	24daee836a	include core version into js/css version tag - fixes #13702	11 years ago
Adam Williamson	bb79aac78a	allow css/js asset directory to be relocated (#13053) ... This allows the directory where CSS/JS asset collections are written to be changed, in case SERVERROOT is not writeable. Note it does *not* allow the expected URL to be changed: whatever directory is used, the server must be configured to serve it at WEBROOT/assets. It may be possible to add another config parameter to allow the admin to specify a custom asset URL, but I thought I'd keep the first implementation simple.	11 years ago
Robin McCorkell	2c44bc1768	Fix JS asset generation ... At some point SeparatorFilter should be included upstream (kriswallsmith/assetic), then lib/private/assetic/separatorfilter.php can be removed and the `use` in lib/private/templatelayout.php rewritten. SeparatorFilter inserts a separator between assets, preventing issues when files are incorrectly terminated. For JS this is a semicolon.	11 years ago
Victor Dubiniuk	c9fd3c9d29	Inject config	11 years ago
Victor Dubiniuk	303fce44f4	Use httphelper and cache response even when it empty	11 years ago
Morris Jobke	952abdc51a	Drop form_factor that is appended to JS, CSS and template filenames	11 years ago
kondou	729dffed5e	Load avatar in header via PHP ... * fix #7484 * use UID, css, and div instead of span	11 years ago
Clark Tomlinson	ca5abe5744	Setting moment locale based on user selection	11 years ago
Lukas Reschke	7b94c7f9c1	Refer to relative path instead of absolute path ... There is no need to refer to the absolute path here if we can use the relative one. Conflicts: lib/private/templatelayout.php	11 years ago
Thomas Müller	6af0e76a03	remove legacy class OC_Updater	11 years ago
Thomas Müller	93b0f1a3bf	adding cssmin and jssmin(minify) ... adding argument deleteSelf to rmdirr() - if false the directory itself will not be deleted only it's content adding repair step to clean the asset cache after upgrade + coding style adjustments	11 years ago
Thomas Müller	a04159090f	include the apps' versions hash to invalidate the cached assets	11 years ago
Lukas Reschke	6ccda2ae98	Add app version to JS and CSS ... This leads to the regeneration of the hash in case a single application is updated. Fixes https://github.com/owncloud/core/issues/11374	11 years ago
Victor Dubiniuk	b6087ea79b	Add CssImportFilter. More elegant fix for documents#348	11 years ago
Remco Brenninkmeijer	f930b356e6	Error needs to push body-id for new guest layout	11 years ago
Morris Jobke	c6eab9aaba	fix error message template	11 years ago
Lukas Reschke	7d2c521b46	Step one, open guest layout for different styles. ... Conflicts: core/templates/layout.guest.php Step one, open guest layout for different styles.	11 years ago
Robin Appelman	3de69ff81b	Don't register the call when rendering error pages	12 years ago
Vincent Petry	04f73275ba	Now settings CSS class with appid in content DIV	12 years ago
Robin McCorkell	87b548ed91	Fix all PHPDoc types and variable names, in /lib	12 years ago
Lukas Reschke	e88731a477	Some more PHPDoc fixes	12 years ago