249 Commits (a582e624ef74ddb91ddeb336575e7fed562d423c)

Author	SHA1	Message	Date
Marcel Klehr	a582e624ef	fix(SetupChecks): Link to task processing worker docs ... Signed-off-by: Marcel Klehr <mklehr@gmx.net>	1 month ago
rakekniven	a5525df7eb	fix(l10n): Fix plural ... Reported at Transifex Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>	2 months ago
Ferdinand Thiessen	64cfcaab7e	fix(db): add support for MariaDB 12.3 LTS and increase min. to 10.11 ... 10.6 will be EOL when Nextcloud 35 is released, similar to 10.3 its still somewhat supported for enterprise Ubuntu 22.04. So as we dropped 20.04 support we can increase that exception to 10.6. Now MariaDB is supported with active LTS version 10.11 to 12.3 (new LTS). Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	2 months ago
Ferdinand Thiessen	2251dbea2b	chore: bump MySQL to min 8.4 and support 9.7 ... - Version 8.0 is out-of-support. - Version 8.4 is now the oldest LTS. - New LTS is 9.7 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	2 months ago
provokateurin	a7da9cd596	chore(PHP): Drop 8.2 for Nextcloud 35 ... Signed-off-by: provokateurin <kate@provokateurin.de>	2 months ago
Côme Chilliet	1ab09ec753	chore: Apply new coding standard to all files ... The diff can be checked using: git diff --ignore-all-space --ignore-blank-lines To see only the changes not related to blank lines. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 months ago
Micke Nordin	1bad4fe238	fix: Make sodium optional ... This commit switches the default signature algorithm to ecdsa-p256-sha256 instead of Ed25519. This allows us to make sodium optional again, and we only pull it in to use it for verifying incomming signatures. If sodium is not installed, we throw on Ed25519 signatures instead. At least it is easy for most people to make their Nextcloud install fully RFC compliant by installing sodium. I also renamed all the Ed25519 function names to be more precis, using Jwks for the JSON Web Keys, and RFC9421 for the http-signature code, where it is needed to distinguish from draft-cavage signatures. Signed-off-by: Micke Nordin <kano@sunet.se>	3 months ago
Micke Nordin	ea9bbe64c1	chore: require ext-sodium ... Promote ext-sodium from recommended to required so RFC 9421 Ed25519 signing/verifying can rely on libsodium unconditionally. Add the matching openssl + sodium psalm stubs. Signed-off-by: Micke Nordin <kano@sunet.se>	3 months ago
Benjamin Gaussorgues	9e36754429	fix(snowflake): fix wrong documentation about serverId ... Maximum value of a server ID is 511 (9 bits) and not 1023. Also adjust SetupCheck Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>	3 months ago
rakekniven	329279a954	chore(l10n): Plural needed to support multiplural languages ... Reported at Transifex Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>	4 months ago
Marcel Klehr	1adf75499a	fix: Fix psalm issues ... Signed-off-by: Marcel Klehr <mklehr@gmx.net>	4 months ago
Marcel Klehr	cbaf5fa99f	fix(TaskProcessingWorker): Adjust config key name ... Signed-off-by: Marcel Klehr <mklehr@gmx.net>	4 months ago
Ferdinand Thiessen	d8e8703796	chore: add missing `Override` attribute to app code ... Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	4 months ago
Marcel Klehr	beef1a62fe	fix(TaskProcessingWorkerIsRunning): Different message if the worker has never run ... Signed-off-by: Marcel Klehr <mklehr@gmx.net>	4 months ago
Marcel Klehr	554882534c	fix: Address review comment ... Co-authored-by: Julien Veyssier <julien-nc@posteo.net> Signed-off-by: Marcel Klehr <mklehr@gmx.net>	4 months ago
Marcel Klehr	99fc7b2c78	fix(TaskProcessing): Make setup checks more sensitive ... Signed-off-by: Marcel Klehr <mklehr@gmx.net>	4 months ago
Marcel Klehr	3802c0d24a	feat(TaskProcessing): Add setup check for task processing worker status ... Signed-off-by: Marcel Klehr <mklehr@gmx.net>	4 months ago
Josh	64782674d5	fix(SetupChecks): maintenance window length is 4h (not 6h) ... Signed-off-by: Josh <josh.t.richards@gmail.com>	5 months ago
Côme Chilliet	26cec2d117	feat: Add info level result if 2FA is not enforced ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	7 months ago
Côme Chilliet	8475bed525	fix(settings): Only consider primary providers for 2FA setup check ... In practice this filters out backup codes. Also fixed the english formulation and the copyright year. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	7 months ago
Côme Chilliet	1f5e6cbbb4	feat: Add SetupCheck to warn about missing second factor provider ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	7 months ago
Joas Schilling	39e94ef927	fix(oracle): Add a warning for Oracle 11 ... Signed-off-by: Joas Schilling <coding@schilljs.com>	9 months ago
Carl Schwan	4d47fdaa85	chore: Run rector with new rules for fetch ... Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	9 months ago
rakekniven	748a91ccab	chore(i18n): Improved grammar ... Reported at Transifex Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>	9 months ago
Benjamin Gaussorgues	1f74ed9239	feat(config): add serverid configuration and use it for Snowflakes ... Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>	10 months ago
provokateurin	a529cdf080	feat: Update supportes PostgreSQL versions ... Signed-off-by: provokateurin <kate@provokateurin.de>	10 months ago
Benjamin Gaussorgues	c9b055a0d0	feat(database): introduce Snowflake IDs generator ... Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>	10 months ago
Git'Fellow	3f976c2548	fix(setupCheck): Fix checking database type ... Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>	10 months ago
Marcel Klehr	76eba41d77	fix: Fix logic error to make tests pass ... Signed-off-by: Marcel Klehr <mklehr@gmx.net>	10 months ago
Marcel Klehr	e7ac6ff71b	fix: Apply suggestion from @kyteinski ... Signed-off-by: Marcel Klehr <mklehr@gmx.net>	10 months ago
Marcel Klehr	5c5c9384b1	fix: Apply suggestion from @julien-nc ... Co-authored-by: Julien Veyssier <julien-nc@posteo.net> Signed-off-by: Marcel Klehr <mklehr@gmx.net>	10 months ago
Marcel Klehr	f7a89fee24	fix: Apply suggestion from @julien-nc ... Co-authored-by: Julien Veyssier <julien-nc@posteo.net> Signed-off-by: Marcel Klehr <mklehr@gmx.net>	10 months ago
Marcel Klehr	858118274d	fix: Apply suggestion from @julien-nc ... Co-authored-by: Julien Veyssier <julien-nc@posteo.net> Signed-off-by: Marcel Klehr <mklehr@gmx.net>	10 months ago
Marcel Klehr	2286b9f57d	fix: Apply suggestion from @julien-nc ... Co-authored-by: Julien Veyssier <julien-nc@posteo.net> Signed-off-by: Marcel Klehr <mklehr@gmx.net>	10 months ago
Marcel Klehr	1ba5f7d53a	fix(settings): Remove copypasta ... Signed-off-by: Marcel Klehr <mklehr@gmx.net>	10 months ago
Marcel Klehr	33922faf4a	fix: Change messages to use days instead of hours ... Signed-off-by: Marcel Klehr <mklehr@gmx.net>	10 months ago
Marcel Klehr	f296f9055c	fix: Run cs:fix ... Signed-off-by: Marcel Klehr <mklehr@gmx.net>	10 months ago
Marcel Klehr	6c9af3f8ee	fix(settings): Introduce TaskProcessingSuccessRate setup check ... Signed-off-by: Marcel Klehr <mklehr@gmx.net>	10 months ago
Marcel Klehr	5a48887a2b	fix(settings): Improve TaskProcessingPickupSpeed setup check ... Signed-off-by: Marcel Klehr <mklehr@gmx.net>	10 months ago
Carl Schwan	9095a36b94	refactor(dbal): Port away from getDatabasePlatform() instanceof pattern ... Use getDatabaseProvider instead. Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	10 months ago
Joas Schilling	122cd68d56	fix(PHP): Drop PHP 8.1 for Nextcloud 33 ... Signed-off-by: Joas Schilling <coding@schilljs.com>	11 months ago
Côme Chilliet	1c4276eea2	fix(setupchecks): Remove startpage from connectivity check and avoid redirection ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	11 months ago
Côme Chilliet	cc3851f73c	fix(setupchecks): Use a lighter request to test connectivity ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	11 months ago
Josh	34f1d52cf6	chore: Remove 'json' module from PHP modules check ... Removed 'json' module from the list of required PHP modules. It's built-in and not possible to disable at compile time since PHP 8.0.0. Refs: - https://www.php.net/manual/en/json.installation.php - https://wiki.php.net/rfc/always_enable_json - https://www.php.net/ChangeLog-8.php#8.0.0 Signed-off-by: Josh <josh.t.richards@gmail.com>	11 months ago
Enjeck C	eb0ddffaaa	fix: Make some strings in CodeIntegrity.php translatable ... Signed-off-by: Enjeck C <patrathewhiz@gmail.com>	1 year ago
Josh	6b65031a08	feat(settings): add support for MariaDB 11.8 in setup checks ... Signed-off-by: Josh <josh.t.richards@gmail.com>	1 year ago
Ferdinand Thiessen	5981b7eb51	chore: apply new CSFixer rules ... Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de> # Conflicts: # apps/settings/lib/SetupChecks/PhpOpcacheSetup.php	1 year ago
Ferdinand Thiessen	b1282f75fa	fix(settings): use correct scope for translations ... Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	1 year ago
MichaIng	0d10c4fb33	feat(settings): simplify OPcache checks ... For the overall OPcache size check, we currently compare used memory with free memory. However, `opcache.memory_consumption` is split into `used_memory`, `free_memory` and `wasted_memory`. When cached files change on disk, old entries are not replaced or removed, but remain as wasted memory, until the cache is actually full, and if their percentage is above `opcache.max_wasted_percentage`, which is 5% by default. When this happens, the engine is restarted, resetting the cache completely, like a `opcache_reset()` call. As long as we do not consider wasted cache, recommendations based on free memory can be false. To solve this, we could count wasted memory as free memory, if it is above `opcache.max_wasted_percentage`, as the engine will be restarted as soon as needed, freeing up this wasted space. On the other hand, wasted memory below the threshold permanently blocks the OPcache, which supports counting it as used memory. Depending on the situation, instead of raising OPcache size, it could be also advised to reduce `opcache.max_wasted_percentage`. But too frequent cache resets break its purpose as well. In my opinion, the matter is too complex to consider wasted cache correctly, and do precise recommendations, but we should focus on reducing false positives instead. What we know for sure is: if the cache is full (`$status['cache_full'] === true`), and the limit for cached keys has not been reached, the OPcache was too small to maintain free space, with wasted memory below the configured threshold, where it consumes memory permanently. Recommending to raise the OPcache size in this case, is hence as accurate as it gets. Even if 5% wasted cache could be freed, 95% used memory is still above the previous threshold for the setup check warning. And if `opcache.max_wasted_percentage` is above 5%, then the admin must have decided to change the default, deciding that system memory consumption has lower priority than preventing OPcache engine restarts. `cache_full` can be true as well if the limit for cached keys has been reached, hence we need to merge both checks. In this case `num_cached_keys` equals `max_cached_keys` exactly, hence it is easy to differentiale whether `opcache.max_accelerated_files` or `opcache.memory_consumption` needs to be raised to address the `cache_full` state. In practice, this change relaxes the checks: the respective limit needs to be reached 100% instead of 90%, to trigger a warning, eliminating also false alarms if a large share of the cache is consumed by wasted memory, which would be automatically freed once cache is 100% full. Additionally, the recommendation for raising `opcache.max_accelerated_files` now says "a value higher than `max_cached_keys`", instead of "higher than `opcache.max_accelerated_files`". The actual limit, reflected by `max_cached_keys` from `opcache_get_status()`, [is a next higher value from a set of prime numbers](https://www.php.net/manual/en/opcache.configuration.php#ini.opcache.max-accelerated-files). E.g. if `opcache.max_accelerated_files` is set to 10,000 (PHP default), the effective limit is 16,229 OPcache keys. Recommending "higher than 10000" could hence lead to a settings change without effect. For an effective change, the new value needs to be "higher than 16229" instead, which is what the setup check will show in this situation, with this change applied. Signed-off-by: MichaIng <micha@dietpi.com>	1 year ago
invario	2b58f74cc8	Fix: Remove X-XSS-Protection use, check and recommendation ... Co-authored-by: John Molakvoæ <skjnldsv@users.noreply.github.com> Signed-off-by: invario <67800603+invario@users.noreply.github.com>	1 year ago