137 Commits (a94de5cb5a0a0e341dd3eb7130a41f95c71a6abc)

Author	SHA1	Message	Date
Christopher Ng	57c66bf7cb	Use Image class from public API ... Signed-off-by: Christopher Ng <chrng8@gmail.com>	4 years ago
Carl Schwan	a5a4e0df1c	Fix crop condition ... Make sure that when fetching the image from the cache we don't accidentally fetch the cropped image just because it also start with 256-256 Signed-off-by: Carl Schwan <carl@carlschwan.eu>	4 years ago
Julius Härtl	3742b7392d	Add explicit return if getSmallImagePreview fails ... Signed-off-by: Julius Härtl <jus@bitgrid.net>	4 years ago
Carl Schwan	05bf8b4445	Fix cropped image generated when not asked ... The $crop parameter was not propagated to the imaginary pipeline and instead it used the smartcrop algorithm always Signed-off-by: Carl Schwan <carl@carlschwan.eu>	4 years ago
Richard Steinmetz	982c846b11	Fix preview generator trying to recreate an existing folder ... Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>	4 years ago
Alexander F	00505c9a51	Set loglevel for IMagick Thumbnail error to info ... Issue #32263 Signed-off-by: Alexander Fleischer <Alexander.Fleischer@tu-ilmenau.de>	4 years ago
Côme Chilliet	069477e608	Migrate more classes of lib/private to LoggerInterface ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	4 years ago
John Molakvoæ	3d1f22f6d8	Generate small preview straight away if Imaginary is enabled ... Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>	4 years ago
Carl Schwan	b5c9189cfa	Fix imaginary with rotated exif images ... Now do the operation in two steps: 1. Rotate the image according the exif data 2. Do the actual operation This should only have a performance impact on image with exif rotation data to do the rotation. For all the other images the autorotate steps should be almost instant. Signed-off-by: Carl Schwan <carl@carlschwan.eu>	4 years ago
Vincent Petry	9b6a1cc8ae	Send images to imaginary docker to generate previews ... Signed-off-by: Carl Schwan <carl@carlschwan.eu> Co-Authored-by: Vincent Petry <vincent@nextcloud.com>	4 years ago
Côme Chilliet	13c11208d4	Ignore errors when searching for bundled preview ... When an odt file is xml and not zip, it would throw a ValueError. It will now just ignore this file and return null for the preview. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	4 years ago
Côme Chilliet	0daec4b27e	Fix tmp file cleaning for bundled previews ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	4 years ago
Côme Chilliet	d43dbfa0f2	Fix typing in OC\Preview\Movie ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	4 years ago
Côme Chilliet	ebe731f014	Fix typing in OC\Preview ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	4 years ago
UmbrellaCodr	a0d7e27789	reduce 'Movie preview generation failed Output' log errors ... for movies under 5 seconds Signed-off-by: UmbrellaCodr <umbrella@biohazard.cc> Update lib/private/Preview/Movie.php Co-authored-by: Simon L. <szaimen@e.mail.de>	4 years ago
Carl Schwan	6312c0df69	Check style update ... Signed-off-by: Carl Schwan <carl@carlschwan.eu>	4 years ago
Côme Chilliet	3631789651	Fix resource usages in OC_Image ... This makes sure using resource or GdImage (PHP>=8) behaves the same. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	4 years ago
J0WI	047cab8dd2	Use findBinaryPath for previews ... Signed-off-by: J0WI <J0WI@users.noreply.github.com>	4 years ago
Vincent Petry	24e0255378	Fall back to full file for video previews ... If the first 5 MB are not enough to grab a useful frame for the thumbnail preview, fall back to reading the full file. Signed-off-by: Vincent Petry <vincent@nextcloud.com>	5 years ago
Julius Härtl	0670118470	Use storage filter when fetching previews to cleanup ... Signed-off-by: Julius Härtl <jus@bitgrid.net>	5 years ago
John Molakvoæ (skjnldsv)	40c10ab145	Properly log errors in Movie previews generation ... Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	5 years ago
John Molakvoæ (skjnldsv)	215aef3cbd	Update php licenses ... Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	5 years ago
J0WI	74a7c2eefc	Use correct getSystemValue type ... Signed-off-by: J0WI <J0WI@users.noreply.github.com>	5 years ago
dependabot-preview[bot]	eb502c02ff	Bump nextcloud/coding-standard from 0.3.0 to 0.5.0 ... Bumps [nextcloud/coding-standard](https://github.com/nextcloud/coding-standard) from 0.3.0 to 0.5.0. - [Release notes](https://github.com/nextcloud/coding-standard/releases) - [Changelog](https://github.com/nextcloud/coding-standard/blob/master/CHANGELOG.md) - [Commits](https://github.com/nextcloud/coding-standard/compare/v0.3.0...v0.5.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	5 years ago
Roeland Jago Douma	4d7c4b3d2f	Markdown: remove redundant int cast ... For #25641 Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	5 years ago
Roeland Jago Douma	cc554890c1	Fix WebP availability check ... Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	5 years ago
John Molakvoæ (skjnldsv)	d47b84be67	Add SGI and TGA preview support ... Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	5 years ago
Morris Jobke	01f013661a	Fix typo in comment ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	5 years ago
Julius Härtl	aed1fde6fd	Enhance markdown file preview rendering ... Signed-off-by: Julius Härtl <jus@bitgrid.net>	5 years ago
Roeland Jago Douma	6d4afca7ac	Add support for webp ... Including handling in OC_Image But also a preview provider Of course only works if your php actually supports webp Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	5 years ago
Morris Jobke	24d436cb60	Remove unneeded casts that were found by Psalm ... In preparation of the update of Psalm from 4.2.1 to 4.3.1+ (see https://github.com/nextcloud/server/pull/24521) Signed-off-by: Morris Jobke <hey@morrisjobke.de>	5 years ago
Christoph Wurst	9ce3ea3368	Update license headers ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	5 years ago
Christoph Wurst	d9015a8c94	Format code to a single space around binary operators ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
J0WI	68ce17e59b	Unify links to php.net ... Update all links to https://www.php.net/ Signed-off-by: J0WI <J0WI@users.noreply.github.com>	6 years ago
Christoph Wurst	2a054e6c04	Update the license headers for Nextcloud 20 ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Scott Dutton	b12a390220	Always try and show pre rendered preview ... Currently if the following situation happens Server generates preview Server has command removed which allows a preview to be shown Client asks for preview, gets a 404 error when preview exists (Mime checked before preview) This happens more often with documents, or video as the commands are not native PHP, they require a binary on the server. After the fix the following would happen Server generates preview Server has command removed which allows a preview to be shown Client asks for preview, gets preview which has been generated (Mime checked after preview) This would also allow offline generation (for example a docker image containing the extra binaries), allowing a reduction in attack surface of the instance serving the preview data. Signed-off-by: Scott Dutton <scott@exussum.co.uk>	6 years ago
Morris Jobke	4d0c3fa4a8	Check previews in multibucket fallback folder as the last step and not as first step ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	6 years ago
Morris Jobke	45428e4948	Add config option to enable multibucket preview distribution ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	6 years ago
Morris Jobke	159f28cd52	Mount the old previews in a separate folder for the multi bucket setup and check in them before using the actual locations ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	6 years ago
Morris Jobke	438ac23e2a	Distribute preview folders in appdata in multibucket setup to multiple buckets ... * introduces a new IRootMountProvider to register mount points inside the root storage * adds a AppdataPreviewObjectStoreStorage to handle the split between preview folders and bucket number Ref #22033 Signed-off-by: Morris Jobke <hey@morrisjobke.de>	6 years ago
Morris Jobke	d8734b3b93	Add occ preview:migrate to migrate previews from the old flat structure to a subfolder structure ... * `php occ preview:repair` - a preview migration tool that moves existing previews into the new location introduced with #19214 * moves `appdata_INSTANCEID/previews/FILEID` to `appdata_INSTANCEID/previews/0/5/8/4/c/e/5/FILEID` * migration tool can be stopped during migration via `CTRL+C` - it then finishes the current folder (with the previews of one file) and stops gracefully * if a PHP memory limit is set in the `php.ini` then it will stop automatically once it has less than 25 MiB memory left (this is to avoid hard crashes in the middle of a migration) * the tool can be used during operation - possible drawbacks: * there is the chance of a race condition that a new preview is generated in the moment the folder is already migrated away - so the old folder with the newly cached preview is deleted and one cached preview needs to be re-generated * there is the chance of a race condition during access of a preview while it is migrated to the other folder - then no preview can be shown and results in a 404 (as of now this is an accepted risk) Signed-off-by: Morris Jobke <hey@morrisjobke.de>	6 years ago
Morris Jobke	f510da139f	Use class that actually has the destroy() method in preview generator ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	6 years ago
Elijah Martin-Merrill	56ed563b0c	fix memory leak caused by not destroying image in Preview/Generate.php ... Signed-off-by: Elijah Martin-Merrill <elijah@nyp-itsours.com>	6 years ago
Christoph Wurst	cb057829f7	Update license headers for 19 ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Roeland Jago Douma	6c603e8e7d	Move to subfolders for preview files ... Else the number of files can grow very large very quickly in the preview folder. Esp on large systems. This generates the md5 of the fileid. And then creates folders of the first 7 charts. In that folder is then a folder with the fileid. And inside there are the previews. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	6 years ago
Christoph Wurst	caff1023ea	Format control structures, classes, methods and function ... To continue this formatting madness, here's a tiny patch that adds unified formatting for control structures like if and loops as well as classes, their methods and anonymous functions. This basically forces the constructs to start on the same line. This is not exactly what PSR2 wants, but I think we can have a few exceptions with "our" style. The starting of braces on the same line is pracrically standard for our code. This also removes and empty lines from method/function bodies at the beginning and end. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Robin Appelman	8f9bac26f8	fix preview generation tests ... Signed-off-by: Robin Appelman <robin@icewind.nl>	6 years ago
Christoph Wurst	14c996d982	Use elseif instead of else if ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Robin Appelman	7d386872e5	optimize batch generation of previews ... by allowing the generation of multiple previews at once we save on having to find, open and decode the max-preview for every preview of the same file the main use case for this is the preview generator app (pr for that comming next) in my local testing this saves about 25% of time when using the preview generator app Signed-off-by: Robin Appelman <robin@icewind.nl>	6 years ago
Robin Appelman	5cd12cd7c3	allow generating multiple preview sizes for a single file at once ... this saves having to do some of the overhead multiple times Signed-off-by: Robin Appelman <robin@icewind.nl>	6 years ago