133 Commits (b00a9a6eaeeafce11e0141199f37d8a105050cce)

Author	SHA1	Message	Date
Faraz Samapoor	e7cc7653b8	Refactors "strpos" calls in lib/private to improve code readability. ... Signed-off-by: Faraz Samapoor <fsamapoor@gmail.com>	3 years ago
Git'Fellow	951c5b973e	Normalize logical operators ... Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>	3 years ago
Côme Chilliet	546d94c3ec	Fix file_get_content signatures to make it clear it can return false ... In File::getContent, which must return a string, throw an Exception instead of returning false. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 years ago
Côme Chilliet	6633b4ced6	Remove unecessary fully qualified namespaces from phpdoc ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 years ago
Côme Chilliet	5ad045619c	View needs to return an instance of OC\Files\FileInfo explicitely ... Applications are calling methods from the class which are not from the public interface, and which cannot be added easily to public interface because Node interface extends FileInfo. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 years ago
Côme Chilliet	0b3dad895f	More type cleanup in View and FileInfo ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 years ago
Côme Chilliet	ea05544213	Fix return type of methods returning false on error ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 years ago
Côme Chilliet	4393b96542	Remove unused method getLocalFolder ... It’s not used and not in any OCP interface/class. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 years ago
Côme Chilliet	966a3e6963	Tidy up typing in OC\Files\View ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 years ago
Julius Härtl	d515da502f	fix: Use proper path for quota fetching ... Signed-off-by: Julius Härtl <jus@bitgrid.net>	3 years ago
Robin Appelman	5bcf37b7ff	only fetch the data for mounts inside a folder when needed ... for most operations we don't actually care about any mounts inside a folder, only for metadata that needs to propagate across storage boundaries (size, etag, mtime) do we need all the submount info. By only loading this data when needed we can save a bunch of storage setup in a number of cases Signed-off-by: Robin Appelman <robin@icewind.nl>	3 years ago
Côme Chilliet	028c225d96	Fix psalm errors ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 years ago
Côme Chilliet	ff776a90b1	Strong type filesize related methods to ease 32bits problem findings ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 years ago
Côme Chilliet	f5c361cf44	composer run cs:fix ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 years ago
Louis Chemineau	66ba90ceff	Update cache when file size === 0 ... The conditions were false when $result === 0. $results here contains the number of written bits. The correct way of checking for operation success is to check if $result === false Signed-off-by: Louis Chemineau <louis@chmn.me>	3 years ago
Carl Schwan	a5ea677370	Rename file1 and file2 to source and target in Storage abstraction ... Signed-off-by: Carl Schwan <carl@carlschwan.eu>	3 years ago
Carl Schwan	92a5a8f075	Cleanup tags and Share component ... - Port to LoggerInterface - Use IDBConnection and IQueryBuilder instead of raw SQL and OC_DB - Use IEventListener instead of hooks - Remove the now unused OC_DB and OC_DB_StatementWrapper legacy utils Signed-off-by: Carl Schwan <carl@carlschwan.eu>	3 years ago
Robin Appelman	cb51564356	trigger a rescan when trying to fopen a file that exists in cache but not on disk ... Signed-off-by: Robin Appelman <robin@icewind.nl>	3 years ago
luz paz	368f83095d	Fix typos in lib/private subdirectory ... Found via `codespell -q 3 -S l10n -L jus ./lib/private` Signed-off-by: luz paz <luzpaz@github.com>	3 years ago
Robin Appelman	6d6662ec68	expose displayname cache trough a public interface ... Signed-off-by: Robin Appelman <robin@icewind.nl>	4 years ago
Côme Chilliet	069477e608	Migrate more classes of lib/private to LoggerInterface ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	4 years ago
Robin Appelman	7a6c724a81	Use a lazy user for the file owner when listing a directory ... Only getUID and getDisplayName are called on the file owner objects anyway and we can get this information often without DB request Signed-off-by: Robin Appelman <robin@icewind.nl>	4 years ago
Robin Appelman	9f0ba3adc2	optimize adding submount info to directory content ... no need to loop when we can do a hashtable lookup Signed-off-by: Robin Appelman <robin@icewind.nl>	4 years ago
Robin Appelman	5e69f98c16	sh ... Signed-off-by: Robin Appelman <robin@icewind.nl>	4 years ago
Robin Appelman	151c800397	allow reusing known folder info when getting directory contents ... Signed-off-by: Robin Appelman <robin@icewind.nl>	4 years ago
Côme Chilliet	140624d551	composer run cs:fix ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	4 years ago
Côme Chilliet	d36a1a7bf6	Exit early if $storage is falsy in View::getDirectoryContent ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	4 years ago
Côme Chilliet	916fbe81c6	Fix incorrect if conditions in View ... ($something->getPermissions() && Constants::PERMISSION_READ) does not make sense as PERMISSION_READ contant is 1 this will always evaluate to true. getPersmissions is returning an int which is a bitwise combination as documented in the interface, so it should be used with bit operators. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	4 years ago
Robin Appelman	ff666e648a	Add dav plugin to trigger recalculating of checksums ... Signed-off-by: Robin Appelman <robin@icewind.nl>	4 years ago
Robin Appelman	917c74e214	type fixes ... Signed-off-by: Robin Appelman <robin@icewind.nl>	4 years ago
Robin Appelman	5c0fe93498	move teardown logic to SetupManager ... Signed-off-by: Robin Appelman <robin@icewind.nl>	4 years ago
Carl Schwan	6312c0df69	Check style update ... Signed-off-by: Carl Schwan <carl@carlschwan.eu>	4 years ago
Carl Schwan	aeecb72e96	Fix a few psalm issues and moved back to psalm/phar 4.18 ... Signed-off-by: Carl Schwan <carl@carlschwan.eu>	4 years ago
acsfer	97e1855ed5	Typo	4 years ago
acsfer	0a0fd33773	Check if size value is set ... Using `isset()` as it does not return true for array keys that correspond to a `null` value, while `array_key_exists()` does. Fix #29865	4 years ago
John Molakvoæ	d6152bf98d	Fix psalm ... Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>	4 years ago
John Molakvoæ	d6a26b2536	Revert "add dav plugin to trigger recalculating of checksums"	4 years ago
Robin Appelman	fd5e11a81a	Add dav plugin to trigger recalculating of checksums ... Signed-off-by: Robin Appelman <robin@icewind.nl>	4 years ago
John Molakvoæ (skjnldsv)	215aef3cbd	Update php licenses ... Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	5 years ago
Richard de Boer	7990f95558	Check whether output buffering is active before turning it off ... Before we just turned it off and @suppressed the error if ob was not active. In PHP 8 this error is no longer suppressed, so try to not cause it at all. Signed-off-by: Richard de Boer <git@tubul.net>	5 years ago
Christoph Wurst	8196420063	Drop \OCP\User ... Inlines and remaining usages and drops the deprecated public API. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	5 years ago
Robin Appelman	f98fed3f8a	reuse usermanager instance when processing search results ... saves some time when processing large search results Signed-off-by: Robin Appelman <robin@icewind.nl>	5 years ago
Julius Härtl	19eb48b8a3	Properly end iterating over the file once the target has been reached ... Signed-off-by: Julius Härtl <jus@bitgrid.net>	5 years ago
Christoph Wurst	d89a75be0b	Update all license headers for Nextcloud 21 ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	5 years ago
Ashod Nakashian	a66fb45c0b	Unlock when promoting to exclusive lock fails ... In certain cases changeLock to EXCLUSIVE fails and throws LockedException. This leaves the file locked as SHARED in file_put_contents, which prevents retrying (because on second call file_put_contents takes another SHARED lock on the same file, and changeLock doesn't allow more than a single SHARED lock to promote to EXCLUSIVE). To avoid this case, we catch the LockedException and unlock before re-throwing. Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>	5 years ago
Robin Appelman	cfde74442c	optimize View::getPath if we already know the storage id ... Signed-off-by: Robin Appelman <robin@icewind.nl>	5 years ago
Christoph Wurst	cb057829f7	Update license headers for 19 ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Scott Dutton	65e134c13a	Update View.php	6 years ago
Scott Dutton	75b99e85ff	Increase max read ... 8kb is very low, especially given this will be local files Signed-off-by: Scott Dutton <scott@exussum.co.uk>	6 years ago
Christoph Wurst	caff1023ea	Format control structures, classes, methods and function ... To continue this formatting madness, here's a tiny patch that adds unified formatting for control structures like if and loops as well as classes, their methods and anonymous functions. This basically forces the constructs to start on the same line. This is not exactly what PSR2 wants, but I think we can have a few exceptions with "our" style. The starting of braces on the same line is pracrically standard for our code. This also removes and empty lines from method/function bodies at the beginning and end. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago