248 Commits (b8046e2ba4f8d80cd8fda4dd078348d5bcf46bbc)

Author	SHA1	Message	Date
Christopher Ng	fb2fb0d2d5	Revert "Copy to clipboard with button instead of link" ... This reverts commit 4ffc022c8b. Signed-off-by: Christopher Ng <chrng8@gmail.com>	4 years ago
John Molakvoæ	a869259e41	More theming cypress tests and some fixes ... Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>	4 years ago
Christopher Ng	4ffc022c8b	Copy to clipboard with button instead of link ... Signed-off-by: Christopher Ng <chrng8@gmail.com>	4 years ago
Christopher Ng	20da3d081e	Add label to sharing search field ... Signed-off-by: Christopher Ng <chrng8@gmail.com>	4 years ago
Christopher Ng	4a2bbc7af9	Rewrite admin theming in Vue ... Signed-off-by: Christopher Ng <chrng8@gmail.com>	4 years ago
John Molakvoæ (skjnldsv)	db831359d3	Allow to pick custom colour ... Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	4 years ago
Joas Schilling	799f660df0	Make CI green again ... Signed-off-by: Joas Schilling <coding@schilljs.com>	4 years ago
Christopher Ng	7044191eb6	Use brand color for background only and keep accessible color as color primary ... Signed-off-by: Christopher Ng <chrng8@gmail.com>	4 years ago
Christopher Ng	295d03869e	Fix various theming bugs ... Signed-off-by: Christopher Ng <chrng8@gmail.com>	4 years ago
Vincent Petry	1998ac7b06	Increase timeout for apps management ... Signed-off-by: Vincent Petry <vincent@nextcloud.com>	4 years ago
Vincent Petry	da01494a37	Add accessibility entry in user menu ... Signed-off-by: Vincent Petry <vincent@nextcloud.com>	4 years ago
Carl Schwan	43d1aa38df	More cleaning up of the login component ... - Move css in scopped vue components - Port to NcNoteCard all the warning messages Signed-off-by: Carl Schwan <carl@carlschwan.eu>	4 years ago
szaimen	b31c92e6f5	fix tests ... Signed-off-by: szaimen <szaimen@e.mail.de>	4 years ago
Daniel Calviño Sánchez	92925233ec	Maximize browser window before running the tests ... By the default the browser window is not maximized, but opened with a size of 1050x978px. In the Files app, when the navigation bar and the side bar are both open, with the previous design that width caused the file name to be very very narrow, but still clickable. However, with the updated design the file name is too narrow and no longer clickable, which breaks several acceptance tests that descend into subfolders. To solve that now the browser window is maximized before running the tests, which makes the window wide enough (1360px) to show the file name and make it clickable. This commit also removes a step to close the sidebar that was recently added to address the problem mentioned above in a previous pull request. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	4 years ago
Daniel Calviño Sánchez	76b0947022	Wait for the new user form to be visible ... Before it was checked if the new user form was visible, but it was not waited for it. It seems that it can happen that the new user form is in the DOM, and therefore found, but not visible yet when the tests run, which caused them to (randomly) fail. Due to that now it is explicitly waited until it is visible, rather than assuming that it is visible as soon as it appears in the DOM. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	4 years ago
Julius Härtl	6dac33ee56	Adjust theming acceptance tests ... Signed-off-by: Julius Härtl <jus@bitgrid.net>	4 years ago
szaimen	17ee17cdbf	fix tests ... Signed-off-by: szaimen <szaimen@e.mail.de> Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	4 years ago
Daniel Calviño Sánchez	ac2d885899	Adjust acceptance tests to changes in app menu ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	4 years ago
Vincent Petry	ede9ac2a75	Adjust acceptance test selectors ... Signed-off-by: Vincent Petry <vincent@nextcloud.com>	4 years ago
Carl Schwan	a24ed79f85	Fix integration tests ... The html tags changed in the notification apps, adapt selector to the new state Signed-off-by: Carl Schwan <carl@carlschwan.eu>	4 years ago
Carl Schwan	253118298d	Redesign guest pages for better accessibility ... - Use white box and put content on it - Improve focus indicator Signed-off-by: Carl Schwan <carl@carlschwan.eu>	4 years ago
Daniel Calviño Sánchez	525cf58735	Adjust acceptance tests to changes in sharing tab ... The name of the user shared with is now marked with a "span" rather than with "h5". Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	4 years ago
Vincent Petry	bb2557c389	Replace files app ids to classes ... Replaced ids to classes for the following: - #filestable -> .files-filestable - #fileList -> .files-fileList - #controls -> .files-controls - #emptycontent -> .emptyfilelist.emptycontent Signed-off-by: Vincent Petry <vincent@nextcloud.com>	4 years ago
Cyrille Bollu	4a790fedf0	More meaningfull message when a public authenticated share's password is wrong or has expired ... Signed-off-by: Cyrille Bollu <cyrpub@bollu.be>	4 years ago
Côme Chilliet	8951f069fe	Require a recent phpunit version in integration and acceptance ... Otherwise build with PHP>8 will fail as PHPUnit 6 does not support it Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	4 years ago
Daniel Calviño Sánchez	3c451f8357	Adjust acceptance tests to changes in notifications markup ... Since nextcloud/notifications#1178 each notification in the list is a "<li>" rather than a "<div>". Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	4 years ago
John Molakvoæ	05a33ad713	Fix acceptance ... Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>	4 years ago
Christopher Ng	309354852f	Profile backend ... Signed-off-by: Christopher Ng <chrng8@gmail.com>	5 years ago
Louis Chemineau	32dc976e0d	Fix app-files acceptance tests ... Signed-off-by: Louis Chemineau <louis@chmn.me>	5 years ago
John Molakvoæ	cbe406ea3e	Bump @nextcloud/vue ... Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>	5 years ago
Julius Härtl	964fd27666	Handle single action unshare ... Signed-off-by: Julius Härtl <jus@bitgrid.net>	5 years ago
Simounet	45c3b2a478	Settings: new user row replaced by a modal ... Signed-off-by: Simounet <contact@simounet.net>	5 years ago
Daniel Calviño Sánchez	4b376a107b	Add automatic handling of "ElementNotInteractable" exceptions ... In the WebDriver protocol, when a command fails because it can not interact with the target element, an "element not interactable" error is generated. It can be a transitive issue (for example, due to an animation), so when the error is received the command should be tried again, just like done, for example, with "ElementNotVisible" exceptions. However, the last version of the "instaclick/php-webdriver" library compatible with the Selenium Driver of Mink did not support yet that WebDriver error. And even if Chrome is run using the old protocol an unknown "element not interactable" error can be received anyway in some cases. When an unknown error is received by the "instaclick/php-webdriver" library it is thrown as a generic Exception so, until the library can be updated, the message of generic exceptions is checked and the command is retried if it matched. For the time being "element not interactable" errors are handled like "ElementNotVisible" exceptions; this may need to change once the error is better understood. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	14b85f4eec	Replace carriage return with WebDriver "ENTER" constant ... When the value is set in some input fields a carriage return was sent to simulate pressing the enter key and thus confirming the input. However, different browsers use different keys (Firefox uses "\r", but Chrome uses "\n"), so the carriage return was replaced with the WebDriver "ENTER" constant which is common to both browsers. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	38b88422a8	Do not send "enter" key when not needed ... Sending the "enter" key is not needed in those input fields that auto save while the user is typing or when the focus is lost (which since version 1.4.0 the Selenium driver for Mink is automatically done after setting the value). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	f216b9307a	Update Mink from 1.7.1 to 1.8.1 in acceptance tests ... Since version 1.8.0 of Mink "Mink::getSession()" no longer starts the session automatically (see https://github.com/minkphp/Mink/pull/705), so it now needs to be explicitly started. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	7625a87412	Update Selenium driver for Mink from 1.3.1 to 1.4.0 in acceptance tests ... Since version 1.4.0 the Selenium driver for Mink uses again the element on which the value was set (see https://github.com/minkphp/MinkSelenium2Driver/pull/286). When creating a new folder or renaming one sending a new line ("\r") caused the element on which the value was set to be removed, so the element was no longer attached to the DOM when the driver tried to use it again, and thus a "StaleElementReference" exception was thrown. Due to this now it is needed to explicitly click the confirm button when creating a new folder. In the case of the renaming, on the other hand, nothing else besides not sending the new line is needed, as the Selenium driver now unfocuses the element (that is why it uses again the element after setting the value) which triggers the renaming. Besides that, the Selenium driver for Mink uses a library to simulate certain events, bitovi/syn. In version 1.4.0 that library was updated to version 0.0.3, which seems to somehow break pressing the "escape" key. Due to this now the sharing menu has to be closed by pressing "enter" on the share menu button instead. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	b53f49b940	Update PHPUnit from 4.X to 6.X in acceptance tests ... The PHPUnit update also required an update of "symfony/yaml", so besides the changes needed for PHPUnit the "behat.yml" file also had to be adjusted. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Joas Schilling	cf8f9c16df	Change label also in the acceptance tests ... Signed-off-by: Joas Schilling <coding@schilljs.com>	5 years ago
Daniel Calviño Sánchez	c51c3c771f	Remove unneeded steps to add already existing user ... User "user1" is added when installing and configuring the server, so it is already added in all tests. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	0e6401933b	Fix acceptance test for searching just added users in contacts menu ... User "user1" is added when installing and configuring the server, so it is already added in all tests. As the test verifies that just added users can be searched in the contacts menu a new user should be actually added. The test did not fail because it assumed that "user1" did not exist and just checked that it existed after "adding" it, but not whether adding it failed. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	ee1f8104a0	Find directly the label instead of falling back to it ... The input element is always hidden, so the check always ended falling back to the label. Moreover, the label is the element that the user interacts with, so it must be the one used. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	7b6946d2d2	Assert also element visibility instead of just finding it ... Although if the element could not be found an exception would be thrown and the test aborted if an element is in the DOM but hidden it would be found and the test would pass. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	78faf0105d	Add explicit locator for "Enable all" bundle button ... Instead of looking for the bundle button and then checking its value now the expected value is included in the locator and the button is checked similarly to other elements. No "Disable all" locator was added as it was not currently needed anywhere. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	f87473e410	Find elements through the actor rather than the driver ... "Actor::find" is a more robust way to look for elements, as it handles some exceptions that may be thrown. Therefore, even if the elements are not actually used and it is only checked whether they exist or not using the actor is the preferred way when possible (and it also makes it consistent with the rest of the acceptance tests). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	6d145ea54a	Add locator for apps list ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	4c23d24277	Fix identation ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	bc084070c8	Fix delete user acceptance test ... Adding some missing asserts showed that the "delete user" acceptance test was silently failing, as the deletion was not being confirmed in the dialog and thus the user was not being deleted. The dialog button contains a single quote ("user0's"), so the XPath expression had to be adjusted (it seems that it is not possible to escape a single quote in a string enclosed in single quotes in XPath 1.0). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	d5586ec437	Verify WaitFor::element... results with an assertion ... WaitFor::element... calls only perform the waiting and return whether the condition succeeded or not, but that result needs to be explicitly checked to prevent further steps from being executed if the wait failed. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	caa2246568	Add missing waits when finding elements in the acceptance tests ... As no timeout was specified the elements were tried to be found just once. This caused the steps to fail if the elements did not appear yet in the page when they were tried to be found. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago