nextcloud-server

Commit Graph

Author	SHA1	Message	Date
Ferdinand Thiessen	00386a5407	fix(settings): Use initial state instead of custom state for server data Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	2 years ago
Arthur Schiwon	c98b0462e3	fix(admin role): fix old and wrong way to determine whether user is admin - fixes Settings knowing who is an admin of non-local group backend groups - obsoletes and removes a little old, deprecated code - double checks proper parameter type on Group\Manager::isAdmin - also fixes legacy OC_User code to check whether user is an admin Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>	2 years ago
Joas Schilling	aa5f037af7	chore: apply changes from Nextcloud coding standards 1.1.1 Signed-off-by: Joas Schilling <coding@schilljs.com> Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>	2 years ago
Côme Chilliet	0a9371f99f	Migrate applications away from deprecated ILogger Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	2 years ago
Côme Chilliet	b843d09810	Fix typing errors in settings tests Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 years ago
Vincent Petry	f9ea078e27	Add unit test for case insensitive email saving Signed-off-by: Vincent Petry <vincent@nextcloud.com>	3 years ago
Carl Schwan	e35bcc9381	Fix tests Signed-off-by: Carl Schwan <carl@carlschwan.eu>	3 years ago
Arthur Schiwon	27865d03c0	use specific email getter where necessary Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>	4 years ago
John Molakvoæ (skjnldsv)	215aef3cbd	Update php licenses Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	5 years ago
Arthur Schiwon	847ed37afc	do not use private AccountManager in UsersController - extends IAccountProperty for verificationData getters and setters - implementation thereof ^ - and of course adaption of UsersController Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>	5 years ago
Daniel Calviño Sánchez	67dd087ce4	Fix deleting properties of user settings when not given explicitly The controller can receive an optional subset of the properties of the user settings; values not given are set to "null" by default. However, those null values overwrote the previously existing values, so in practice any value not given was deleted from the user settings. Now only non null values overwrite the previous values. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	a7431817b9	Respect additional user settings not covered by the controller "AccountManager::updateUser()" wipes previous user data with whichever user data is given (except for some adjustments, like resetting the verified status when needed). As the controller overrode the properties those properties would lose some of their attributes even if they are not affected by the changes made by the controller. Now the controller only modifies the attributes set ("value" and "scope") to prevent that. Note that with this change the controller no longer removes the "verified" status, but this is not a problem because, as mentioned, "AccountManager::updateUser()" resets them when needed (for example, when the value of the website property changes). This change is a previous step to fix overwritting properties with null values, and it will prevent the controller from making unexpected changes if more attributes are added in the future. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	c5e3d2e5c2	Add more unit tests for setting user settings Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	190ffd75b7	Change default test data to values less similar to empty values Right now it makes no difference, but this should make future tests clearer, specially in case of failure. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	ef5d538448	Extract default test data to a helper getter Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	8cae515daa	Use constants from interface rather than class Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Vincent Petry	5d14fd4396	Make extra user profile fields always editable The fields for phone number, address, website and twitter are now editable regardless whether federated sharing and the lookup server are enabled or not. Signed-off-by: Vincent Petry <vincent@nextcloud.com>	5 years ago
Vincent Petry	278a73789e	Map old account scope properties to new names Use new scope values in settings page. Adjust all consumers to use the new constants. Map old scope values to new ones in account property getter. Signed-off-by: Vincent Petry <vincent@nextcloud.com>	5 years ago
Joas Schilling	07095fd122	Also clear the knownUser when changing via the settings endpoint Signed-off-by: Joas Schilling <coding@schilljs.com>	5 years ago
Christoph Wurst	d89a75be0b	Update all license headers for Nextcloud 21 Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	5 years ago
Joas Schilling	9e04e6f99a	Also translate the phone number when coming in via the accounts manager API directly Signed-off-by: Joas Schilling <coding@schilljs.com>	5 years ago
Joas Schilling	da9462b482	Make code strict Signed-off-by: Joas Schilling <coding@schilljs.com>	5 years ago
Arthur Schiwon	f959828616	emit typed event for user management Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>	5 years ago
Christoph Wurst	2a054e6c04	Update the license headers for Nextcloud 20 Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	5 years ago
Morris Jobke	234b510652	Change PHPDoc type hint from PHPUnit_Framework_MockObject_MockObject to \PHPUnit\Framework\MockObject\MockObject Signed-off-by: Morris Jobke <hey@morrisjobke.de>	5 years ago
Christoph Wurst	caff1023ea	Format control structures, classes, methods and function To continue this formatting madness, here's a tiny patch that adds unified formatting for control structures like if and loops as well as classes, their methods and anonymous functions. This basically forces the constructs to start on the same line. This is not exactly what PSR2 wants, but I think we can have a few exceptions with "our" style. The starting of braces on the same line is pracrically standard for our code. This also removes and empty lines from method/function bodies at the beginning and end. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	afbd9c4e6e	Unify function spacing to PSR2 recommendation Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	2ee65f177e	Use the shorter phpunit syntax for mocked return values Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	5bf3d1bb38	Update license headers Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Roeland Jago Douma	3a7cf40aaa	Mode to modern phpunit Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	6 years ago
Roeland Jago Douma	c007ca624f	Make phpunit8 compatible Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	6 years ago
Christoph Wurst	de6940352a	Move settings to an app Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at> Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>	6 years ago
Bjoern Schiessle	4b3308bf3f	fix can change password check in case of encryption is enabled Admin should _not_ be able to change password when: - if an encryption module is loaded and it uses per-user keys - if encryption is enabled but no encryption modules are loaded Admin should be able to change the password when: - no encryption module is loaded and encryption is disabled - encryption module is loaded but it doesn't require per user keys Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>	7 years ago
John Molakvoæ (skjnldsv)	ae8ea57793	Bump tests and editorconfig Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	8 years ago
John Molakvoæ (skjnldsv)	62e1014b2e	Bump popovermenu item options and tests Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	8 years ago
John Molakvoæ (skjnldsv)	c8f670dd8f	Settings to vuejs Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	8 years ago
Roeland Jago Douma	7fc85bbf78	Obsolete test Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	8 years ago
John Molakvoæ (skjnldsv)	9440e9bb1e	Fixed Controller Test Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	8 years ago
Morris Jobke	b7c944fac1	Remove crypto and timefactory from UsersController Signed-off-by: Morris Jobke <hey@morrisjobke.de>	8 years ago
Morris Jobke	43e498844e	Use ::class in test mocks Signed-off-by: Morris Jobke <hey@morrisjobke.de>	8 years ago
Bjoern Schiessle	1a55ace97c	no warning on password change if no encryption module uses per-user keys Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>	9 years ago
Morris Jobke	f2b8535c7e	Update unit tests Signed-off-by: Morris Jobke <hey@morrisjobke.de>	9 years ago
Joas Schilling	f39fdaf46e	adjust the test Signed-off-by: Joas Schilling <coding@schilljs.com>	9 years ago
Arthur Schiwon	99e97f135d	consolidate setEnabled method and fix a unit test Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>	9 years ago
Morris Jobke	4c37c38051	fix unit tests Signed-off-by: Morris Jobke <hey@morrisjobke.de>	9 years ago
Morris Jobke	485d6d6577	use proper return codes and handle failure cases Signed-off-by: Morris Jobke <hey@morrisjobke.de>	9 years ago
Morris Jobke	2507e7459d	Improve wording of error messages Signed-off-by: Morris Jobke <hey@morrisjobke.de>	9 years ago
Morris Jobke	a8457df064	fix unit tests Signed-off-by: Morris Jobke <hey@morrisjobke.de>	9 years ago
Morris Jobke	72550377b4	add unit tests for enable method	9 years ago
Morris Jobke	e521b6799f	add unit tests for disable method	9 years ago

33 Commits (ba94de2510b3858f10d60f0230a58b1252346372)