nextcloud-server

Commit Graph

Author	SHA1	Message	Date
Git'Fellow	ef5f7d0a90	Us strpos() only Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>	2 years ago
Git'Fellow	53b84732a3	Check for open_basedir before reading /proc Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>	2 years ago
Simon L	b681cf735a	address review Signed-off-by: Simon L <szaimen@e.mail.de>	2 years ago
Simon L	531f5d1e4f	fix semaphore guarding Signed-off-by: Simon L <szaimen@e.mail.de>	2 years ago
Daniel Hansson	da2aad598e	also remove function Signed-off-by: Daniel Hansson <mailto@danielhansson.nu>	2 years ago
Daniel Hansson	b2d105e7ec	Generate all preview sizes for Imaginary A follow up on https://github.com/nextcloud/server/pull/40670 Based on discussions here: https://github.com/nextcloud/server/issues/38911#issuecomment-1741819188 This fixes the case were not all previews are generated, for example in the activity view: https://github.com/nextcloud/server/issues/38911#issuecomment-1738886106 Signed-off-by: Daniel Hansson <mailto@danielhansson.nu>	2 years ago
JanisPlayer	80abec668b	feat: Imaginary WebP support Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>	2 years ago
Joas Schilling	4f7de8ed60	fix!: Remove legacy event dispatching Symfony's GenericEvent Signed-off-by: Joas Schilling <coding@schilljs.com>	2 years ago
Daniel Kesselberg	440f882322	feat: add width, height, crop and mode to BeforePreviewFetchedEvent user_usage_report keeps a counter for files read. The app uses - OC_Filesystem::read hook - Event listener (the legacy one) for IPreview::EVENT Request for previews do not trigger the hook, hence the additional event listener. The thumbnails for a list or grid view should not count, so we need the width and height. Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>	3 years ago
Faraz Samapoor	e7cc7653b8	Refactors "strpos" calls in lib/private to improve code readability. Signed-off-by: Faraz Samapoor <fsamapoor@gmail.com>	3 years ago
Simon L	d55a7c619d	Fix typos in lib/public subdirectory Found via `codespell -q 3 -S l10n -L jus ./lib/public` Signed-off-by: luz paz <luzpaz@github.com> Update lib/public/Accounts/IAccount.php Signed-off-by: luz paz <luzpaz@github.com> Signed-off-by: Simon L <szaimen@e.mail.de> Co-Authored-By: Côme Chilliet <91878298+come-nc@users.noreply.github.com>	3 years ago
Glandos	e542e60dbc	try to make linters happy Signed-off-by: Glandos <bugs-github@antipoul.fr>	3 years ago
Glandos	3440387f0f	gather code from small and max preview use directory listing in both functions to gain 25% speed on run where every preview already exist. Signed-off-by: Glandos <bugs-github@antipoul.fr>	3 years ago
Glandos	24c121347a	Revert 0e49b40 Signed-off-by: Glandos <bugs-github@antipoul.fr>	3 years ago
Glandos	06a7e90383	improve parameter doc Signed-off-by: Glandos <bugs-github@antipoul.fr>	3 years ago
Glandos	4954bead1d	Ensure max preview image is not null Signed-off-by: Glandos <bugs-github@antipoul.fr>	3 years ago
Glandos	b6c65fee2a	php-cs-fix Signed-off-by: Glandos <bugs-github@antipoul.fr>	3 years ago
Glandos	9b4d5146d5	List preview directory only once getCachedPreview used to call `getFile`, and this calls `getDirectoryListing` (or underlying function that list directory) to find the file. This was done for every preview spec. Now, this is done only once at the beginning of the loop, and the array is just iterated when needed to find the correct entry. Signed-off-by: Glandos <bugs-github@antipoul.fr>	3 years ago
Thomas Citharel	e60888d988	fix(preview-generator): Throw exception before dividing by zero when generating previews If the maximum preview generated gives some kind of invalid IImage, it's dimentions and filename can be set to zero. And then later we do a division by zero to keep the aspect ratio of the previews. Signed-off-by: Thomas Citharel <tcit@tcit.fr>	3 years ago
Côme Chilliet	f5c361cf44	composer run cs:fix Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 years ago
szaimen	f9e9cd270d	Limit-number-of-concurrent-preview-generations Signed-off-by: Bowen Ding <dbw9580@live.com> Signed-off-by: szaimen <szaimen@e.mail.de>	3 years ago
Julius Härtl	07e94eca6f	Emit typed event when preview is requested Signed-off-by: Julius Härtl <jus@bitgrid.net>	3 years ago
Christopher Ng	57c66bf7cb	Use Image class from public API Signed-off-by: Christopher Ng <chrng8@gmail.com>	4 years ago
Carl Schwan	a5a4e0df1c	Fix crop condition Make sure that when fetching the image from the cache we don't accidentally fetch the cropped image just because it also start with 256-256 Signed-off-by: Carl Schwan <carl@carlschwan.eu>	4 years ago
Julius Härtl	3742b7392d	Add explicit return if getSmallImagePreview fails Signed-off-by: Julius Härtl <jus@bitgrid.net>	4 years ago
Carl Schwan	05bf8b4445	Fix cropped image generated when not asked The $crop parameter was not propagated to the imaginary pipeline and instead it used the smartcrop algorithm always Signed-off-by: Carl Schwan <carl@carlschwan.eu>	4 years ago
Richard Steinmetz	982c846b11	Fix preview generator trying to recreate an existing folder Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>	4 years ago
John Molakvoæ	3d1f22f6d8	Generate small preview straight away if Imaginary is enabled Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>	4 years ago
Vincent Petry	9b6a1cc8ae	Send images to imaginary docker to generate previews Signed-off-by: Carl Schwan <carl@carlschwan.eu> Co-Authored-by: Vincent Petry <vincent@nextcloud.com>	4 years ago
John Molakvoæ (skjnldsv)	40c10ab145	Properly log errors in Movie previews generation Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	4 years ago
John Molakvoæ (skjnldsv)	215aef3cbd	Update php licenses Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	5 years ago
J0WI	74a7c2eefc	Use correct getSystemValue type Signed-off-by: J0WI <J0WI@users.noreply.github.com>	5 years ago
Christoph Wurst	2a054e6c04	Update the license headers for Nextcloud 20 Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	5 years ago
Scott Dutton	b12a390220	Always try and show pre rendered preview Currently if the following situation happens Server generates preview Server has command removed which allows a preview to be shown Client asks for preview, gets a 404 error when preview exists (Mime checked before preview) This happens more often with documents, or video as the commands are not native PHP, they require a binary on the server. After the fix the following would happen Server generates preview Server has command removed which allows a preview to be shown Client asks for preview, gets preview which has been generated (Mime checked after preview) This would also allow offline generation (for example a docker image containing the extra binaries), allowing a reduction in attack surface of the instance serving the preview data. Signed-off-by: Scott Dutton <scott@exussum.co.uk>	5 years ago
Morris Jobke	f510da139f	Use class that actually has the destroy() method in preview generator Signed-off-by: Morris Jobke <hey@morrisjobke.de>	5 years ago
Elijah Martin-Merrill	56ed563b0c	fix memory leak caused by not destroying image in Preview/Generate.php Signed-off-by: Elijah Martin-Merrill <elijah@nyp-itsours.com>	6 years ago
Christoph Wurst	cb057829f7	Update license headers for 19 Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Robin Appelman	8f9bac26f8	fix preview generation tests Signed-off-by: Robin Appelman <robin@icewind.nl>	6 years ago
Christoph Wurst	14c996d982	Use elseif instead of else if Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Robin Appelman	7d386872e5	optimize batch generation of previews by allowing the generation of multiple previews at once we save on having to find, open and decode the max-preview for every preview of the same file the main use case for this is the preview generator app (pr for that comming next) in my local testing this saves about 25% of time when using the preview generator app Signed-off-by: Robin Appelman <robin@icewind.nl>	6 years ago
Robin Appelman	5cd12cd7c3	allow generating multiple preview sizes for a single file at once this saves having to do some of the overhead multiple times Signed-off-by: Robin Appelman <robin@icewind.nl>	6 years ago
Christoph Wurst	2fbad1ed72	Fix (array) indent style to always use one tab Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	74936c49ea	Remove unused imports Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
John Molakvoæ (skjnldsv)	6df44e407a	Also center vertically when cropping previews Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	6 years ago
Christoph Wurst	5bf3d1bb38	Update license headers Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Roeland Jago Douma	68748d4f85	Some php-cs fixes * Order the imports * No leading slash on imports * Empty line before namespace * One line per import * Empty after imports * Emmpty line at bottom of file Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	6 years ago
Robin Appelman	5e082f8946	allow keeping multiple preview "versions" of the same file The main use case here is storage provided versioning where we dont have separate file ids for all the versions, by allowing a prefix for the version we can store separate previews for all the versions. Additionally, by keeping all the version previews in the same folder as the "normal" previews they will be cleaned up properly when the file is deleted Signed-off-by: Robin Appelman <robin@icewind.nl>	7 years ago
John Molakvoæ (skjnldsv)	4505afe184	Allow IProviderV2 for previews as well Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	7 years ago
Robin Appelman	6150614374	Add new Provider interface for preview providers the main difference is passing the `File` object to the provider instead of a `View` + path Old providers will still continue to work as before Signed-off-by: Robin Appelman <robin@icewind.nl>	7 years ago
Roeland Jago Douma	ce10f8b8c4	Only generate previews in powers of 4 and set min Before we'd round up all preview request to their nearest power of two. This resulted still in a lot of possible images. Generating a lot of server load and taking up a lot of space. This moves it to previews to be powers of 4: 64, 256, 1024 and 4096 Also the first two powers are always skipped (4, 16) as it doesn't make sense to generate previews for that. We cache preview pretty agressively and I feel this is a better tradeoff. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	7 years ago

1 2

74 Commits (ba94de2510b3858f10d60f0230a58b1252346372)