nextcloud-server

Commit Graph

Author	SHA1	Message	Date
Christoph Wurst	14719110b9	chore: Replace \OC::$server->query with \OCP\Server::get in /lib Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	3 years ago
Côme Chilliet	426c0341ff	Use typed version of IConfig::getSystemValue as much as possible Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 years ago
Thomas Citharel	f7e65b1751	Create the database user in a transaction In OC\User\Manager::createUserFromBackend the newly created user is read using getUserObject($uid, $backend) but that can cause causal read issues (wrote in DB primary, not yet in secondary). In OC\User\Database user backend the user cache is unset after the insert, so it can't be used by getRealUID() (which is called by getUserObject()). To avoid that we make sure the user cache is repopulated in a transaction. Signed-off-by: Thomas Citharel <tcit@tcit.fr>	3 years ago
Côme Chilliet	556e3c84e6	Fix return type for countUsers method Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 years ago
Christopher Ng	d59585974e	Fix creation of new user and display the correct error message Signed-off-by: Christopher Ng <chrng8@gmail.com>	3 years ago
Carl Schwan	d5c23dbb9f	Move CappedMemoryCache to OCP This is an helpful helper that should be used in more place than just server and this is already the case with groupfodlers, deck, user_oidc and more using it, so let's make it public Signed-off-by: Carl Schwan <carl@carlschwan.eu>	4 years ago
Christopher Ng	c0868f93f1	Do not save invalid display name to the database Signed-off-by: Christopher Ng <chrng8@gmail.com>	4 years ago
Carl Schwan	9ec0cb0a90	Fix psalm issues related to the user backend - Reflect the actual return value returned by the implementation in the the interface. E.g. IUser\|bool -> IUser\|false - Remove $hasLoggedIn parameter from private countUser implementation. Replace the two call with the equivalent countSeenUser - getBackend is nuallable, add this to the interface - Use backend interface to make psalm happy about call to undefined methods. Also helps with getting rid at some point of the old implementActions Signed-off-by: Carl Schwan <carl@carlschwan.eu>	4 years ago
Joas Schilling	25caf4a42c	Update cache when setting the password Signed-off-by: Joas Schilling <coding@schilljs.com>	4 years ago
Joas Schilling	23ef02fbe2	Use the cache also for UserBackend::getPassword Signed-off-by: Joas Schilling <coding@schilljs.com>	4 years ago
Côme Chilliet	008b79d808	Fix type errors Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	4 years ago
John Molakvoæ (skjnldsv)	215aef3cbd	Update php licenses Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	5 years ago
Joas Schilling	3379e69ecc	Fix parameter types in docs Signed-off-by: Joas Schilling <coding@schilljs.com>	5 years ago
Joas Schilling	9a189bc710	Improve search results when only phonebook-matches can we autocompleted Signed-off-by: Joas Schilling <coding@schilljs.com>	5 years ago
Christoph Wurst	8b64e92b92	Bump doctrine/dbal from 2.12.0 to 3.0.0 Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	5 years ago
Christoph Wurst	d89a75be0b	Update all license headers for Nextcloud 21 Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	5 years ago
Morris Jobke	fedf9c69d9	Use matching parameter names form interfaces and implementations Found by Psalm 3.14.1 Signed-off-by: Morris Jobke <hey@morrisjobke.de>	5 years ago
Christoph Wurst	734c62bee0	Format code according to PSR2 Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	caff1023ea	Format control structures, classes, methods and function To continue this formatting madness, here's a tiny patch that adds unified formatting for control structures like if and loops as well as classes, their methods and anonymous functions. This basically forces the constructs to start on the same line. This is not exactly what PSR2 wants, but I think we can have a few exceptions with "our" style. The starting of braces on the same line is pracrically standard for our code. This also removes and empty lines from method/function bodies at the beginning and end. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	2fbad1ed72	Fix (array) indent style to always use one tab Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	74936c49ea	Remove unused imports Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	5bf3d1bb38	Update license headers Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	1a886b1472	Add typed events for password_policy Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Roeland Jago Douma	dd185e383d	Make sure limit is never negative There were some cases where a negative limit could be passed in. Which would happily make the query explode. This is just a quick hack to make sure it never is negative. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	6 years ago
Roeland Jago Douma	145eee91fe	Get the proper UID Some user backends (like the database backend) allow us to obtain a user case insensitive. However the UID itself is case sensitive. Example: * create a user User1 * login as User1 - This results the data/User1 folder to be created etc * now have some code somewhere that obtains the userFolder (from IRootFolder) but pas in 'uSER1' as uid - The code will check if that is a valid user. And in this case it is since User1 and uSER1 both map to the same user - However the the UID in the user object is used for the folder a new folder fill be create data/uSER1 With this PR this is avoided now. Since we obtain the real UID casing in the backend before creating the user object. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	6 years ago
Christoph Wurst	3174012adf	Add event dispatcher to OCP Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	7 years ago
Arthur Schiwon	96bab4f969	remove obsolete use statements Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>	7 years ago
Roeland Jago Douma	0c9a3de68f	Just update password hash without validating Fixes #11097 If your password hash changed (becuse your are on 7.2 and we moved to ARGON2). Then we shold not 'set a new password' but just update the hash. As else we invoke the password policy again which might lock out users. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	7 years ago
Robin Appelman	3392302d22	make table name configurable for db user backend Signed-off-by: Robin Appelman <robin@icewind.nl>	8 years ago
Robin Appelman	4187d2cdb3	use query builder in all places in the db user backend Signed-off-by: Robin Appelman <robin@icewind.nl>	8 years ago
Arthur Schiwon	38a90130ce	move log constants to ILogger Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>	8 years ago
Roeland Jago Douma	81f71cb1f9	Numeric only uids are no fun Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	8 years ago
Roeland Jago Douma	074a0e0665	Cast retrieved DB fields to string Fixes #9279 If a pure numerical user is in the DB the value might be casted to a int when returned. Cast it all to a string so we don't break the strict typing. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	8 years ago
Roeland Jago Douma	8edbeb159e	Use the uid_lower column This can use a proper index Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	8 years ago
Roeland Jago Douma	471272d456	Move to ABackend Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	8 years ago
Roeland Jago Douma	cbd2be583a	Move Database backend over to new User/Backend interfaces Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	8 years ago
Daniel Calviño Sánchez	0b96a71a68	Fix configuration values matched in user searches Due to a misplaced closing parenthesis the condition of the left join clause was just "userid = uid"; the other conditions were passed as additional parameters to "leftJoin", and thus they were ignored. Therefore, the result set contained every preference of each user instead of only the email, so the "WHERE configvalue LIKE XXX" matched any configuration value of the user. Besides the closing parenthesis this commit also fixes the literal values. Although "Literal" objects represent literal values they must be created through "IExpressionBuilder::literal()" to be properly quoted; otherwise it is just a plain string, which is treated as a column name. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Robin Appelman	aad01894e3	refactor user searching add additional user searching tests Signed-off-by: Robin Appelman <robin@icewind.nl>	8 years ago
Abijeet	ec28c54dbc	Adds search by email function on the users screen. Fixes #7175. - Updated the query to fetch the users in users > everyone tab. - Updated the query to fetch the users in users > admin tab. - Tested to ensure that the disabled users are also being fetched. - Added test cases. Signed-off-by: Abijeet <abijeetpatro@gmail.com>	8 years ago
Morris Jobke	eb0f3ebf75	Fix search in user managent when no group is selected * also allows to search by displayname Signed-off-by: Morris Jobke <hey@morrisjobke.de>	8 years ago
Morris Jobke	31c5c2a592	Change @georgehrke's email Signed-off-by: Morris Jobke <hey@morrisjobke.de>	8 years ago
Morris Jobke	0eebff152a	Update license headers Signed-off-by: Morris Jobke <hey@morrisjobke.de>	8 years ago
Lukas Reschke	ed8a98eaa1	Prevent SQL error message in case of error `\OC\User\Database::createUser` can throw a PHP exception in case the UID is longer than permitted in the database. This is against it's PHPDocs and we should cast this to `false`, so that the regular error handling triggers in. The easiest way to reproduce is on MySQL: 1. Create user `aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa` in admin panel 2. Create user `aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa` in admin panel again 3. See SQL exception as error message Signed-off-by: Lukas Reschke <lukas@statuscode.ch>	8 years ago
Robin Appelman	0aeb595784	user ids are strings Signed-off-by: Robin Appelman <robin@icewind.nl>	9 years ago
Morris Jobke	dbaebc53b0	fix sorting in the backend Signed-off-by: Morris Jobke <hey@morrisjobke.de>	9 years ago
Vincent Petry	aacfef463c	Add tests for database user backend caching Add comment, closeCursor in user DB query Invalidate user in cache after successful creation Signed-off-by: Morris Jobke <hey@morrisjobke.de>	9 years ago
Jörn Friedrich Dreyer	592c04a9db	cache loadUser if not exists Signed-off-by: Morris Jobke <hey@morrisjobke.de>	9 years ago
Lukas Reschke	d134dea508	Don't call function in constructor The constructor is iniitiated already very early in base.php, thus requiring this here will break the setup and some more. For now we probably have to live with a static function call here thus. Signed-off-by: Lukas Reschke <lukas@statuscode.ch>	9 years ago
Lukas Reschke	085891a15d	Escape like parameters in database user backend Signed-off-by: Lukas Reschke <lukas@statuscode.ch>	9 years ago
Loki3000	8ab16f87ac	spaces added	9 years ago

1 2

64 Commits (ba94de2510b3858f10d60f0230a58b1252346372)