152 Commits (bf2dcd67f3cb83e3bebc472d65fac3bc8755e25d)

Author	SHA1	Message	Date
Christoph Wurst	14719110b9	chore: Replace \OC::$server->query with \OCP\Server::get in /lib ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	3 years ago
Arthur Schiwon	a0f9556f7c	fix: cominbation of small fixes ... - possible null return - parameter name mismatch in implementation - incomplete unit test Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>	3 years ago
Arthur Schiwon	221562d45d	feat: add searchBySystemTag as PHP API ... Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>	3 years ago
Arthur Schiwon	b0d1cf5730	fix: change if with conditionless else to switch; and a parameter value ... Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>	3 years ago
Arthur Schiwon	58f7fd2370	use efficient tag retrieval on DAV report request ... - uses DAV search approach against valid files joined by systemtag selector - reduced table join for tag/systemtag search - supports pagination - no changes to the output formats or similar Example request body: <?xml version="1.0"?> <oc:filter-files xmlns:d="DAV:" xmlns:oc="http://owncloud.org/ns" xmlns:nc="http://nextcloud.org/ns" xmlns:ocs="http://open-collaboration-services.org/ns"> <d:prop> <d:getcontentlength/> <d:getcontenttype/> <d:getetag/> <d:getlastmodified/> <d:resourcetype/> <nc:face-detections/> <nc:file-metadata-size/> <nc:has-preview/> <nc:realpath/> <oc:favorite/> <oc:fileid/> <oc:permissions/> <nc:nbItems/> </d:prop> <oc:filter-rules> <oc:systemtag>32</oc:systemtag> </oc:filter-rules> <d:limit> <d:nresults>50</d:nresults> <nc:firstresult>0</nc:firstresult> </d:limit> </oc:filter-files> Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>	3 years ago
Arthur Schiwon	088a0eea29	ci: pro forma check of existence of internal method ... createNode() is protected and used by Folder, but being an internal-only method it shall not be exposed in the Folder or IRootFolder interface. Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>	3 years ago
Arthur Schiwon	71e41ffeeb	refactor: declare getMount() and getMountsIn() at IRootFolder ... Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>	3 years ago
Arthur Schiwon	f6ac874dbf	chore: ugly type juggling ... Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>	3 years ago
Arthur Schiwon	167a5f394d	fix: add typehine for IRootFolder ... Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>	3 years ago
Faraz Samapoor	e7cc7653b8	Refactors "strpos" calls in lib/private to improve code readability. ... Signed-off-by: Faraz Samapoor <fsamapoor@gmail.com>	3 years ago
Arthur Schiwon	dbfd2f936a	refactor: remove SystemTag logic from Folder into QuerySearchHelper ... - adds OC\SystemTag\SystemTagsInFilesDetector where the search logic is moved to Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>	3 years ago
Arthur Schiwon	2489a2d63a	feat: specify media type via url path: systemtags-current/$mediaType ... - only the media part of the mime type can be search, but not the full mime type. It can be added, should it become necessary. - thus fixes previously hardcoded selector for image/ types - also fixes a return type hint - adds a return type hint Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>	3 years ago
Arthur Schiwon	6bff6a5667	PoC: SystemTags endpoint to return tags used by a user with meta data ... Target case is photos app: when visiting the tags category, all systemtags of the whole cloud are retrieved. In subequent steps the next tag is requested until the browser view is filled with tag tiles (i.e. previews are requested just as well). With this approach, we incorpoate the dav search and look for user related tags that are used by them, and already returns the statistics (number of files tagged with the respective tag) as well as a file id for the purpose to load the preview. This defaults to the file with the highest id. Call: curl -s -u 'user:password' \ 'https://my.nc.srv/remote.php/dav/systemtags-current' \ -X PROPFIND -H 'Accept: text/plain' \ -H 'Accept-Language: en-US,en;q=0.5' -H 'Depth: 1' \ -H 'Content-Type: text/plain;charset=UTF-8' \ --data @/home/doe/request-systemtag-props.xml With request-systemtag-props.xml: <?xml version="1.0" encoding="UTF-8"?> <d:propfind xmlns:d="DAV:"> <d:prop xmlns:oc="http://owncloud.org/ns" xmlns:nc="http://nextcloud.org/ns"> <oc:id/> <oc:display-name/> <oc:user-visible/> <oc:user-assignable/> <oc:can-assign/> <nc:files-assigned/> <nc:reference-fileid/> </d:prop> </d:propfind> Example output: … <d:response> <d:href>/master/remote.php/dav/systemtags/84</d:href> <d:propstat> <d:prop> <oc:id>84</oc:id> <oc:display-name>Computer</oc:display-name> <oc:user-visible>true</oc:user-visible> <oc:user-assignable>true</oc:user-assignable> <oc:can-assign>true</oc:can-assign> <nc:files-assigned>42</nc:files-assigned> <nc:reference-fileid>924022</nc:reference-fileid> </d:prop> <d:status>HTTP/1.1 200 OK</d:status> </d:propstat> </d:response> <d:response> <d:href>/remote.php/dav/systemtags/97</d:href> <d:propstat> <d:prop> <oc:id>97</oc:id> <oc:display-name>Bear</oc:display-name> <oc:user-visible>true</oc:user-visible> <oc:user-assignable>true</oc:user-assignable> <oc:can-assign>true</oc:can-assign> <nc:files-assigned>1</nc:files-assigned> <nc:reference-fileid>923422</nc:reference-fileid> </d:prop> <d:status>HTTP/1.1 200 OK</d:status> </d:propstat> </d:response> … Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>	3 years ago
Côme Chilliet	1cc1866ba3	Add back missing slash in LazyUserFolder path ... Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>	3 years ago
Côme Chilliet	6034cc6893	Make sure to never trigger files hooks on a null path ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 years ago
Carl Schwan	85770f3b9f	Make it easier to debug issue #32304 ... Signed-off-by: Carl Schwan <carl@carlschwan.eu>	3 years ago
Côme Chilliet	546d94c3ec	Fix file_get_content signatures to make it clear it can return false ... In File::getContent, which must return a string, throw an Exception instead of returning false. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 years ago
Julius Härtl	160bd75d0a	fix: Use proper path when creating node instances ... Signed-off-by: Julius Härtl <jus@bitgrid.net>	3 years ago
Côme Chilliet	f974281ac9	Improve typing for fopen/toTmpFile ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 years ago
jld3103	dcf6ebebab	Fix inherited parameter names ... Signed-off-by: jld3103 <jld3103yt@gmail.com>	3 years ago
Robin Appelman	d6818ba894	optimize LazyUserFolder::getMountPoint ... no need to do a full setup Signed-off-by: Robin Appelman <robin@icewind.nl>	3 years ago
Robin Appelman	5bcf37b7ff	only fetch the data for mounts inside a folder when needed ... for most operations we don't actually care about any mounts inside a folder, only for metadata that needs to propagate across storage boundaries (size, etag, mtime) do we need all the submount info. By only loading this data when needed we can save a bunch of storage setup in a number of cases Signed-off-by: Robin Appelman <robin@icewind.nl>	3 years ago
Côme Chilliet	cd885b5705	Type sizes as int|float throughout the code base ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 years ago
Côme Chilliet	a78595a45f	Make sure that path is normalized and then checked, ... and not the other way around Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 years ago
Glandos	48ca33761f	Test valid path only if file info has to be retrieved ... Signed-off-by: Glandos <bugs-github@antipoul.fr>	3 years ago
Carl Schwan	67551f379f	Filter out old files when trying to get recent files ... Only do so when asking for less than 100 files and having an offset equal to 0. Signed-off-by: Carl Schwan <carl@carlschwan.eu>	3 years ago
Robin Appelman	e9ba58ca61	remove leading slash for search results at mountpoint root ... Signed-off-by: Robin Appelman <robin@icewind.nl>	3 years ago
Julius Härtl	83b1415906	Only pass parent if paths match ... As the user folder might be initialized by the root from two levels down the hierarchy, passing this as a parent only works if the path matches Signed-off-by: Julius Härtl <jus@bitgrid.net>	3 years ago
Julius Härtl	b2d6435737	Avoid extra query for the parent node if we can pass it along ... Signed-off-by: Julius Härtl <jus@bitgrid.net>	3 years ago
Paweł Bogusławski	a850424b1b	Update Folder.php ... Signed-off-by: Pawel Boguslawski <pawel.boguslawski@ib.pl>	3 years ago
Paweł Bogusławski	097b78594a	Update Folder.php ... Signed-off-by: Pawel Boguslawski <pawel.boguslawski@ib.pl>	3 years ago
Paweł Bogusławski	04baf69fea	Update lib/private/Files/Node/Folder.php ... Co-authored-by: Vincent Petry <vincent@nextcloud.com> Signed-off-by: Pawel Boguslawski <pawel.boguslawski@ib.pl>	3 years ago
Pawel Boguslawski	9eb1a92fa4	Paths added to messages and message cleanup ... This mod adds path to error messages. Without it it's difficult for example to find what path causes permission problems. Related: https://help.nextcloud.com/t/ocp-files-notpermittedexception-could-not-create-folder/133818 Related: https://help.nextcloud.com/t/could-not-create-folder-false-error/65962/ Author-Change-Id: IB#1121253 Signed-off-by: Pawel Boguslawski <pawel.boguslawski@ib.pl>	3 years ago
luz paz	368f83095d	Fix typos in lib/private subdirectory ... Found via `codespell -q 3 -S l10n -L jus ./lib/private` Signed-off-by: luz paz <luzpaz@github.com>	3 years ago
Carl Schwan	d5c23dbb9f	Move CappedMemoryCache to OCP ... This is an helpful helper that should be used in more place than just server and this is already the case with groupfodlers, deck, user_oidc and more using it, so let's make it public Signed-off-by: Carl Schwan <carl@carlschwan.eu>	4 years ago
Côme Chilliet	1bd5222224	Fix PHP 8.2 warnings about undeclared properties ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	4 years ago
Arthur Schiwon	1ec4563c2e	log stacktrace for 'Backends provided no user object' ... Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>	4 years ago
Robin Appelman	b65d214f15	perform a setup if we can't find any mounts containing a file ... Signed-off-by: Robin Appelman <robin@icewind.nl>	4 years ago
Robin Appelman	499749dbc1	more preset metadata for LazyUserFolder ... Signed-off-by: Robin Appelman <robin@icewind.nl>	4 years ago
Robin Appelman	151c800397	allow reusing known folder info when getting directory contents ... Signed-off-by: Robin Appelman <robin@icewind.nl>	4 years ago
Robin Appelman	d84f9fa9bb	rename cached fileinfo on rename ... Signed-off-by: Robin Appelman <robin@icewind.nl>	4 years ago
Robin Appelman	754603a04e	dont needlessly resolve path when getting internalPath/storage from Node ... Signed-off-by: Robin Appelman <robin@icewind.nl>	4 years ago
Robin Appelman	44a8ebdc1f	optimize getById on LazyUserFolder to not require a full fs setup ... Signed-off-by: Robin Appelman <robin@icewind.nl>	4 years ago
Robin Appelman	700444e218	split out some path manipulation logic ... Signed-off-by: Robin Appelman <robin@icewind.nl>	4 years ago
Robin Appelman	f7c942a943	caching of userfolder ... Signed-off-by: Robin Appelman <robin@icewind.nl>	4 years ago
Robin Appelman	70c37c2717	fmt ... Signed-off-by: Robin Appelman <robin@icewind.nl>	4 years ago
Robin Appelman	79f6742410	improve lazy UserFolder ... Signed-off-by: Robin Appelman <robin@icewind.nl>	4 years ago
Robin Appelman	3fc5c97282	return a lazy folder from Root::getUserFolder ... Signed-off-by: Robin Appelman <robin@icewind.nl>	4 years ago
Robin Appelman	46d0eef8da	allow setting some metadata in the lazyfolder without having to get the real folder ... Signed-off-by: Robin Appelman <robin@icewind.nl>	4 years ago
Côme Chilliet	6be7aa112f	Migrate from ILogger to LoggerInterface in lib/private ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	4 years ago