56 Commits (bf7dc2f2e7a4ef82db38d10deebfdfaebdac4b13)

Author	SHA1	Message	Date
provokateurin	a978e0a806	fix(Share20\DefaultShareProvider): Return link shares in getSharesByPath() ... Signed-off-by: provokateurin <kate@provokateurin.de>	1 year ago
Ferdinand Thiessen	db94e10af0	fix: Prevent breaking change in IQueryBuilder ... Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	1 year ago
Ferdinand Thiessen	2e4d3e4e75	fix(share): Return empty string if no label is set ... * Resolves: https://github.com/nextcloud/server/issues/48629 While the database supports NULL, the typing has always said it only returns *string*. So to not break any apps that might trust the typings we should return `''` if the database is set to `NULL`. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	1 year ago
provokateurin	9836e9b164	chore(deps): Update nextcloud/coding-standard to v1.3.1 ... Signed-off-by: provokateurin <kate@provokateurin.de>	1 year ago
Christoph Wurst	49dd79eabb	refactor: Add void return type to PHPUnit test methods ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	1 year ago
Robin Appelman	382d102d22	test: fix share provider tests for sharding ... Signed-off-by: Robin Appelman <robin@icewind.nl>	1 year ago
Daniel Kesselberg	af6de04e9e	style: update codestyle for coding-standard 1.2.3 ... Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>	1 year ago
Côme Chilliet	1cfc25d08c	fix(tests): Adapt tests to change of DefaultShareProvider constructor ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	1 year ago
skjnldsv	967b3848e0	fix(files_sharing): phpunit & openapi fixes ... Signed-off-by: skjnldsv <skjnldsv@protonmail.com>	2 years ago
Côme Chilliet	de6bb33d99	fix(tests): Fix tests with new LazyUser usage in DefaultShareProvider ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	2 years ago
Andy Scherzinger	1f7e2ba599	chore: Add SPDX header ... Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>	2 years ago
Robin Appelman	e7a7b4a401	perf: switch places that always use the first getById result to getFirstNodeById ... Signed-off-by: Robin Appelman <robin@icewind.nl>	2 years ago
Joas Schilling	aa5f037af7	chore: apply changes from Nextcloud coding standards 1.1.1 ... Signed-off-by: Joas Schilling <coding@schilljs.com> Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>	2 years ago
Andrew Summers	40edb426a3	Refactor `OC\Server::getRootFolder` ... Signed-off-by: Andrew Summers <18727110+summersab@users.noreply.github.com>	2 years ago
John Molakvoæ (skjnldsv)	f828dce597	Fix sharing creation insert and get ... Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	2 years ago
Andrew Summers	6b09a79227	Refactor `OC\Server::getShareManager` ... Signed-off-by: Andrew Summers <18727110+summersab@users.noreply.github.com>	2 years ago
Côme Chilliet	f5c361cf44	composer run cs:fix ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 years ago
Joas Schilling	e674087ebf	Adjust unit tests ... Signed-off-by: Joas Schilling <coding@schilljs.com>	3 years ago
Vincent Petry	a95c19e14b	Add share attributes + prevent download permission ... Makes it possible to store download permission Signed-off-by: Vincent Petry <vincent@nextcloud.com>	3 years ago
Carl Schwan	6312c0df69	Check style update ... Signed-off-by: Carl Schwan <carl@carlschwan.eu>	4 years ago
Arthur Schiwon	be3ae9a44b	gracefully handle deleteFromSelf when share is already gone ... - handling race conditions Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>	5 years ago
Christoph Wurst	d9015a8c94	Format code to a single space around binary operators ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	5 years ago
Morris Jobke	234b510652	Change PHPDoc type hint from PHPUnit_Framework_MockObject_MockObject to \PHPUnit\Framework\MockObject\MockObject ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	5 years ago
Joas Schilling	89ed2c37bf	Update share type constant usage ... Signed-off-by: Joas Schilling <coding@schilljs.com>	6 years ago
Joas Schilling	95652d4469	Fix language in share notes email for users ... Signed-off-by: Joas Schilling <coding@schilljs.com>	6 years ago
Morris Jobke	16f4b43d94	Adjust tests to only return group IDs ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	6 years ago
Christoph Wurst	caff1023ea	Format control structures, classes, methods and function ... To continue this formatting madness, here's a tiny patch that adds unified formatting for control structures like if and loops as well as classes, their methods and anonymous functions. This basically forces the constructs to start on the same line. This is not exactly what PSR2 wants, but I think we can have a few exceptions with "our" style. The starting of braces on the same line is pracrically standard for our code. This also removes and empty lines from method/function bodies at the beginning and end. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	afbd9c4e6e	Unify function spacing to PSR2 recommendation ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	2fbad1ed72	Fix (array) indent style to always use one tab ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	2ee65f177e	Use the shorter phpunit syntax for mocked return values ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Roeland Jago Douma	3a7cf40aaa	Mode to modern phpunit ... Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	6 years ago
Roeland Jago Douma	c007ca624f	Make phpunit8 compatible ... Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	6 years ago
Roeland Jago Douma	68748d4f85	Some php-cs fixes ... * Order the imports * No leading slash on imports * Empty line before namespace * One line per import * Empty after imports * Emmpty line at bottom of file Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	6 years ago
Daniel Calviño Sánchez	2f49806c20	Add unit tests for "getAllShares()" ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	6 years ago
Julius Härtl	857fae288c	Always set the display name for user shares ... Signed-off-by: Julius Härtl <jus@bitgrid.net>	7 years ago
Daniel Calviño Sánchez	fe8a67f517	Store "sendPasswordByTalk" property of link shares in the database ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	7 years ago
Daniel Calviño Sánchez	00e4c8aee4	Fix update share tests ... The update share tests only checked that the share returned by "update()" had the expected values. However, as "update()" returns the same share that was given as a parameter the tests were not really verifying that the values were updated in the database. In a similar way, the test that checked that a password was removed did not set a password first, so even if the database returned null it could be simply returning the default value for the share; a password must be set first to ensure that it is removed. Besides that, a typo was fixed too that made the checks on the original share instead of on the one returned by "update()"; right now it is the same share, so the change makes no difference, but it is how the check should be done anyway. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	7 years ago
Bjoern Schiessle	b81962e3e8	fix unit tests ... Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>	8 years ago
Maxence Lange	4f5814c27b	tests ... Signed-off-by: Maxence Lange <maxence@nextcloud.com>	8 years ago
Joas Schilling	629b7c0fc3	Adjust docs and make !$currentAccess simpler ... Signed-off-by: Joas Schilling <coding@schilljs.com>	9 years ago
Joas Schilling	5b57bb955b	Fix default share provider ... Signed-off-by: Joas Schilling <coding@schilljs.com>	9 years ago
Roeland Jago Douma	12afd7d1d5	Add mail element to access list ... * Each provider just returns what they have so adding an element won't require changing everything * Added tests Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	9 years ago
Roeland Jago Douma	2cbac3357b	Offload acceslist creation to providers ... * This allows for effective queries. * Introduce currentAccess parameter to speciy if the users needs to have currently acces (deleted incomming group share). (For notifications) Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	9 years ago
Bjoern Schiessle	3323d01db1	update unit tests ... Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>	9 years ago
Vincent Petry	377fdf3860	Skip null groups in group manager (#26871) (#26956) ... * Skip null groups in group manager (#26871) * Skip null groups in group manager * Also skip null groups in group manager's search function * Add more group null checks in sharing code * Add unit tests for null group safety in group manager * Add unit tests for sharing code null group checks * Added tests for null groups handling in sharing code * Ignore moveShare optional repair in mount provider In some cases, data is inconsistent in the oc_share table due to legacy data. The mount provider might attempt to make it consistent but if the target group does not exist any more it cannot work. In such case we simply ignore the exception as it is not critical. Keeping the exception would break user accounts as they would be unable to use their filesystem. * Adjust null group handing + tests * Fix new group manager tests Signed-off-by: Morris Jobke <hey@morrisjobke.de>	9 years ago
Roeland Jago Douma	7e2159e9bb	Add defaultShareProvider & federatedshareprovider tests ... Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	9 years ago
Roeland Jago Douma	eaf152efeb	Fix DateTime comparisson ... Datetime now returns microseconds. But if the database doesn't store those comparing them for equality most likely fails. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	9 years ago
Roeland Jago Douma	3c173378e8	Fix typehint ... Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	9 years ago
Thomas Müller	2806a4bca7	Cleanup test case ... Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	9 years ago
Vincent Petry	626daabb56	Prefilter inaccessible shares in DefaultShareProvider::getSharedWith() ... The DefaultShareProvider now does a DB-level check to find out whether file_source is accessible at all (deleted file) or whether it's in the trashbin of a home storage. One small corner case where the home storage id is in md5 form cannot be covered properly with this approach. Signed-off-by: Lukas Reschke <lukas@statuscode.ch>	9 years ago