nextcloud-server

Commit Graph

Author	SHA1	Message	Date
Robin Appelman	b1f352c614	improve handling of files we can't access in the scanner instead of erroring, remove the items from the cache. this situation can be triggered if a user has access to a file but looses it afterwards Signed-off-by: Robin Appelman <robin@icewind.nl>	3 years ago
Carl Schwan	a5ea677370	Rename file1 and file2 to source and target in Storage abstraction Signed-off-by: Carl Schwan <carl@carlschwan.eu>	3 years ago
Carl Schwan	74e6976779	Use argument name from parent class This will be an issue with php 8, so best to fix it now Signed-off-by: Carl Schwan <carl@carlschwan.eu>	3 years ago
Carl Schwan	ff4c8e9bee	Force cast getCode to int Otherwise psalm complains that the type can also be a non-falsy-string Signed-off-by: Carl Schwan <carl@carlschwan.eu>	3 years ago
Carl Schwan	d5c23dbb9f	Move CappedMemoryCache to OCP This is an helpful helper that should be used in more place than just server and this is already the case with groupfodlers, deck, user_oidc and more using it, so let's make it public Signed-off-by: Carl Schwan <carl@carlschwan.eu>	4 years ago
Carl Schwan	ec6b83cc18	Add stricter psalm type for CappedMemoryCache Signed-off-by: Carl Schwan <carl@carlschwan.eu>	4 years ago
Robin Appelman	a6f245f6ff	type hint as generator Signed-off-by: Robin Appelman <robin@icewind.nl>	4 years ago
Robin Appelman	5b77099612	handle invilid type when listing directory in smb just handle it as an empty directory Signed-off-by: Robin Appelman <robin@icewind.nl>	4 years ago
Robin Appelman	e2aa283dba	handle notfound and notpermitted error in Smb::getDirectoryContent Signed-off-by: Robin Appelman <robin@icewind.nl>	4 years ago
Carl Schwan	365f5e425f	Add additional logging on SMB failure to read folder content Currently we discard the error comming from the SMB library and create a new exception for nextcloud. This patch makes sure that the access/permission exception from the SMB library are logged correctly. Signed-off-by: Carl Schwan <carl@carlschwan.eu>	4 years ago
Richard Steinmetz	2e53cf4c1f	Gracefully handle smb acls for users without a domain Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>	4 years ago
John Molakvoæ (skjnldsv)	215aef3cbd	Update php licenses Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	5 years ago
Julius Härtl	8f01bc65f1	Continue iterating over diretory contents and just hide file if denied by acl Signed-off-by: Julius Härtl <jus@bitgrid.net>	5 years ago
Robin Appelman	43f70e5817	ignore readonly flag for directories see http://support.microsoft.com/kb/326549 Signed-off-by: Robin Appelman <robin@icewind.nl>	5 years ago
Robin Appelman	5ffaa94fbc	add (hidden) option to always show smb root as writable some smb servers are very insistent in reporting that the root of the share is readonly, even if it isn't. This works around the problem by adding a hidden option to overwrite the permissions of the root of the share. This can be enabled using ```bash occ files_external:config <mount id> root_force_writable true ``` where you can find your mount id using ```bash occ files_external:list ``` Signed-off-by: Robin Appelman <robin@icewind.nl>	5 years ago
Robin Appelman	b844293536	catch notfound and forbidden exception in smb::getmetadata Signed-off-by: Robin Appelman <robin@icewind.nl>	5 years ago
Julius Härtl	e9ae943bba	Properly handle SMB ACL blocking scanning a directory This makes sure that a possible ForbiddenException is properly passed through the storage as a ForbiddenException and can be catched when trying to fetch the quota info of a parent folder Signed-off-by: Julius Härtl <jus@bitgrid.net>	5 years ago
Christoph Wurst	73c7d0dc81	Bump icewind/streams from 0.7.1 to 0.7.2 Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	5 years ago
Christoph Wurst	d89a75be0b	Update all license headers for Nextcloud 21 Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	5 years ago
Robin Appelman	43b3049a4f	improve handling of out of space errors for smb Signed-off-by: Robin Appelman <robin@icewind.nl>	5 years ago
Morris Jobke	fedf9c69d9	Use matching parameter names form interfaces and implementations Found by Psalm 3.14.1 Signed-off-by: Morris Jobke <hey@morrisjobke.de>	5 years ago
Robin Appelman	23e2baeb95	Add option to check share ACL's when listing directories If a file or folder in a directory doesn't have read permissions they will not be shown Note that enabling this option incurs a performance penalty additional requests need to be made to get all the acl. Additionally the acl resolving logic is fairly primitive at the moment and might not work correctly in all setups (it should error to showing the entry) Signed-off-by: Robin Appelman <robin@icewind.nl>	6 years ago
Robin Appelman	9735b5d61f	Add method to storage backends to get directory content with metadata Currently you need to use `opendir` and then call `getMetadata` for every file, which adds overhead because most storage backends already get the metadata when doing the `opendir`. While storagebackends can (and do) use caching to relief this problem, this adds cache invalidation dificulties and only a limited number of items are generally cached (to prevent memory usage exploding when scanning large storages) With this new methods storage backends can use the child metadata they got from listing the folder to return metadata without having to keep seperate caches. Signed-off-by: Robin Appelman <robin@icewind.nl>	6 years ago
Christoph Wurst	caff1023ea	Format control structures, classes, methods and function To continue this formatting madness, here's a tiny patch that adds unified formatting for control structures like if and loops as well as classes, their methods and anonymous functions. This basically forces the constructs to start on the same line. This is not exactly what PSR2 wants, but I think we can have a few exceptions with "our" style. The starting of braces on the same line is pracrically standard for our code. This also removes and empty lines from method/function bodies at the beginning and end. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	14c996d982	Use elseif instead of else if Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	1a9330cd69	Update the license headers for Nextcloud 19 Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Robin Appelman	ef7bb5225a	normalize smb path while listing folder contents currently when listing `'/'`, it will include a double slash in the paths used for the listing logic this causes unneeeded cache misses in the statCache Signed-off-by: Robin Appelman <robin@icewind.nl>	6 years ago
Christoph Wurst	b80ebc9674	Use the short array syntax, everywhere Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	5bf3d1bb38	Update license headers Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Robin Appelman	194edfc64e	add (hidden) option to configure smb timeout hidden from ui to prevent clutter ```occ files_external:config <mount> timeout 30``` Signed-off-by: Robin Appelman <robin@icewind.nl>	6 years ago
Arthur Schiwon	43bc31bacb	set a storage availability delay on auth issues to avoid lock out Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>	6 years ago
Arthur Schiwon	cd62b38cc8	catch auth issues also when php-smbclient is in use Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>	6 years ago
Morris Jobke	adc2ab4bb2	Ignore forbidden exception when fetching share mtime on SMB for symlinks See https://github.com/nextcloud/server/pull/7556#issuecomment-499028026 Signed-off-by: Morris Jobke <hey@morrisjobke.de>	7 years ago
Robin Appelman	6d5579863e	add option to show hidden files in SMB shares Note hidden files can mean different things in smb and the option the the files web ui, the webui only counts files starting with '.' as hidden, while smb files can be marked as hidden regardless, any files that are marked as hidden on smb will thus be shown in the webui regardless of the setting in the files app. Fixes #15644 Signed-off-by: Robin Appelman <robin@icewind.nl>	7 years ago
Robin Appelman	bdc6d0b5a1	log entries that are hidden during file listing Signed-off-by: Robin Appelman <robin@icewind.nl>	8 years ago
Robin Appelman	24aaa3bc97	retry stat on timeout Signed-off-by: Robin Appelman <robin@icewind.nl>	8 years ago
Robin Appelman	27089422e1	Improved logging of smb connection errors Signed-off-by: Robin Appelman <robin@icewind.nl>	8 years ago
Robin Appelman	431710a5aa	also retry rename operation on InvalidArgumentException Signed-off-by: Robin Appelman <robin@icewind.nl>	8 years ago
Robin Appelman	90be8f336c	Add support for using kerberos ticket to authenticate to smb servers Signed-off-by: Robin Appelman <robin@icewind.nl>	8 years ago
Robin Appelman	4a424f86db	update icewind/smb to 3.0.0 Signed-off-by: Robin Appelman <robin@icewind.nl>	8 years ago
Arthur Schiwon	38a90130ce	move log constants to ILogger Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>	8 years ago
Roeland Jago Douma	47a3008141	Remove \OCP\Files::tmpFile Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	8 years ago
Roland Tapken	8e251e5d5a	Make SMB module more fault-tolerant Ignore unavailable files when fetching the share's mtime or reading directory listings. This can happen on servers using a distributed file system (DFS) with unavailable destinations, for example when the remote server is offline. Signed-off-by: Roland Tapken <roland@bitarbeiter.net>	8 years ago
Morris Jobke	9ff51aafc5	Use index based string access for substr with length of 1 Signed-off-by: Morris Jobke <hey@morrisjobke.de>	8 years ago
Robin Appelman	3fa13b48fc	handle exceptions in SMB::stat Signed-off-by: Robin Appelman <robin@icewind.nl>	8 years ago
Robin Appelman	4f0d03e172	additional debug logging on smb copy/rename failures Signed-off-by: Robin Appelman <robin@icewind.nl>	8 years ago
Morris Jobke	0eebff152a	Update license headers Signed-off-by: Morris Jobke <hey@morrisjobke.de>	8 years ago
Joas Schilling	7a62fbd205	Fix comparisons in the files external app Signed-off-by: Joas Schilling <coding@schilljs.com>	9 years ago
Robin Appelman	acb0903514	remove duplicate method Signed-off-by: Robin Appelman <robin@icewind.nl>	9 years ago
Robin Appelman	43970b93d1	remove excessive logging Signed-off-by: Robin Appelman <robin@icewind.nl>	9 years ago

1 2

73 Commits (c9c49bfef8ff39eb052d9bddb796882290467c98)