147 Commits (d9c079937726bfa37a48ef8a2f206741f3fa12e3)

Author	SHA1	Message	Date
szaimen	4191a178dd	improve overwrite cli url setup check ... Signed-off-by: szaimen <szaimen@e.mail.de>	4 years ago
szaimen	7dca146b58	allow to disable the imagick warning ... Signed-off-by: szaimen <szaimen@e.mail.de> Co-Authored-By: MichaIng <micha@dietpi.com>	4 years ago
Julien Veyssier	d5574cf189	allow adding protocol to domains in 'connectivity_check_domains' config ... Signed-off-by: Julien Veyssier <eneiluj@posteo.net>	4 years ago
MichaIng	5ac91f1cb8	Add Nextcloud docs link to OPcache recommends ... A link to the Nextcloud documentation is currently only shown when the OPcache module is not loaded at all. This commit moves the link to the generic text above the individual recommendations list. Additionally remove the obsolete phpOpcacheDocumentation entry from test data arrays, which is not passed anymore by the backend. Signed-off-by: MichaIng <micha@dietpi.com>	4 years ago
Mickey Knox	f63eb4261f	Fix permittedPath comparison ... Signed-off-by: Mickey Knox <mickey@netfreaks.org>	4 years ago
Carl Schwan	7c8a901b84	Cleanup admin settings js files ... * Move admin.js to webpack, so that this use the bundled jquery files instead of the deprecated window.$ Also fixing formatting * Remove log.js that seems to be from a time where logreader was bundled with server and I couldn't find an usage of it anymore * Fix recent regression in rebuild navigation function (now not depending on jquery anymore and bundled by webpack). Signed-off-by: Carl Schwan <carl@carlschwan.eu>	4 years ago
Arthur Schiwon	b28aa52b28	Setup warning for invalid LDAP user or group UUIDs. ... Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>	4 years ago
szaimen	84cf39f582	show if the mail server settings are not set or verified ... Signed-off-by: szaimen <szaimen@e.mail.de>	4 years ago
MichaIng	79cdb565dc	Avoid zero division in setup checks ... Fixes: https://github.com/nextcloud/server/issues/30532 Signed-off-by: MichaIng <micha@dietpi.com>	4 years ago
MichaIng	82c1beaacb	Enhance and complement OPcache setup checks ... The current OPcache recommendations match the PHP defaults, but the values are much higher than required to run Nextcloud, even with a high number of installed apps. On the other hand, when other applications use the same OPcache instance, the recommended values might not be sufficient. Accurate recommendations need to take into account actual OPcache usage. With this commit, recommendations are shown to raise the config value if more than 90% of max cache size or number of keys is used. The checks whether the module is loaded and whether the OPcache is properly configured have been merged into a single function. This allowed to reduce the overhead of OPcache configuration checks when the module is not loaded. A check has been added whether Nextcloud is permitted to use the OPcache API. Without this, inconsistencies during core or app upgrades may cause errors and OPcache usage cannot be determined for the new usage based checks. OPcache usage based checks are skipped when Nextcloud is not permitted to use the API. Signed-off-by: MichaIng <micha@dietpi.com>	4 years ago
Joas Schilling	19d070850b	Make sure trusted_proxies is an array ... Signed-off-by: Joas Schilling <coding@schilljs.com>	4 years ago
Vitor Mattos	e55ceb2bb1	Show warning on admin settings page ... Signed-off-by: Vitor Mattos <vitor@php.rio>	4 years ago
Julien Veyssier	facb50ebcc	fix appstoreenabled check in Fetcher so it's coherent with AppSettingsController ... Signed-off-by: Julien Veyssier <eneiluj@posteo.net>	4 years ago
Christoph Wurst	4b8f8c5203	Deprecate PHP7.3 for Nextcloud 23 ... * 7.3 reaches EOL shortly after the release of 23.0.0 * Nextcloud 24 will require PHP7.4 Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	4 years ago
Bjoern Schiessle	664bd5802f	add 'supported'-label to all supported apps, also if they are not downloaded yet ... Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>	4 years ago
Carl Schwan	6958d8005a	Add admin privilege delegation for admin settings ... This makes it possible for selected groups to access some settings pages. Signed-off-by: Carl Schwan <carl@carlschwan.eu>	4 years ago
Stefan	eb46011680	Issue 16719: CheckSetupController.php: now injecting reference to ITempManager, rather than obtaining using it manually ... Signed-off-by: Stefan <Stefan.Schilling@EXXETA.com>	4 years ago
Stefan	8758b36ebb	Issue 16719: CheckSetupController.php now checks configured temporary directory for existence and if it's writable ... Signed-off-by: Stefan <Stefan.Schilling@EXXETA.com>	4 years ago
Arthur Schiwon	27865d03c0	use specific email getter where necessary ... Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>	4 years ago
Carl Schwan	07ccccecad	Only recommand for php-sodium on >= PHP 7.4 ... This is because php-sodium will solve the missing PASSWORD_ARGON2I constant problem only on >= php 7.4, previously argon2 wasn't part of the standard extension and was disabled on Centos/RHEL. So installing php-sodium on php 7.2 for example wouldn't hide the message. Tested on Fedora with php 7.4, Centos 7 with php 7.2, Centos 8 with php 7.2 and openSUSE with php 7.4. Signed-off-by: Carl Schwan <carl@carlschwan.eu>	4 years ago
Carl Schwan	8e51a5feda	Check that php was compiled with argon2 support or that the php-sodium ... extensions is installed Signed-off-by: Carl Schwan <carl@carlschwan.eu>	4 years ago
Julien Veyssier	416d10f76c	refs #21045 add app config to disable unlimited quota and to set max quota ... avoid unlimited quota as default_quota fallback value if unlimited quota is not allowed avoid getting/setting/displaying unlimited default quota if not allowed implement tests for unlimited quota restrictions Signed-off-by: Julien Veyssier <eneiluj@posteo.net> Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>	4 years ago
Gary Kim	b78f3a57d1	Migrate HintException to OCP ... Signed-off-by: Gary Kim <gary@garykim.dev>	5 years ago
John Molakvoæ (skjnldsv)	215aef3cbd	Update php licenses ... Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	5 years ago
Valdnet	9c6b01abeb	l10n: Spelling unification ... Spelling unification in Transifex. Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>	5 years ago
Arthur Schiwon	847ed37afc	do not use private AccountManager in UsersController ... - extends IAccountProperty for verificationData getters and setters - implementation thereof ^ - and of course adaption of UsersController Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>	5 years ago
Roeland Jago Douma	4a2775a442	Harden apptoken check ... Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	5 years ago
Daniel Calviño Sánchez	67dd087ce4	Fix deleting properties of user settings when not given explicitly ... The controller can receive an optional subset of the properties of the user settings; values not given are set to "null" by default. However, those null values overwrote the previously existing values, so in practice any value not given was deleted from the user settings. Now only non null values overwrite the previous values. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	ac0c18327e	Fix TypeError when "email" is not given in the controller request ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	a7431817b9	Respect additional user settings not covered by the controller ... "AccountManager::updateUser()" wipes previous user data with whichever user data is given (except for some adjustments, like resetting the verified status when needed). As the controller overrode the properties those properties would lose some of their attributes even if they are not affected by the changes made by the controller. Now the controller only modifies the attributes set ("value" and "scope") to prevent that. Note that with this change the controller no longer removes the "verified" status, but this is not a problem because, as mentioned, "AccountManager::updateUser()" resets them when needed (for example, when the value of the website property changes). This change is a previous step to fix overwritting properties with null values, and it will prevent the controller from making unexpected changes if more attributes are added in the future. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	8cae515daa	Use constants from interface rather than class ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Joas Schilling	d80cc76ee7	Validate the website field input to be a valid URL ... Signed-off-by: Joas Schilling <coding@schilljs.com>	5 years ago
Vincent Petry	5d14fd4396	Make extra user profile fields always editable ... The fields for phone number, address, website and twitter are now editable regardless whether federated sharing and the lookup server are enabled or not. Signed-off-by: Vincent Petry <vincent@nextcloud.com>	5 years ago
Joas Schilling	61ed57b757	Rename some parameters and methods to make the API more clear ... Signed-off-by: Joas Schilling <coding@schilljs.com>	5 years ago
Joas Schilling	07095fd122	Also clear the knownUser when changing via the settings endpoint ... Signed-off-by: Joas Schilling <coding@schilljs.com>	5 years ago
Roeland Jago Douma	38f761f25f	Move away some ILoggers ... Makes psalm happier Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	5 years ago
Roeland Jago Douma	3d0dff0d2b	Fix lying docblocks ... * typed the return * removed unneeded temp variable Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	5 years ago
dependabot-preview[bot]	eb502c02ff	Bump nextcloud/coding-standard from 0.3.0 to 0.5.0 ... Bumps [nextcloud/coding-standard](https://github.com/nextcloud/coding-standard) from 0.3.0 to 0.5.0. - [Release notes](https://github.com/nextcloud/coding-standard/releases) - [Changelog](https://github.com/nextcloud/coding-standard/blob/master/CHANGELOG.md) - [Commits](https://github.com/nextcloud/coding-standard/compare/v0.3.0...v0.5.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	5 years ago
Roeland Jago Douma	bd8b1786c5	Some psalm fixes in the settings app ... Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	5 years ago
Roeland Jago Douma	7d8e9baa77	Revert "use the configured forwarded headers for the setup check"	5 years ago
Robin Appelman	01118a2218	use the configured forwarded headers for the setup check ... instead of always checking against the same header Signed-off-by: Robin Appelman <robin@icewind.nl>	5 years ago
Robin Appelman	cc0cc68c8d	dont show trusted proxy warning when the proxy and remote are both localhost ... Signed-off-by: Robin Appelman <robin@icewind.nl>	5 years ago
Christoph Wurst	c1d4f8161b	Migrate internal classes to the OCP db col types ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	5 years ago
Morris Jobke	24d436cb60	Remove unneeded casts that were found by Psalm ... In preparation of the update of Psalm from 4.2.1 to 4.3.1+ (see https://github.com/nextcloud/server/pull/24521) Signed-off-by: Morris Jobke <hey@morrisjobke.de>	5 years ago
Morris Jobke	bffa61fc32	Add setup check to verify that the used DB version is still supported in the next major release ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	5 years ago
Christoph Wurst	8b64e92b92	Bump doctrine/dbal from 2.12.0 to 3.0.0 ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	5 years ago
Christoph Wurst	90d0732828	Fix updating user settings ... The requests dispatched from the personal settings page don't always send all the possible params but just a subset. Hence requests currently fail on master e.g. when you update your email. This makes the arguments optional again. Regression of da9462b482 Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	5 years ago
Christoph Wurst	9ce3ea3368	Update license headers ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	5 years ago
Christoph Wurst	d89a75be0b	Update all license headers for Nextcloud 21 ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	5 years ago
Julius Härtl	8f6c2ec357	Move columns to bigint ... Signed-off-by: Julius Härtl <jus@bitgrid.net>	5 years ago