8158 Commits (e29038414dbf092ef2a8711c6962da660ed2ddf0)

Author	SHA1	Message	Date
Anna Larch	b2c9273e5f	fix(appconfig,userconfig): restore pre-migration fallback for ownCloud migration ... AppConfig and UserConfig unconditionally queried NC-only columns (type, lazy, flags, indexed) that don't exist in ownCloud's database schema, breaking ownCloud → Nextcloud upgrades entirely before the schema migration steps could run. Restore the fallback pattern in both classes: on first loadConfig() call, if a DBException with REASON_INVALID_FIELD_NAME is thrown, set $migrationCompleted = false and retry selecting only the columns present in ownCloud's schema. INSERT and UPDATE statements also omit NC-only columns when $migrationCompleted is false. The catch block also guards against infinite recursion: if $migrationCompleted is already false when the exception fires, the exception is re-thrown instead of triggering another recursive call. Fixes: https://github.com/nextcloud/server/issues/57340 Signed-off-by: Anna Larch <anna@nextcloud.com> AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2 weeks ago
Anna Larch	0bb8081842	test(share20): replace addToAssertionCount checkbox tests in Share20 ManagerTest ... Signed-off-by: Anna Larch <anna@nextcloud.com> AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2 weeks ago
Anna Larch	18c5c0711e	test: remove no-op checkbox assertions ... Replace assertTrue(true), addToAssertionCount(1) and delete-without-assert patterns with meaningful assertions or proper test removal. Signed-off-by: Anna Larch <anna@nextcloud.com> AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2 weeks ago
Anna Larch	2c86e1dccb	test(ci): enforce PHPUnit time limits with sensible timeout values ... PHPUnit's enforceTimeLimit was disabled, meaning the timeoutForSmallTests, timeoutForMediumTests and timeoutForLargeTests config values had no effect. Enable enforcement and set realistic limits: 60s/300s/600s for small/medium/large, with a 300s default for unannotated tests. Also clear disable_functions in the PHP development ini preset across all PHPUnit workflows so pcntl_signal is available — without it the signal handler that drives timeout enforcement cannot be registered. Signed-off-by: Anna Larch <anna@nextcloud.com> AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Anna Larch <anna@nextcloud.com>	2 weeks ago
Micke Nordin	cc9e0ba582	fix(http-sig): make setSignature public and skip third-party-dependent test ... Two CI failures introduced by the test additions in this PR: 1. testEd25519VerifyAcceptedWhenSodiumLoaded calls setSignature() to inject an externally-produced Ed25519 signature (since Algorithm::sign() rejects Ed25519 by design). setSignature was declared protected, so the test couldn't call it from outside the class hierarchy. Make it public — SignedRequest lives in the OC\ private namespace, so this widens internal-only visibility, not the public API surface. 2. testParseKeyRejectsContradictoryAlg expected firebase/php-jwt's JWK::parseKey() to throw on a kty=OKP/crv=Ed25519/alg=ES256 key. The current firebase/php-jwt version does not validate that coherence at parse time, so the test now fails to see any throwable. The actual security check happens at Algorithm::verify() time and is covered by testVerifyEd25519KeyAgainstES256Alg right above it. Skip the parse-time test with a comment pointing at the verify-time coverage. Signed-off-by: Micke Nordin <kano@sunet.se>	2 weeks ago
Micke Nordin	1bad4fe238	fix: Make sodium optional ... This commit switches the default signature algorithm to ecdsa-p256-sha256 instead of Ed25519. This allows us to make sodium optional again, and we only pull it in to use it for verifying incomming signatures. If sodium is not installed, we throw on Ed25519 signatures instead. At least it is easy for most people to make their Nextcloud install fully RFC compliant by installing sodium. I also renamed all the Ed25519 function names to be more precis, using Jwks for the JSON Web Keys, and RFC9421 for the http-signature code, where it is needed to distinguish from draft-cavage signatures. Signed-off-by: Micke Nordin <kano@sunet.se>	2 weeks ago
Micke Nordin	3b5107bc96	feat(http-sig): OCM Ed25519 keys, JWKS endpoint, http-sig capability ... OCM dual-stack integration of RFC 9421 alongside the existing cavage publicKey path: - OCMSignatoryManager: Ed25519 active/pending/retiring slot rotation backed by numbered pool appkeys, getRemoteKey for inbound JWK lookup with per-origin cache + cache-miss refetch, and getLocalEd25519Jwks for the JWKS endpoint. - Rfc9421SignatoryManager: per-call wrapper that swaps in the Ed25519 signatory and toggles `rfc9421.format`. - OCMJwksHandler: serves /.well-known/jwks.json (RFC 7517) when signing is enabled. - OCMDiscoveryService: advertises `http-sig` in capabilities when signing is enabled, and picks the signature scheme on outbound based on the remote's advertised capabilities. - Application.php: register the JWKS well-known handler. Signed-off-by: Micke Nordin <kano@sunet.se>	2 weeks ago
Micke Nordin	0eb927e617	feat(http-sig): RFC 9421 protocol primitives ... Add the RFC 9421 (HTTP Message Signatures) sign/verify path alongside the existing draft-cavage implementation: - Algorithm: sodium for Ed25519, JWT::sign for RSA / ECDSA, ecdsaRawToDer for the ECDSA wire format. JWK parsing via JWK::parseKey. - SignatureBase: RFC 9421 §2.5 base construction for the derived components OCM uses plus plain HTTP fields. - ContentDigest: RFC 9530 helpers used as a covered component. - Rfc9421IncomingSignedRequest / Rfc9421OutgoingSignedRequest: request models. Parsing of Signature-Input / Signature delegates to gapple\\StructuredFields\\Parser. - IJwkResolvingSignatoryManager: capability bit signatory managers advertise to participate in RFC 9421 verification. - OcmProfile: OCM-mandated dictionary label. - SignatureManager: dispatch to RFC 9421 inbound when Signature-Input is present, outbound when rfc9421.format is set. Plus tests for each primitive and a full round-trip across the model. Signed-off-by: Micke Nordin <kano@sunet.se>	2 weeks ago
provokateurin	3ce12c83e1	feat(UserManager): Add getters for avatar URLs ... Signed-off-by: provokateurin <kate@provokateurin.de>	2 weeks ago
provokateurin	bf2043ea6d	test(UserManager): Create manager in setUp ... Signed-off-by: provokateurin <kate@provokateurin.de>	2 weeks ago
Anna Larch	d30f3c491d	test: replace checkbox assertions with DoesNotPerformAssertions (middleware) ... Signed-off-by: Anna Larch <anna@nextcloud.com> AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2 weeks ago
Anna Larch	a9f177e743	test(db): call parent::tearDown() in DB test classes that skipped it ... Eight test classes overrode tearDown() for custom DB cleanup but never called parent::tearDown(). TestCase::tearDown() does three things these tests were silently skipping after every test method: - ILockingProvider::releaseAll() — unreleased locks bleed into subsequent tests and can cause deadlocks or unexpected NotFoundException - Storage::getGlobalCache()->clearCache() — stale filecache entries from share/storage tests cause unrelated ObjectStore tests to receive false from fopen() (fseek() then fails with "Argument must be of type resource") - UserMountCache::flush() — stale mount cache causes share lookups in later tests to fail with ShareNotFound AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Anna Larch <anna@nextcloud.com>	2 weeks ago
Peter Ringelmann	4b1c3fbe3b	fix(settings,oauth2): preserve wipe state across admin deletion paths ... Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>	2 weeks ago
nextcloud-command	fd14234a6a	refactor: Apply rector changes ... Signed-off-by: GitHub <noreply@github.com>	2 weeks ago
Ferdinand Thiessen	05ef64dd34	chore: remove legacy drone CI config ... Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	3 weeks ago
Enjeck C.	53cddbbe8b	feat(occ): make it possible to remove an arbitrary number of users to a group ... Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>	3 weeks ago
Arthur Schiwon	bc157a92cc	feat(occ): make it possible to add an arbitrary number of users to a group ... Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>	3 weeks ago
Josh	c0da34e561	chore: remove `always_populate_raw_post_data` from setUploadLimit .user.ini ... Signed-off-by: Josh <josh.t.richards@gmail.com>	3 weeks ago
Josh	3ee366eb27	chore: remove `always_populate_raw_post_data` from htaccessWithValidModifiedContent ... Signed-off-by: Josh <josh.t.richards@gmail.com>	3 weeks ago
Josh	43c9409991	chore: remove `always_populate_raw_post_data` from setUploadLimit test ... Signed-off-by: Josh <josh.t.richards@gmail.com>	3 weeks ago
Robin Appelman	a472a189bb	fix: handle NAT64 addresses in isLocalAddress ... Signed-off-by: Robin Appelman <robin@icewind.nl>	3 weeks ago
Anna Larch	c4356e1b25	fix(appstore): address review comments on GenericFileException handling ... - Attempt delete before logging the warning, so the warning only fires when we know recovery will succeed - Log an error (not silently return) when delete itself fails - Use catch (\Exception) without variable (PHP 8) - Replace willReturnArgument(1) with explicit willReturn(true) in test - Add blank lines between logical blocks in test for readability Signed-off-by: Anna Larch <anna@nextcloud.com> AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com>	3 weeks ago
Anna Larch	5113b18739	fix(appstore): catch GenericFileException when reading cache file in Fetcher ... When the appstore cache file exists but getContent() throws a GenericFileException (I/O error or OS-level permission failure), explicitly delete the file and recreate it before writing fresh data — mirroring the NotFoundException recovery path. If deletion itself fails, return [] cleanly. Previously, the unhandled exception caused the entire apps settings page to crash. The new test covers both the recovery path and deletion failure. Signed-off-by: Anna Larch <anna@nextcloud.com> AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com>	3 weeks ago
Stephen Cuppett	7aaebddba2	fix(encryption): Resolve IAppConfig lazily to prevent early IDBConnection creation ... Injecting IAppConfig as a constructor parameter into Encryption\Manager (and through it into EncryptionWrapper) caused IDBConnection to be eagerly resolved during OC::init() on PHP <8.4 (no lazy ghost objects). This happened before maintenance:install's Sqlite::initialize() wrote dbname to config.php, so the connection latched onto the default database name ('owncloud') instead of the configured one ('nextcloud'). All migrations then ran against owncloud.db, and the subsequent enable_all.php process opened an empty nextcloud.db — crashing with "no such table: oc_appconfig". Remove IAppConfig from Manager's constructor and Server.php's factory closure. Resolve it lazily via Server::get(IAppConfig::class) inside EncryptionWrapper::wrapStorage(), which is only called after the filesystem is set up, never during bootstrap. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Stephen Cuppett <steve@cuppett.com>	3 weeks ago
Stephen Cuppett	4bea4eadc8	fix(encryption): Inject IAppConfig for encryptHomeStorage value ... Signed-off-by: Stephen Cuppett <steve@cuppett.com>	3 weeks ago
Joas Schilling	36a94070d1	test: Support -dev versions for apps ... Signed-off-by: Joas Schilling <coding@schilljs.com>	4 weeks ago
Ferdinand Thiessen	1c23feae3d	refactor: migrate usage of `OC_App` to AppManager ... Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	4 weeks ago
Ferdinand Thiessen	2b2b9840b8	test(appstore): add test cases for appinfo.xml ... Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	4 weeks ago
Ferdinand Thiessen	e3783b88e6	fix(AppManager): properly type AppInfo type based on XSD ... Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	4 weeks ago
Robin Appelman	c91f8b0e2c	test: adjust tests to unsorted folder listing ... Signed-off-by: Robin Appelman <robin@icewind.nl>	4 weeks ago
Carl Schwan	c5c3525a6e	fix: Allow sanitizeHTML to accept null ... Used like this in many places Signed-off-by: Carl Schwan <carlschwan@kde.org>	4 weeks ago
Carl Schwan	279bface8e	refactor: Delete deprecated code from OC_Util ... Signed-off-by: Carl Schwan <carlschwan@kde.org>	4 weeks ago
Carl Schwan	32bc6f54d3	refactor: Replace old Utils::callRegister with new API ... Signed-off-by: Carl Schwan <carlschwan@kde.org>	4 weeks ago
Benjamin Gaussorgues	9e36754429	fix(snowflake): fix wrong documentation about serverId ... Maximum value of a server ID is 511 (9 bits) and not 1023. Also adjust SetupCheck Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>	4 weeks ago
Stephen Cuppett	cf867ea5fb	fix(encryption): Resolve IAppConfig lazily to prevent early IDBConnection creation ... Injecting IAppConfig as a constructor parameter into Encryption\Manager (and through it into EncryptionWrapper) caused IDBConnection to be eagerly resolved during OC::init() on PHP <8.4 (no lazy ghost objects). This happened before maintenance:install's Sqlite::initialize() wrote dbname to config.php, so the connection latched onto the default database name ('owncloud') instead of the configured one ('nextcloud'). All migrations then ran against owncloud.db, and the subsequent enable_all.php process opened an empty nextcloud.db — crashing with "no such table: oc_appconfig". Remove IAppConfig from Manager's constructor and Server.php's factory closure. Resolve it lazily via Server::get(IAppConfig::class) inside EncryptionWrapper::wrapStorage(), which is only called after the filesystem is set up, never during bootstrap. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Stephen Cuppett <steve@cuppett.com>	4 weeks ago
Stephen Cuppett	817bc5b542	fix(encryption): Inject IAppConfig for encryptHomeStorage value ... Signed-off-by: Stephen Cuppett <steve@cuppett.com>	4 weeks ago
John Molakvoæ (skjnldsv)	c26b1e4b07	fix(s3): add Content-MD5 header for DeleteObjects to fix AWS SDK v3.339.0+ compatibility ... AWS SDK PHP v3.339.0+ introduced a breaking change requiring the Content-MD5 header for DeleteObjects operations. This causes 'MissingContentMD5' errors when using S3-compatible services like MinIO. Add middleware to automatically calculate and inject the Content-MD5 header on all DeleteObjects requests. This is applied universally at the S3ConnectionTrait level, fixing both external storage (AmazonS3) and core ObjectStore (S3) classes. Fixes: https://github.com/aws/aws-sdk-php/issues/3068 Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	4 weeks ago
Côme Chilliet	9680004b58	chore: Remove almost all uses of deprecated IServerContainer in lib/private ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	4 weeks ago
Côme Chilliet	6664f62a6c	fix: Fix debug mode and tests mocking IAppManager ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	4 weeks ago
Côme Chilliet	bdfe8ed77e	fix: Add proper methods in IAppManager for namespace handling ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	4 weeks ago
ernolf	04bd872fd2	style(http-client): use explicit bitmask comparison for CURL_VERSION_BROTLI ... Signed-off-by: ernolf <raphael.gradenwitz@googlemail.com>	4 weeks ago
ernolf	c1cd4de1cd	fix(http-client): detect brotli support via libcurl, not PHP extension ... - Fixes a regression introduced in #55433. Signed-off-by: ernolf <raphael.gradenwitz@googlemail.com>	1 month ago
Robin Appelman	d307557c56	test: adjust tests to unsorted share listing ... Signed-off-by: Robin Appelman <robin@icewind.nl>	1 month ago
Anna Larch	0681ced203	fix(previews): use createParameter/setParameter to reuse query in chunk loop ... AI-Assisted-By: claude-sonnet-4-6 <noreply@anthropic.com> Signed-off-by: Anna Larch <anna@nextcloud.com> AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com>	1 month ago
Ferdinand Thiessen	f6a37dc608	refactor(appstore): split controllers and use proper root ... Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	1 month ago
Ferdinand Thiessen	5b756ad8bc	refactor: split appstore from settings ... Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	1 month ago
Robin Appelman	9f5535d01b	fix: apply quota with writeStream ... Signed-off-by: Robin Appelman <robin@icewind.nl>	1 month ago
Robin Appelman	f3a5bc8c17	fix: block writing empty files with 0 quota ... Signed-off-by: Robin Appelman <robin@icewind.nl>	1 month ago
Stephen Cuppett	c2e2b5704d	fix(tests): Fix encryption test isolation between test runs ... Add global encryption teardown to TestCase base class so encryption state does not leak between test suites regardless of which tests ran earlier. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Stephen Cuppett <steve@cuppett.com>	1 month ago
Josh	268cc5f07e	test(TestCase): '.ocdata' -> '.ncdata' in knownEntries ... Signed-off-by: Josh <josh.t.richards@gmail.com>	1 month ago