38 Commits (e2cfcd992cf6f4bb5f1cdb9070d3d0ea2a1504e2)

Author	SHA1	Message	Date
Lukas Reschke	8f09d5b67c	Update license headers	10 years ago
Lukas Reschke	13e817e901	Throw exception on `getPath` if file does not exist ... Currently the `getPath` methods returned `NULL` in case when a file with the specified ID does not exist. This however mandates that developers are checking for the `NULL` case and if they do not the door for bugs with all kind of impact is widely opened. This is especially harmful if used in context with Views where the final result is limited based on the result of `getPath`, if `getPath` returns `NULL` PHP type juggles this to an empty string resulting in all possible kind of bugs. While one could argue that this is a misusage of the API the fact is that it is very often misused and an exception will trigger an immediate stop of execution as well as log this behaviour and show a pretty error page. I also adjusted some usages where I believe that we need to catch these errors, in most cases this is though simply an error that should hard-fail.	10 years ago
Vincent Petry	ececa90709	Set download cookie on public download	10 years ago
Lukas Reschke	22e724e829	Only intercept exceptions of type "NotFoundException" instead of any Exception ... The sharing backend may throw another exception for example when the activity app encounters a problem. Previously this just triggered a 404 error page and the exception got not logged at all. With this change such exceptions get not intercepted and regularly handled as exceptions so that we have meaningful log data. Also the user will be shown a window informing him that an error happened. Helps to debug cases such as https://github.com/owncloud/core/issues/19465	10 years ago
Morris Jobke	7550bf0917	Disable video preview if previews are disabled	11 years ago
Scrutinizer Auto-Fixer	fdbc21fc6c	Scrutinizer Auto-Fixes ... This commit consists of patches automatically generated for this project on https://scrutinizer-ci.com	11 years ago
Lukas Reschke	071a339593	Remove IDE autocomplete fail ... 🙈 *cough* *cough*	11 years ago
Jenkins for ownCloud	b585d87d9d	Update license headers	11 years ago
Lukas Reschke	5f044ebf1b	Add wrapper for Guzzle	11 years ago
Robin Appelman	d46b7d73e7	when the path doesnt exist show a proper error page	11 years ago
Lukas Reschke	e2453d78c0	Properly catch whether a share is `null` ... Despite it's PHPDoc the function might return `null` which was not properly catched and thus in some situations the share was resolved to the sharing users root directory. To test this perform the following steps: * Share file in owncloud 7 (7.0.4.2) * Delete the parent folder of the shared file * The share stays is in the DB and the share via the sharelink is inaccessible. (which is good) * Upgrade to owncloud 8 (8.0.2) (This step is crucial. The bug is not reproduceable without upgrading from 7 to 8. It seems like the old tokens are handled different than the newer ones) * Optional Step: Logout, Reset Browser Session, etc. * Access the share via the old share url: almost empty page, but there is a dowload button which adds a "/download" to the URL. * Upon clicking, a download.zip is downloaded which contains EVERYTHING from the owncloud directory (of the user who shared the file) * No exception is thrown and no error is logged. This will add a check whether the share is a valid one and also adds unit tests to prevent further regressions in the future. Needs to be backported to ownCloud 8. Adding a proper clean-up of the orphaned shares is out-of-scope and would probably require some kind of FK or so. Fixes https://github.com/owncloud/core/issues/15097	11 years ago
Joas Schilling	47af533183	Move mimetype check from template to controller	11 years ago
Lukas Reschke	48243a2949	Allow iframes from same domain in share view ... This is required because the PDF Viewer itself is embedded using an iframe from the same domain. The default policy is blocking this. Going on further, we have to come up with a solution in the future how to handle previews by applications, one example might be that they call their own endpoint and not the generic share page to allow applications to have full control over how to display previews. Anyways, to test this behaviour use a decent newer browser (such as Chrome 41) and share a PDF file, obviously the PDF viewer needs to be enabled as well. Without this patch publicly shared PDF files should not get previewed and an error is thrown. (if it isn't then your browser is probably not obeying our Content-Security-Policy and you might consider switching to another one ;))	11 years ago
Morris Jobke	06aef4e8b1	Revert "Updating license headers" ... This reverts commit 6a1a4880f0.	11 years ago
Lukas Reschke	5bb0889b30	Remove uneeded assignment ... 'files' is neither used in the controller or the template	11 years ago
Jenkins for ownCloud	6a1a4880f0	Updating license headers	11 years ago
Joas Schilling	0833a6e332	Correctly create activities for public downloads	11 years ago
Bjoern Schiessle	66f0db30b2	use uid provided by setupfs hook to mount server2server shares, otherwise mount will fail for public link shares	11 years ago
Georg Ehrke	374ddbff55	show animated gifs on public sharing page	11 years ago
Robin McCorkell	2b99fc76ec	Cleanup of PHPDoc return types	11 years ago
Bjoern Schiessle	8c48be453e	only send activity if we have a valid path and the file is readable	11 years ago
Robin Appelman	3afcc71764	Make sure the path passed to the activity manager is normalized	11 years ago
Bjoern Schiessle	393deb5961	add activity if public shared file/folder was downloaded	11 years ago
Joas Schilling	2c39aec8cb	Replace deprecated constant with new class constant	11 years ago
Bjoern Schiessle	1d33503487	we no longer need to keep the session open for encryption	11 years ago
Lukas Reschke	8589079590	Close session only if encryption app is not enabled ... Fixes https://github.com/owncloud/core/issues/12389	11 years ago
Lukas Reschke	a6ebb17610	Remove unused variable and make Scrutinizer happy.	11 years ago
Lukas Reschke	f3ab4f3faf	Don't disclose relative directory path for single shared files of user ... The "dir" key is used within the public sharing template to indicate in which directory the user currently is when sharing a directory with subdirectories. This is needed by the JS scripts. However, when not accessing a directory then "dir" was set to the relative path of the file (from the user's home directory), meaning that for every public shared file the sharee can see the path. (For example if you share the file "foo.txt" from "finances/topsecret/" the sharee would still see the path "finances/topsecret/" from the shared HTML template) This is not the excpected behaviour and can be considered a privacy problem, this patch addresses this by setting "dir" to an empty key.	11 years ago
Lukas Reschke	1b85f40cbe	$file only contains the filename and not the absolute path, that means that files in a subdirectory will not get properly resolved and an empty filesize is returned. ... This feature only exists on master.	11 years ago
Lukas Reschke	8595b76df2	Remove phpass and migrate to new Hasher interface ... This PR removes phpass and migrates to the new Hasher interface. Please notice that due to https://github.com/owncloud/core/issues/10671 old hashes are not updated but the hashes are backwards compatible so this shouldn't hurt. Once the sharing classes have a possibility to update the passwords of single shares those methods should be used within the newHash if block.	11 years ago
Vincent Cloutier	fad621140b	Added download size on public sharing	11 years ago
Lukas Reschke	988c85d292	Refactor file sharing public link handling ... fixes download issue introduced by #10755 Conflicts: apps/files_sharing/public.php	11 years ago