77 Commits (edbc1060ce3ceee7500a64f99c9c98f4ecc7934d)

Author	SHA1	Message	Date
Roeland Jago Douma	fe08b5e9d9	We should check for exceptions when trying to get the avatar ... Fixes #22550 * Updated phpdoc of avatatmanager * Add unit test	10 years ago
Lukas Reschke	6c96b3d07f	Throw normal exceptions instead of eating them ... Partially addresses https://github.com/owncloud/core/issues/22550 Replaces https://github.com/owncloud/core/pull/20185	10 years ago
Lukas Reschke	4b90429178	Add note if integrity check is disabled ... Our issue template states that users should post the output of `/index.php/settings/integrity/failed`, at the moment it displays that all passes have been passed if the integrity checker has been disabled. This is however a wrong approach considering that some distributions are gonna package Frankenstein releases and makes it harder for us to detect such issues. Thus if the integrity code checker is disabled (using the config switch) it displays now: `Appcode checker has been disabled. Integrity cannot be verified.` This is not displayed anywhere else in the UI except these URL used for us for debugging purposes.	10 years ago
Arthur Schiwon	ef7846f7bd	fix tests	10 years ago
Vincent Chan	faf48e42b7	Move data protection check to javascript ... fixes #20199	10 years ago
Thomas Müller	aeb89947a2	Introduce IUser::setEMailAddress and add hook mechanism	10 years ago
Robin Appelman	62cf14e448	always allow autoloading encryption in unit test	10 years ago
Robin Appelman	c15cab7ed6	Allow admins to add system wide root certificates	10 years ago
Roeland Jago Douma	a619629ac0	Only try to load avatars in the user list if there is any	10 years ago
Thomas Müller	eebe2b9c23	User IUser::getEMailAddress() all over the place	10 years ago
Morris Jobke	0a6db3ada6	Remove OC_Config from app management template ... * add unit test for this case	10 years ago
Lukas Reschke	4971015544	Add code integrity check ... This PR implements the base foundation of the code signing and integrity check. In this PR implemented is the signing and verification logic, as well as commands to sign single apps or the core repository. Furthermore, there is a basic implementation to display problems with the code integrity on the update screen. Code signing basically happens the following way: - There is a ownCloud Root Certificate authority stored `resources/codesigning/root.crt` (in this PR I also ship the private key which we obviously need to change before a release 😉). This certificate is not intended to be used for signing directly and only is used to sign new certificates. - Using the `integrity:sign-core` and `integrity:sign-app` commands developers can sign either the core release or a single app. The core release needs to be signed with a certificate that has a CN of `core`, apps need to be signed with a certificate that either has a CN of `core` (shipped apps!) or the AppID. - The command generates a signature.json file of the following format: ```json { "hashes": { "/filename.php": "2401fed2eea6f2c1027c482a633e8e25cd46701f811e2d2c10dc213fd95fa60e350bccbbebdccc73a042b1a2799f673fbabadc783284cc288e4f1a1eacb74e3d", "/lib/base.php": "55548cc16b457cd74241990cc9d3b72b6335f2e5f45eee95171da024087d114fcbc2effc3d5818a6d5d55f2ae960ab39fd0414d0c542b72a3b9e08eb21206dd9" }, "certificate": "-----BEGIN CERTIFICATE-----MIIBvTCCASagAwIBAgIUPvawyqJwCwYazcv7iz16TWxfeUMwDQYJKoZIhvcNAQEF\nBQAwIzEhMB8GA1UECgwYb3duQ2xvdWQgQ29kZSBTaWduaW5nIENBMB4XDTE1MTAx\nNDEzMTcxMFoXDTE2MTAxNDEzMTcxMFowEzERMA8GA1UEAwwIY29udGFjdHMwgZ8w\nDQYJKoZIhvcNAQEBBQADgY0AMIGJAoGBANoQesGdCW0L2L+a2xITYipixkScrIpB\nkX5Snu3fs45MscDb61xByjBSlFgR4QI6McoCipPw4SUr28EaExVvgPSvqUjYLGps\nfiv0Cvgquzbx/X3mUcdk9LcFo1uWGtrTfkuXSKX41PnJGTr6RQWGIBd1V52q1qbC\nJKkfzyeMeuQfAgMBAAEwDQYJKoZIhvcNAQEFBQADgYEAvF/KIhRMQ3tYTmgHWsiM\nwDMgIDb7iaHF0fS+/Nvo4PzoTO/trev6tMyjLbJ7hgdCpz/1sNzE11Cibf6V6dsz\njCE9invP368Xv0bTRObRqeSNsGogGl5ceAvR0c9BG+NRIKHcly3At3gLkS2791bC\niG+UxI/MNcWV0uJg9S63LF8=\n-----END CERTIFICATE-----", "signature": "U29tZVNpZ25lZERhdGFFeGFtcGxl" } ``` `hashes` is an array of all files in the folder with their corresponding SHA512 hashes (this is actually quite cheap to calculate), the `certificate` is the certificate used for signing. It has to be issued by the ownCloud Root Authority and it's CN needs to be permitted to perform the required action. The `signature` is then a signature of the `hashes` which can be verified using the `certificate`. Steps to do in other PRs, this is already a quite huge one: - Add nag screen in case the code check fails to ensure that administrators are aware of this. - Add code verification also to OCC upgrade and unify display code more. - Add enforced code verification to apps shipped from the appstore with a level of "official" - Add enfocrced code verification to apps shipped from the appstore that were already signed in a previous release - Add some developer documentation on how devs can request their own certificate - Check when installing ownCloud - Add support for CRLs to allow revoking certificates **Note:** The upgrade checks are only run when the instance has a defined release channel of `stable` (defined in `version.php`). If you want to test this, you need to change the channel thus and then generate the core signature: ``` ➜ master git:(add-integrity-checker) ✗ ./occ integrity:sign-core --privateKey=resources/codesigning/core.key --certificate=resources/codesigning/core.crt Successfully signed "core" ``` Then increase the version and you should see something like the following:  As you can see a failed code check will not prevent the further update. It will instead just be a notice to the admin. In a next step we will add some nag screen. For packaging stable releases this requires the following additional steps as a last action before zipping: 1. Run `./occ integrity:sign-core` once 2. Run `./occ integrity:sign-app` _for each_ app. However, this can be simply automated using a simple foreach on the apps folder.	10 years ago
Roeland Jago Douma	0265bcfdae	Moved changedisplayname to usercontroller ... Killed the old static route to change a users display name and moved it to a properly testable controller.	10 years ago
Vincent Petry	781bca2437	Fix everyone count for subadmins ... Also moved the logic to the UsersController	10 years ago
Lukas Reschke	c6f6a8758b	Drop OC_SubAdmin and replace usages	10 years ago
Joas Schilling	e19c49295a	Use speaking ids	10 years ago
Joas Schilling	a9a6d4c182	Stay on the same category when refreshing the page on the apps list	10 years ago
Roeland Jago Douma	02af4269f2	Fix unit test ... Now that OC_SubAdmin is just a wrapper around OC\SubAdmin some unit tests had to be fixed because they expected different behaviour. Eventually they should move to properly mocked instances of OC\SubAdmin of course	10 years ago
Lukas Reschke	12181aa6de	Don't perform checks for outdated TLS libs when no internet connection ... This change makes the check return a positive result when: - The instance has been configured to not use the internet AND/OR - S2S AND the appstore is disabled	10 years ago
Morris Jobke	b519965408	[admin] check for correct PHP memcached module	10 years ago
Lukas Reschke	36ce254ffd	Move dummy backend to Tests namespace	10 years ago
Morris Jobke	c86cac6a2b	use config.php value instead of version string	11 years ago
Morris Jobke	15da671349	[test] more tests for UserController::setMailAddress ... * fixes #12885	11 years ago
Robin McCorkell	2579999373	Add setup check for reverse proxy header configuration	11 years ago
Bjoern Schiessle	dc5e89e624	also block certificate management in the back-end if external storages are disabled for the user	11 years ago
Roeland Jago Douma	72ba67815e	Display warning in security & setup warnings if php version is EOL	11 years ago
Lukas Reschke	7f6c5e456b	Add unit tests	11 years ago
Lukas Reschke	0d515de13e	Detect old NSS and OpenSSL versions ... This will detect old NSS and OpenSSL versions and show appropriate errors in the admin interface. Fixes https://github.com/owncloud/core/issues/17901	11 years ago
Joas Schilling	171f86ca2e	Only sort by group name when LDAP is involved	11 years ago
Joas Schilling	d3e3a84cae	Move the helpful method to the TestCase class	11 years ago
Lukas Reschke	bc6d17ed74	Add check for availability of /dev/urandom ... Without /dev/urandom being available to read the medium RNG will rely only on the following components on a Linux system: 1. MicroTime: microtime() . memory_get_usage() as seed and then a garbage collected microtime for loop 2. MTRand: chr((mt_rand() ^ mt_rand()) % 256) 3. Rand: chr((rand() ^ rand()) % 256) 4. UniqId: Plain uniqid() An adversary with the possibility to predict the seed used by the PHP process may thus be able to predict future tokens which is an unwanted behaviour. One should note that this behaviour is documented in our documentation to ensure that users get aware of this even without reading our documentation this will add a post setup check to the administrative interface. Thanks to David Black from d1b.org for bringing this again to our attention.	11 years ago
Joas Schilling	d683752b37	Sort user groups by group name and hide the user count	11 years ago
Clark Tomlinson	9727386d8b	fixing test	11 years ago
Joas Schilling	d36d14366b	Add test for setEmailAddress	11 years ago
Lukas Reschke	9bc48451b9	Adjust tests and statuscode	11 years ago
Lukas Reschke	20a6073a9f	Migrate personal certificate handling into AppFramework controllers ... Also added unit-tests and better error-handling	11 years ago
Joas Schilling	81ec1c8a1a	Remove hardcoded link to performance docs	11 years ago
Lukas Reschke	0816cf9142	Add experimental applications switch ... Allows administrators to disable or enabled experimental applications as well as show the trust level.	11 years ago
Lukas Reschke	65202d2a18	Add check for activated local memcache ... Also used the opportunity to refactor it into an AppFramework controller so that we can unit test it. Fixes https://github.com/owncloud/core/issues/14956	11 years ago
Thomas Müller	b5545932e7	use StreamResponse to download the log file - fixes #14268	11 years ago
Lukas Reschke	e32f1582c7	Show more detailed error message	11 years ago
Lukas Reschke	dfd70337d6	Adjust unit test	11 years ago
Lukas Reschke	13486a5ada	Migrate to SwiftMail ... Replaces the OC_Mail and phpmailer with SwiftMail allowing us to mock it properly. Fixes the unit test execution on master on local machines and https://github.com/owncloud/core/issues/12014 Conflicts: 3rdparty lib/private/server.php lib/public/iservercontainer.php tests/lib/mail.php tests/settings/controller/mailsettingscontrollertest.php Conflicts: 3rdparty lib/private/mail.php lib/private/server.php lib/public/iservercontainer.php settings/ajax/lostpassword.php settings/application.php	11 years ago
Lukas Reschke	bbd5f28415	Let users configure security headers in their Webserver ... Doing this in the PHP code is not the right approach for multiple reasons: 1. A bug in the PHP code prevents them from being added to the response. 2. They are only added when something is served via PHP and not in other cases (that makes for example the newest IE UXSS which is not yet patched by Microsoft exploitable on ownCloud) 3. Some headers such as the Strict-Transport-Security might require custom modifications by administrators. This was not possible before and lead to buggy situations. This pull request moves those headers out of the PHP code and adds a security check to the admin settings performed via JS.	11 years ago
Thomas Müller	4910f3e202	fixing unit tests in UsersControllerTest	11 years ago
Lukas Reschke	0f7634eadc	Switch to a factory and add unit tests	11 years ago
Lukas Reschke	7e7dd92f6b	Add unit tests	11 years ago
Lukas Reschke	b9f180e001	Use 403 instead of 200 response ... A forbidden should throw a 403 and this makes it easier for me to do some automated testing.	11 years ago
Morris Jobke	9fbeaf0fd9	Add value if restore of data is possible for a user ... * reason: nice to know before password change in user management * restore is possible: * encryption is disabled * encryption is enabled, admin and user has checked the restore option * if not possible: * highlight users row in red once the admin wants to change the password * show also a little tipsy	11 years ago
Joas Schilling	039397bd31	Use setConfigs() instead of calling setConfig() multiple times	11 years ago