nextcloud-server

Commit Graph

Author	SHA1	Message	Date
Carl Schwan	11cf69d8ba	fix(psalm): Fix static analysis issues in apps/*/tests There are still 1200 more to fix before we can enable static analysis for the tests. Signed-off-by: Carl Schwan <carlschwan@kde.org>	3 months ago
Carl Schwan	cc7655136c	refactor(share): Remove code related to science mesh integration The app was not updated for the past 2 years. Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	5 months ago
Carl Schwan	503a65ddd0	refactor: Run rector Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	5 months ago
Ferdinand Thiessen	d6d6747a73	refactor: apply rector rules for PHPUnit 10 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	6 months ago
nfebe	64016898d5	fix(sharing): Allow reasonable control 4 'Hide download' on fed shares When creating public links from federated shares, users should be able to set the 'Hide download' option independently as long as they are more restrictive than the original share permissions. Previously, the `checkInheritedAttributes` method was ignoring user preferences and always overriding the hideDownload setting based solely on inherited permissions, preventing users from disabling downloads even when the parent share allowed them. This fix implements some sort of inheritance logic: - Users can only be MORE restrictive than parent shares, never LESS restrictive - If parent hides downloads -> child MUST hide downloads (enforced) - If parent allows downloads -> child can CHOOSE to hide or allow downloads - If parent forbids downloads entirely -> child cannot enable downloads Signed-off-by: nfebe <fenn25.fn@gmail.com>	6 months ago
Daniel Kesselberg	83a691709c	refactor: use IEmailValidator.isValid instead of IMailer.validateEmailAddress Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>	7 months ago
Côme Chilliet	f4993de065	fix(tests): Turn data providers into static methods in files_sharing tests Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	7 months ago
Carl Schwan	5835599fa1	chore(rector): Apply current rector config Signed-off-by: Carl Schwan <carl.schwan@nextclound.com>	8 months ago
nfebe	2bb8c72c47	feat(files_sharing): Toggle display for trusted server shares Signed-off-by: nfebe <fenn25.fn@gmail.com>	9 months ago
Ferdinand Thiessen	a18e61a1e5	feat(files_sharing): add config option for extending link-share permissions This allows the admin to control the behavior whether link shares with READ permissions should be extended to also gain SHARE permissions, allowing users (public share receivers) to add the share to their cloud. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	9 months ago
Robin Appelman	aa15f9d16d	chore: run rector Signed-off-by: Robin Appelman <robin@icewind.nl>	10 months ago
Ferdinand Thiessen	5981b7eb51	chore: apply new CSFixer rules Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de> # Conflicts: # apps/settings/lib/SetupChecks/PhpOpcacheSetup.php	10 months ago
Ferdinand Thiessen	9d8c2cd096	test(files_sharing): split `testCanAccessShare` into separate tests and fix for PHPUnit 10 - split the test into individual test cases - fix invalid call to `onConsecutiveCalls` (it was called more than defined values and is deprecated in v10 anyways). Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	11 months ago
Ferdinand Thiessen	3a99b88917	test(files_sharing): adjust mocks of `Talk` classes Classes need to exist to be mocked (reflection), thus unknown classes only can be mocked as `stdClass`. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	11 months ago
Ferdinand Thiessen	7115658327	test(files_sharing): adjust tests for PHPUnit v10 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	11 months ago
Ferdinand Thiessen	4a9dc6c64d	refactor: move tag handling from files handler to files_sharing Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	11 months ago
Côme Chilliet	ed5b7ae161	chore: re-apply current rector configuration to apps folder Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	1 year ago
Ferdinand Thiessen	73dc0f0f19	fix(sharing): Ensure download restrictions are not dropped When a user receives a share with share-permissions but also with download restrictions (hide download or the modern download permission attribute), then re-shares of that share must always also include those restrictions. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	1 year ago
Ferdinand Thiessen	253f4345f1	fix(files_sharing): Respect permissions passed when creating link shares Given: User creates a link or email share with permissions=4 (create only = file drop). Problem: Currently the permissions are automatically extended to permissions = 5 (READ + CREATE). Work around was to create the share and directly update it. Solution: Respect what the user is requesting, create a file drop share. Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de> Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com> Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	1 year ago
provokateurin	beea8854ca	feat(files_sharing): Allow users with share permission to manage shares on IShareOwnerlessMount Signed-off-by: provokateurin <kate@provokateurin.de>	1 year ago
provokateurin	aacb3ddc1e	fix(files_sharing): Cleanup error messages Signed-off-by: provokateurin <kate@provokateurin.de>	2 years ago
provokateurin	381077028a	refactor(apps): Use constructor property promotion when possible Signed-off-by: provokateurin <kate@provokateurin.de>	2 years ago
dependabot[bot]	bb598c8451	chore(deps): Bump nextcloud/coding-standard in /vendor-bin/cs-fixer Bumps [nextcloud/coding-standard](https://github.com/nextcloud/coding-standard) from 1.3.1 to 1.3.2. - [Release notes](https://github.com/nextcloud/coding-standard/releases) - [Changelog](https://github.com/nextcloud/coding-standard/blob/master/CHANGELOG.md) - [Commits](https://github.com/nextcloud/coding-standard/compare/v1.3.1...v1.3.2) --- updated-dependencies: - dependency-name: nextcloud/coding-standard dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: provokateurin <kate@provokateurin.de>	2 years ago
Côme Chilliet	1580c8612b	chore(apps): Apply new rector configuration to autouse classes Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	2 years ago
Côme Chilliet	1a4978c4ea	chore: Apply rector configuration to apps folder Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	2 years ago
provokateurin	9836e9b164	chore(deps): Update nextcloud/coding-standard to v1.3.1 Signed-off-by: provokateurin <kate@provokateurin.de>	2 years ago
Robin Appelman	7661a7e90a	test: fix ShareAPIControllerTest.php Signed-off-by: Robin Appelman <robin@icewind.nl>	2 years ago
Côme Chilliet	801733e523	fix: Remove OCP\Files\Storage interface deprecated since version 9 Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	2 years ago
Christoph Wurst	49dd79eabb	refactor: Add void return type to PHPUnit test methods Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	2 years ago
skjnldsv	bb37954abb	fix(files_sharing): adjust permissions from custom edit and delete check methods Signed-off-by: skjnldsv <skjnldsv@protonmail.com>	2 years ago
Daniel Kesselberg	af6de04e9e	style: update codestyle for coding-standard 1.2.3 Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>	2 years ago
skjnldsv	967b3848e0	fix(files_sharing): phpunit & openapi fixes Signed-off-by: skjnldsv <skjnldsv@protonmail.com>	2 years ago
Andy Scherzinger	1e04619675	chore: Add SPDX header Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>	2 years ago
fenn-cs	9a0913afdc	refactor(shareApiController): use contrusctor property promotion & DI logger Signed-off-by: fenn-cs <fenn25.fn@gmail.com>	2 years ago
Robin Appelman	e7a7b4a401	perf: switch places that always use the first getById result to getFirstNodeById Signed-off-by: Robin Appelman <robin@icewind.nl>	2 years ago
Benjamin Gaussorgues	01983d50d4	feat(share): save date and time for expiration Because of timezones, not saving time can lead to unexpected behaviour when sharing an item sooner than timezone offset Example: sharing a file before 9am when in UTC+9 Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>	2 years ago
John Molakvoæ	4a509dfe8e	fix: phpunit Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>	2 years ago
Vincent Petry	839ddaa354	feat: rename users to account or person Replace translated text in most locations Signed-off-by: Vincent Petry <vincent@nextcloud.com>	2 years ago
Benjamin Gaussorgues	cc3a2c351a	fix(share): use user timezone to parse share expiration date If an user in UTC+1 try to create a share at 00:00, it's day D for him, but D-1 for the server (UTC). This fix aims to apply the correct offset Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>	2 years ago
Joas Schilling	aa5f037af7	chore: apply changes from Nextcloud coding standards 1.1.1 Signed-off-by: Joas Schilling <coding@schilljs.com> Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>	2 years ago
jld3103	c6806684d2	files_sharing: Add OpenAPI spec Signed-off-by: jld3103 <jld3103yt@gmail.com>	3 years ago
John Molakvoæ	f5f142d31b	fix: adjust testing Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>	3 years ago
Michiel de Jong	c0e84cb512	Add SHARE_TYPE_SCIENCEMESH Signed-off-by: Michiel de Jong <michiel@unhosted.org>	3 years ago
Jan-Philipp Litza	a7abe2c35a	Honor permissions of new link share via OCS API The API currently overrides the supplied permissions with "read only" when a file is shared via link. It allows to update the permissions later, however. This keeps the default to "read only" but honors the permissions supplied by API call if any. Signed-off-by: Jan-Philipp Litza <jpl@plutex.de>	3 years ago
Carl Schwan	2f406e5403	More fixes Signed-off-by: Carl Schwan <carl@carlschwan.eu>	4 years ago
Carl Schwan	8e3f21d9ed	Small progress with fixing unit tests Signed-off-by: Carl Schwan <carl@carlschwan.eu>	4 years ago
Carl Schwan	7ded5a769b	Only normalize data in public shares and not crud Signed-off-by: Carl Schwan <carl@carlschwan.eu>	4 years ago
Carl Schwan	7b723813ce	Multiple fixes - Fix tests - Use non deprecated event stuff - Add a bit of type hinting to the new stuff - More safe handling of instanceOfStorage (share might not be the first wrapper) - Fix resharing Signed-off-by: Carl Schwan <carl@carlschwan.eu>	4 years ago
Vincent Petry	03b1791cca	Fix share attribute related tests + code style Signed-off-by: Vincent Petry <vincent@nextcloud.com>	4 years ago
Vincent Petry	a95c19e14b	Add share attributes + prevent download permission Makes it possible to store download permission Signed-off-by: Vincent Petry <vincent@nextcloud.com>	4 years ago

1 2 3

131 Commits (f0517dbdd9c8cedcc4c191564e6bc7ee46ec7523)