nextcloud-server

Commit Graph

Author	SHA1	Message	Date
Lukas Reschke	f3360d51c6	Use PHP polyfills	10 years ago
Scrutinizer Auto-Fixer	ffc49a24f0	Scrutinizer Auto-Fixes This commit consists of patches automatically generated for this project on https://scrutinizer-ci.com	10 years ago
Lukas Reschke	29b6a03fc1	Add assertion to test This seems to be missing on that test.	10 years ago
Lukas Reschke	715b0941ee	Make compatible with PHPUnit 5.1 `addWarning` needs to be defined as well for it: ``` ➜ master git:(master) ✗ bash autotest.sh sqlite Using PHP executable /usr/local/opt/php56/bin/php Parsing all files in lib/public for the presence of @since or @deprecated on each method... Using database oc_autotest Setup environment for sqlite testing on local storage ... Installing .... ownCloud is not installed - only a limited number of commands are available Mac OS X is not supported and ownCloud will not work properly on this platform. Use it at your own risk! -> For the best results, please consider using a GNU/Linux server instead. creating sqlite db ownCloud was successfully installed Testing with sqlite ... No coverage /usr/local/bin/phpunit --configuration phpunit-autotest.xml --log-junit autotest-results-sqlite.xml PHP Notice: Constant PHPUNIT_RUN already defined in /Users/lukasreschke/Documents/Programming/master/apps/firstrunwizard/tests/bootstrap.php on line 6 PHP Stack trace: PHP 1. {main}() /usr/local/Cellar/phpunit/5.1.0/libexec/phpunit-5.1.0.phar:0 PHP 2. PHPUnit_TextUI_Command::main() /usr/local/Cellar/phpunit/5.1.0/libexec/phpunit-5.1.0.phar:514 PHP 3. PHPUnit_TextUI_Command->run() phar:///usr/local/Cellar/phpunit/5.1.0/libexec/phpunit-5.1.0.phar/phpunit/TextUI/Command.php:106 PHP 4. PHPUnit_TextUI_Command->handleArguments() phar:///usr/local/Cellar/phpunit/5.1.0/libexec/phpunit-5.1.0.phar/phpunit/TextUI/Command.php:117 PHP 5. PHPUnit_Util_Configuration->getTestSuiteConfiguration() phar:///usr/local/Cellar/phpunit/5.1.0/libexec/phpunit-5.1.0.phar/phpunit/TextUI/Command.php:663 PHP 6. PHPUnit_Util_Configuration->getTestSuite() phar:///usr/local/Cellar/phpunit/5.1.0/libexec/phpunit-5.1.0.phar/phpunit/Util/Configuration.php:796 PHP 7. PHPUnit_Framework_TestSuite->addTestFile() phar:///usr/local/Cellar/phpunit/5.1.0/libexec/phpunit-5.1.0.phar/phpunit/Util/Configuration.php:926 PHP 8. PHPUnit_Util_Fileloader::checkAndLoad() phar:///usr/local/Cellar/phpunit/5.1.0/libexec/phpunit-5.1.0.phar/phpunit/Framework/TestSuite.php:335 PHP 9. PHPUnit_Util_Fileloader::load() phar:///usr/local/Cellar/phpunit/5.1.0/libexec/phpunit-5.1.0.phar/phpunit/Util/Fileloader.php:38 PHP 10. include_once() phar:///usr/local/Cellar/phpunit/5.1.0/libexec/phpunit-5.1.0.phar/phpunit/Util/Fileloader.php:56 PHP 11. loadDirectory() /Users/lukasreschke/Documents/Programming/master/tests/apps.php:42 PHP 12. require_once() /Users/lukasreschke/Documents/Programming/master/tests/apps.php:20 PHP 13. define() /Users/lukasreschke/Documents/Programming/master/apps/firstrunwizard/tests/bootstrap.php:6 PHP Fatal error: Class StartSessionListener contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (PHPUnit_Framework_TestListener::addWarning) in /Users/lukasreschke/Documents/Programming/master/tests/startsessionlistener.php on line 47 PHP Stack trace: PHP 1. {main}() /usr/local/Cellar/phpunit/5.1.0/libexec/phpunit-5.1.0.phar:0 PHP 2. PHPUnit_TextUI_Command::main() /usr/local/Cellar/phpunit/5.1.0/libexec/phpunit-5.1.0.phar:514 PHP 3. PHPUnit_TextUI_Command->run() phar:///usr/local/Cellar/phpunit/5.1.0/libexec/phpunit-5.1.0.phar/phpunit/TextUI/Command.php:106 PHP 4. PHPUnit_TextUI_TestRunner->doRun() phar:///usr/local/Cellar/phpunit/5.1.0/libexec/phpunit-5.1.0.phar/phpunit/TextUI/Command.php:155 PHP 5. PHPUnit_TextUI_TestRunner->handleConfiguration() phar:///usr/local/Cellar/phpunit/5.1.0/libexec/phpunit-5.1.0.phar/phpunit/TextUI/TestRunner.php:153 PHP 6. require_once() phar:///usr/local/Cellar/phpunit/5.1.0/libexec/phpunit-5.1.0.phar/phpunit/TextUI/TestRunner.php:805 ```	10 years ago
Arthur Schiwon	81d763be42	use expectedException annotation, not via method call, for consistency	10 years ago
Arthur Schiwon	fdd06ba1f8	use getLastInsertId from query builder for convenience	10 years ago
Robin Appelman	e191953942	Remove all locks after ttl from the db	10 years ago
Arthur Schiwon	8e298f51f8	adjust test's fakemanager to interface change	10 years ago
Arthur Schiwon	0c1c029571	hardening, add some checks for whitespace-only strings	10 years ago
Arthur Schiwon	8acbb7aef9	rework test about overwriting default comments manager	10 years ago
Arthur Schiwon	d3692c3283	namespaces for tests	10 years ago
Arthur Schiwon	9a440c06b0	OC not oc	10 years ago
Arthur Schiwon	e3dbc3d40c	different strategy in cleaning up after user was deleted we do not listen to deletion hooks anymore, because there is no guarantee that they will be heard - requires that something fetches the CommentsManager first. Instead, in the user deletion routine the clean up method will be called directly. Same way as it happens for files, group memberships, config values.	10 years ago
Arthur Schiwon	2ce2de0ae5	add icommentsmanger and icomment implementation register CommentsManager service, allow override, document in config.sample.php don't insert autoincrement ids in tests, because of dislikes from oracle and pgsql specify timezone in null date only accepts strings for ID parameter that can be converted to int replace forgotten hardcoded IDs in tests react on deleted users react on file deletion Postgresql compatibility lastInsertId needs PREFIX with the table name do not listen for file deletion, because it is not reliable (trashbin, external storages) add runtime cache for comments	10 years ago
Thomas Müller	bb02488cc2	remove deprecated strict setting	10 years ago
Joas Schilling	5c0be3b565	Fix the last insert id test by changing to an autoincrement table	10 years ago
Vincent Petry	28e9bc1156	Fix more unit tests to pass a mock storage instead of null to FileInfo	10 years ago
Joas Schilling	9f98849306	Add a method to the get "to use" table and column name	10 years ago
Joas Schilling	a3391248e4	Add select distinct to the query builder	10 years ago
Joas Schilling	f2c7acb3c0	Allow getting the last insert id without much hassle	10 years ago
Lukas Reschke	6d3eb7673d	Add unit test for nested arrays	10 years ago
Lukas Reschke	8289943a0f	Do not trust casting	10 years ago
Scrutinizer Auto-Fixer	453e1bf66e	Scrutinizer Auto-Fixes This commit consists of patches automatically generated for this project on https://scrutinizer-ci.com	10 years ago
Joas Schilling	820c3b852d	Add a unit test for single user case as well	10 years ago
Joas Schilling	5b87413792	Allow sending a share email to multiple users	10 years ago
Vincent Petry	316b907a13	Fixed system tags DAV and API and docs	10 years ago
Roeland Jago Douma	a619629ac0	Only try to load avatars in the user list if there is any	10 years ago
Morris Jobke	cbe6eeffa1	last change of OC_Config to the proper interface in tests/	10 years ago
Morris Jobke	542ce7dd0d	Reduce OC_Config usage in tests/	10 years ago
Robin Appelman	19b2fe6a3a	Fix mimetype filter in getDirectoryContent	10 years ago
Morris Jobke	e9c8f82fc5	Replace OC_Config in tests with IConfig calls	10 years ago
Morris Jobke	d331e0d4f8	Replace OC_Config in tests with IConfig calls	10 years ago
Thomas Müller	dcc7ff09ba	Adding unit test for MailNotifications::sendInternalShareMail()	10 years ago
Thomas Müller	eebe2b9c23	User IUser::getEMailAddress() all over the place	10 years ago
Thomas Müller	28ceab2f61	Fix endless recursion	10 years ago
Morris Jobke	0a6db3ada6	Remove OC_Config from app management template * add unit test for this case	10 years ago
Robin Appelman	0062888aaf	Also add metadata for postDelete hooks triggered from the view	10 years ago
Thomas Müller	0391cc0451	Fix getCloudId	10 years ago
Thomas Müller	fe67db1ad0	Adding unit test for User::getCloudId()	10 years ago
Thomas Müller	df6fc6cc70	Add the user's cloud id to the vCard	10 years ago
Thomas Müller	dad6470baa	Add IUser::getAvatarImage() for easy access	10 years ago
Roeland Jago Douma	b00db2c933	DI in avatar code * DI in avatar code * Use the node API * More unit tests * Unit tests no longer require DB	10 years ago
Robin Appelman	62cc316c6a	remove old propagation logic	10 years ago
Lukas Reschke	2515cb17be	Support pretty URLs This changeset allows ownCloud to run with pretty URLs, they will be used if mod_rewrite and mod_env are available. This means basically that the `index.php` in the URL is not shown to the user anymore. Also the not deprecated functions to generate URLs have been modified to support this behaviour, old functions such as `filePath` will still behave as before for compatibility reasons. Examples: http://localhost/owncloud/index.php/s/AIDyKbxiRZWAAjP => http://localhost/owncloud/s/AIDyKbxiRZWAAjP http://localhost/owncloud/index.php/apps/files/ => http://localhost/owncloud/apps/files/ Due to the way our CSS and JS is structured the .htaccess uses some hacks for the final result but could be worse... And I was just annoyed by all that users crying for the removal of `index.php` ;-)	10 years ago
Joas Schilling	08d07cc4db	Fix the unit test by running tearDown() and cleaning tags before the test	10 years ago
Joas Schilling	1d0c041ac8	Add a method to get the list of tags from the TagNotFound Exception	10 years ago
Robin Appelman	0d63e95a5d	Add metadata to post delete hooks	10 years ago
Lukas Reschke	4971015544	Add code integrity check This PR implements the base foundation of the code signing and integrity check. In this PR implemented is the signing and verification logic, as well as commands to sign single apps or the core repository. Furthermore, there is a basic implementation to display problems with the code integrity on the update screen. Code signing basically happens the following way: - There is a ownCloud Root Certificate authority stored `resources/codesigning/root.crt` (in this PR I also ship the private key which we obviously need to change before a release 😉). This certificate is not intended to be used for signing directly and only is used to sign new certificates. - Using the `integrity:sign-core` and `integrity:sign-app` commands developers can sign either the core release or a single app. The core release needs to be signed with a certificate that has a CN of `core`, apps need to be signed with a certificate that either has a CN of `core` (shipped apps!) or the AppID. - The command generates a signature.json file of the following format: ```json { "hashes": { "/filename.php": "2401fed2eea6f2c1027c482a633e8e25cd46701f811e2d2c10dc213fd95fa60e350bccbbebdccc73a042b1a2799f673fbabadc783284cc288e4f1a1eacb74e3d", "/lib/base.php": "55548cc16b457cd74241990cc9d3b72b6335f2e5f45eee95171da024087d114fcbc2effc3d5818a6d5d55f2ae960ab39fd0414d0c542b72a3b9e08eb21206dd9" }, "certificate": "-----BEGIN CERTIFICATE-----MIIBvTCCASagAwIBAgIUPvawyqJwCwYazcv7iz16TWxfeUMwDQYJKoZIhvcNAQEF\nBQAwIzEhMB8GA1UECgwYb3duQ2xvdWQgQ29kZSBTaWduaW5nIENBMB4XDTE1MTAx\nNDEzMTcxMFoXDTE2MTAxNDEzMTcxMFowEzERMA8GA1UEAwwIY29udGFjdHMwgZ8w\nDQYJKoZIhvcNAQEBBQADgY0AMIGJAoGBANoQesGdCW0L2L+a2xITYipixkScrIpB\nkX5Snu3fs45MscDb61xByjBSlFgR4QI6McoCipPw4SUr28EaExVvgPSvqUjYLGps\nfiv0Cvgquzbx/X3mUcdk9LcFo1uWGtrTfkuXSKX41PnJGTr6RQWGIBd1V52q1qbC\nJKkfzyeMeuQfAgMBAAEwDQYJKoZIhvcNAQEFBQADgYEAvF/KIhRMQ3tYTmgHWsiM\nwDMgIDb7iaHF0fS+/Nvo4PzoTO/trev6tMyjLbJ7hgdCpz/1sNzE11Cibf6V6dsz\njCE9invP368Xv0bTRObRqeSNsGogGl5ceAvR0c9BG+NRIKHcly3At3gLkS2791bC\niG+UxI/MNcWV0uJg9S63LF8=\n-----END CERTIFICATE-----", "signature": "U29tZVNpZ25lZERhdGFFeGFtcGxl" } ``` `hashes` is an array of all files in the folder with their corresponding SHA512 hashes (this is actually quite cheap to calculate), the `certificate` is the certificate used for signing. It has to be issued by the ownCloud Root Authority and it's CN needs to be permitted to perform the required action. The `signature` is then a signature of the `hashes` which can be verified using the `certificate`. Steps to do in other PRs, this is already a quite huge one: - Add nag screen in case the code check fails to ensure that administrators are aware of this. - Add code verification also to OCC upgrade and unify display code more. - Add enforced code verification to apps shipped from the appstore with a level of "official" - Add enfocrced code verification to apps shipped from the appstore that were already signed in a previous release - Add some developer documentation on how devs can request their own certificate - Check when installing ownCloud - Add support for CRLs to allow revoking certificates Note: The upgrade checks are only run when the instance has a defined release channel of `stable` (defined in `version.php`). If you want to test this, you need to change the channel thus and then generate the core signature: ``` ➜ master git:(add-integrity-checker) ✗ ./occ integrity:sign-core --privateKey=resources/codesigning/core.key --certificate=resources/codesigning/core.crt Successfully signed "core" ``` Then increase the version and you should see something like the following: ![2015-11-04_12-02-57](https://cloud.githubusercontent.com/assets/878997/10936336/6adb1d14-82ec-11e5-8f06-9a74801c9abf.png) As you can see a failed code check will not prevent the further update. It will instead just be a notice to the admin. In a next step we will add some nag screen. For packaging stable releases this requires the following additional steps as a last action before zipping: 1. Run `./occ integrity:sign-core` once 2. Run `./occ integrity:sign-app` _for each_ app. However, this can be simply automated using a simple foreach on the apps folder.	10 years ago
Joas Schilling	b8b0ae0944	Fix phpstorm complains in tests	10 years ago
Thomas Müller	b94aadc440	Cleanup imports and type hinting	10 years ago

1 2 3 4 5 ...

2647 Commits (f799b27f0e1f1021ddd2baea8f932d05af780596)