nextcloud-server

Commit Graph

Author	SHA1	Message	Date
Git'Fellow	5300f0d693	Switch logical operators (and\|or) Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>	3 years ago
Robin Appelman	bd91c56539	get quota for user only when needed always apply the wrapper but have the wrapper get the quota lazily only when an operation where quota is applied is performed Signed-off-by: Robin Appelman <robin@icewind.nl>	3 years ago
Robin Appelman	1374cbee3e	store unencrypted size in the unencrypted_size column Signed-off-by: Robin Appelman <robin@icewind.nl>	3 years ago
Robin Appelman	5e375d9092	Revert "store unencrypted size in the unencrypted_size column" This reverts commit `8238582e59`. Signed-off-by: Robin Appelman <robin@icewind.nl>	3 years ago
Carl Schwan	d5c23dbb9f	Move CappedMemoryCache to OCP This is an helpful helper that should be used in more place than just server and this is already the case with groupfodlers, deck, user_oidc and more using it, so let's make it public Signed-off-by: Carl Schwan <carl@carlschwan.eu>	4 years ago
Robin Appelman	8238582e59	store unencrypted size in the unencrypted_size column Signed-off-by: Robin Appelman <robin@icewind.nl>	4 years ago
Côme Chilliet	e8c1f75064	Fixing psalm errors Encryption constructor is problematic and should still be fixed later. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	4 years ago
Côme Chilliet	6be7aa112f	Migrate from ILogger to LoggerInterface in lib/private Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	4 years ago
Carl Schwan	cbf9064b8e	Fix psalm issues Signed-off-by: Carl Schwan <carl@carlschwan.eu>	4 years ago
Carl Schwan	695165260f	Add helper method in Wrapper Signed-off-by: Carl Schwan <carl@carlschwan.eu>	4 years ago
Jonas Meurer	a2f4c62c19	updateEncryptedVersion: cleanup on target if cache already got renamed When moving a file to trash with encryption enabled, the cache gets moved before the actual file. According to @icewind1991 this is in order to not break object storage. When moving a file from an unencrypted storage (e.g. a collectives storage) to the encrypted trashbin storage, this causes errors, see This commit fixes it by doing `updateEncryptedVersion()` on the target cache entry if the source cache entry doesn't exist anymore, but the corresponding target cache entry does exist already. Fixes: #26544 Signed-off-by: Jonas Meurer <jonas@freesources.org>	4 years ago
Vincent Petry	be590df588	Fix fail when keys/files folder already exists Fixes an issue with transfer ownership in move mode where the folder "files_encryption/keys/files" already exists. Instead of failing, its existence is checked before calling mkdir. Signed-off-by: Vincent Petry <vincent@nextcloud.com>	4 years ago
Vincent Petry	6f81e60bce	Check resource before closing in encryption wrapper In case of error there is no guarantee that $source or $target is set or is a resource when handling an error. Without this fix, there's a risk that fclose will fail and the actual exception will not be thrown, making it impossible to find out about the root cause. Signed-off-by: Vincent Petry <vincent@nextcloud.com>	4 years ago
Vincent Petry	c92a0e4152	Normalize directory entries in Encoding wrapper Directory entry file names are now normalized in getMetaData(), getDirectoryContents() and opendir(). This makes the scanner work properly as it assumes pre-normalized names. In case the names were not normalized, the scanner will now skip the entries and display a warning when applicable. Signed-off-by: Vincent Petry <vincent@nextcloud.com>	4 years ago
Vincent Petry	93fb33d863	Update lib/private/Files/Storage/Wrapper/Availability.php add void Signed-off-by: Vincent Petry <vincent@nextcloud.com> Co-authored-by: Carl Schwan <carl@carlschwan.eu>	4 years ago
Vincent Petry	db29fd29ee	Return false in hasUpdated when storage is not available Technically, saying that a storage has no updates when it's not available is correct. This makes it possible to retrieve the cache entry for the mount point and also to list and remove unavailable federated shares. Signed-off-by: Vincent Petry <vincent@nextcloud.com>	4 years ago
alanmeeson	16f70e8647	Add type hint to fread_block $blockSize param & apply cs:fix. Signed-off-by: alanmeeson <alan@carefullycalculated.co.uk>	4 years ago
Alan Meeson	44c332a46e	Fix truncation of files upon read when using object store and encryption. When using and object store as primary storage and using the default encryption module at the same time, any encrypted file would be truncated when read, and a text error message added to the end. This was caused by a combination of the reliance of the read functions on on knowing the unencrypted file size, and a bug in the function which calculated the unencrypted file size for a given file. In order to calculate the unencrypted file size, the function would first skip the header block, then use fseek to skip to the last encrypted block in the file. Because there was a corresponence between the encrypted and unencrypted blocks, this would also be the last encrypted block. It would then read the final block and decrypt it to get the unencrypted length of the last block. With that, the number of blocks, and the unencrypted block size, it could calculate the unencrypted file size. The trouble was that when using an object store, an fread call doesn't always get you the number of bytes you asked for, even if they are available. To resolve this I adapted the stream_read_block function from lib/private/Files/Streams/Encryption.php to work here. This function wraps the fread call in a loop and repeats until it has the entire set of bytes that were requested, or there are no more to get. This fixes the imediate bug, and should (with luck) allow people to get their encrypted files out of Nextcloud now. (The problem was purely on the decryption side). In the future it would be nice to do some refactoring here. I have tested this with image files ranging from 1kb to 10mb using Nextcloud version 22.1.0 (the nextcloud:22.1-apache docker image), with sqlite and a Linode object store as the primary storage. Signed-off-by: Alan Meeson <alan@carefullycalculated.co.uk>	4 years ago
Daniel Kesselberg	be3f4edf1f	explicitly close source stream on encryption storage Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>	4 years ago
acsfer	9324a74bba	Handle files with is_file instead of file_exists Should fix things like `fread(): read of 8192 bytes failed with errno=21 Is a directory`	4 years ago
John Molakvoæ (skjnldsv)	215aef3cbd	Update php licenses Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	5 years ago
Robin Appelman	7995c6e1dc	dont return private storage interface from public mount interface Signed-off-by: Robin Appelman <robin@icewind.nl>	5 years ago
Robin Appelman	c87b1a50d9	apply object store copy optimization when 'cross storage' copy is within the same object store Signed-off-by: Robin Appelman <robin@icewind.nl>	5 years ago
Robin Appelman	b844293536	catch notfound and forbidden exception in smb::getmetadata Signed-off-by: Robin Appelman <robin@icewind.nl>	5 years ago
dependabot-preview[bot]	eb502c02ff	Bump nextcloud/coding-standard from 0.3.0 to 0.5.0 Bumps [nextcloud/coding-standard](https://github.com/nextcloud/coding-standard) from 0.3.0 to 0.5.0. - [Release notes](https://github.com/nextcloud/coding-standard/releases) - [Changelog](https://github.com/nextcloud/coding-standard/blob/master/CHANGELOG.md) - [Commits](https://github.com/nextcloud/coding-standard/compare/v0.3.0...v0.5.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	5 years ago
Jasper Knockaert	40fde94b4d	fix even more brackets Signed-off-by: Jasper Knockaert jasper@knockaert.nl	5 years ago
Jasper Knockaert	252d1ae512	fix brakcets	5 years ago
Jasper Knockaert	f9a0380eb1	consolidation of boolean expression	5 years ago
Morris Jobke	24d436cb60	Remove unneeded casts that were found by Psalm In preparation of the update of Psalm from 4.2.1 to 4.3.1+ (see https://github.com/nextcloud/server/pull/24521) Signed-off-by: Morris Jobke <hey@morrisjobke.de>	5 years ago
Jasper Knockaert	81e3ae4753	avoid fread on directories and unencrypted files Reworking the logic in order to first check the filecache and only then reading the fileheader. This in order to solve #21578.	5 years ago
Christoph Wurst	9ce3ea3368	Update license headers Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	5 years ago
Christoph Wurst	73c7d0dc81	Bump icewind/streams from 0.7.1 to 0.7.2 Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	5 years ago
Tigran Mkrtchyan	4f2dc18f58	storage: update IStorage#file_put_contents docs to match usage The current phpdoc of IStorage#file_put_contents doesnt corresponds to it's actual usage in code, e.g. Signed-off-by: Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>	5 years ago
Christoph Wurst	d89a75be0b	Update all license headers for Nextcloud 21 Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	5 years ago
John Molakvoæ (skjnldsv)	6a453ac184	Make sure root storage is valid before checking its size Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	5 years ago
J0WI	68ce17e59b	Unify links to php.net Update all links to https://www.php.net/ Signed-off-by: J0WI <J0WI@users.noreply.github.com>	5 years ago
Morris Jobke	063ac9d353	Do not fetch the normalized full path again if it is already available Signed-off-by: Morris Jobke <hey@morrisjobke.de>	5 years ago
Julius Härtl	87e5fd0d2c	Check if quota should be applied to path when creating directories This fixes an issue where the files_trashbin hierarchy of a user could not been created as the mkdir operations were blocked by the quota storage wrapper. Even with 0 quota, users should be able to have a trashbin for external storages. Signed-off-by: Julius Härtl <jus@bitgrid.net>	5 years ago
Robin Appelman	2879472f81	trim slashes Signed-off-by: Robin Appelman <robin@icewind.nl>	5 years ago
Julius Härtl	7512dc2b34	Set proper root path for single file shares originating from other storages Co-authored-by: Christoph Wurst <christoph@winzerhof-wurst.at> Signed-off-by: Julius Härtl <jus@bitgrid.net> Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	5 years ago
Roeland Jago Douma	2bbb848c31	Add legacy scanning command Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	5 years ago
Robin Appelman	35d75dbb38	relax permissions mask check for detecting part file rename with files drop uploads the original file name isn't always used for the '.ocTransferId' source path Signed-off-by: Robin Appelman <robin@icewind.nl>	6 years ago
Robin Appelman	4e6d3d1880	Fix getDirectoryContent implementation for Jail wrapper Signed-off-by: Robin Appelman <robin@icewind.nl>	6 years ago
Christoph Wurst	cb057829f7	Update license headers for 19 Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Robin Appelman	9735b5d61f	Add method to storage backends to get directory content with metadata Currently you need to use `opendir` and then call `getMetadata` for every file, which adds overhead because most storage backends already get the metadata when doing the `opendir`. While storagebackends can (and do) use caching to relief this problem, this adds cache invalidation dificulties and only a limited number of items are generally cached (to prevent memory usage exploding when scanning large storages) With this new methods storage backends can use the child metadata they got from listing the folder to return metadata without having to keep seperate caches. Signed-off-by: Robin Appelman <robin@icewind.nl>	6 years ago
Christoph Wurst	28f8eb5dba	Add visibility to all constants Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	caff1023ea	Format control structures, classes, methods and function To continue this formatting madness, here's a tiny patch that adds unified formatting for control structures like if and loops as well as classes, their methods and anonymous functions. This basically forces the constructs to start on the same line. This is not exactly what PSR2 wants, but I think we can have a few exceptions with "our" style. The starting of braces on the same line is pracrically standard for our code. This also removes and empty lines from method/function bodies at the beginning and end. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	14c996d982	Use elseif instead of else if Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	1a9330cd69	Update the license headers for Nextcloud 19 Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	b80ebc9674	Use the short array syntax, everywhere Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago

1 2 3

110 Commits (ff4c8e9beea6c66b016f2fa59569d4e7cdeb921d)