95 Commits (ffbbdb2d04c900bcc4ed6bbcf97d4e5fc30dfad9)

Author	SHA1	Message	Date
Marcel Müller	34a085d3bf	fix(cache): Ensure unique global prefix per instanceid ... Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>	3 months ago
Ferdinand Thiessen	660f3f6fd1	refactor: use logical `&&` `||` instead of weak `and` `or` operators ... Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	3 months ago
Ferdinand Thiessen	112178d3a0	fix: typos in cache and app config ... Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	5 months ago
Ferdinand Thiessen	0ef58c96ab	refactor(Memcache\Factory): move prefix generation to the factory class ... This removes a circular dependency between AppConfig and cache factory. When a cache in the app config is used. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	5 months ago
Ferdinand Thiessen	5981b7eb51	chore: apply new CSFixer rules ... Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de> # Conflicts: # apps/settings/lib/SetupChecks/PhpOpcacheSetup.php	6 months ago
provokateurin	9836e9b164	chore(deps): Update nextcloud/coding-standard to v1.3.1 ... Signed-off-by: provokateurin <kate@provokateurin.de>	1 year ago
Robin Appelman	da59fd4389	fix: misc code fixes around db sharding ... Signed-off-by: Robin Appelman <robin@icewind.nl>	1 year ago
Robin Appelman	c58bdbf378	fix: delay calculating global cache prefix untill a cache is created ... Signed-off-by: Robin Appelman <robin@icewind.nl>	1 year ago
Daniel Kesselberg	af6de04e9e	style: update codestyle for coding-standard 1.2.3 ... Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>	1 year ago
Robin Appelman	20dbb6c7e8	feat: add negative compare-and-delete to imemcache ... Signed-off-by: Robin Appelman <robin@icewind.nl>	1 year ago
Robin Appelman	cae0a8218d	chore: remove Redis::DEFAULT_TTL constant now that it's defined in the interface ... Signed-off-by: Robin Appelman <robin@icewind.nl>	1 year ago
Robin Appelman	b19652a2ad	chore: cleanup acpu inc and dec ... Signed-off-by: Robin Appelman <robin@icewind.nl>	1 year ago
Robin Appelman	cd9cc01b77	fix: set default TTL for APCu cache as per docs ... Signed-off-by: Robin Appelman <robin@icewind.nl>	1 year ago
MichaIng	89cd3b4f88	feat(cache): CLI should not fail if APCu is not available ... but fallback to NullCache. This can be the case if APCu is used without apc.enable_cli=1. APCu however runs within the PHP instance and hence cannot be shared between CLI and web or used as distributed cache. The CLI call can hence only create or invalidate entries for itself. For short-living CLI calls, this is theoretically a downsides regarding performance and resource usage, and Nextcloud must not have any issues using the dummy NullCache instead of an isolated freshly created and destroyed APCu instance. This partly reverts https://github.com/nextcloud/server/pull/25770. The fallback was removed, because CLI calls started to hang after https://github.com/nextcloud/server/pull/25440. The reason however was not that a cache is generally required for CLI calls, but because the previously logged warning invoked the user backend, which invoked again the caching backend, causing a loop. This commit re-adds the fallback without logging a warning, and for APCu only. For mentioned reasons, it is okay to fallback to NullCache silently. If Redis or memcached are configured but not available, then the web UI would fail as well, and it makes sense to abort and inform CLI calls as well then. The motivation is to make apc.enable_cli=1 optional, and that hence the documentation about it can be removed. We should not enforce admins to enable APCu for CLI calls, which is reasonably disabled by default. This also reduces requirements for hosting providers to support Nextcloud. Signed-off-by: MichaIng <micha@dietpi.com>	1 year ago
Andy Scherzinger	dae7c159f7	chore: Add SPDX header ... Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>	2 years ago
Velwark	535d5de037	Update LoggerWrapperCache.php ... Extra Dollar Sign caused errors in Nextcloud. Removing the Dollar Sign Solved the Problem. Signed-off-by: Velwark <levinfrerich9@gmail.com>	2 years ago
Côme Chilliet	ec5133b739	fix: Apply new coding standard to all files ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	2 years ago
Andrew Summers	c0f12d7691	Refactor `OC\Server::getGetRedisFactory` ... Signed-off-by: Andrew Summers <18727110+summersab@users.noreply.github.com>	2 years ago
Robin Appelman	cc3c7c24a1	set a default and max ttl for redis keys ... having infinite TTL can lead to leaked keys as the prefix changes with version upgrades Signed-off-by: Robin Appelman <robin@icewind.nl>	2 years ago
Côme Chilliet	f73f966c98	chore: Add missing ArrayAccess template parameters ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	2 years ago
Robin Appelman	ff62154a79	adjust redis compareSetTTL to use a lua script ... Signed-off-by: Robin Appelman <robin@icewind.nl>	2 years ago
Robin Appelman	7394645eb7	restore shared lock ttl when releasing ... Signed-off-by: Robin Appelman <robin@icewind.nl>	2 years ago
Joas Schilling	aa5f037af7	chore: apply changes from Nextcloud coding standards 1.1.1 ... Signed-off-by: Joas Schilling <coding@schilljs.com> Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>	2 years ago
Christoph Wurst	ff672b11e2	feat: Add factory method for in-memory caches ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	2 years ago
Christoph Wurst	fac05bce07	chore: Drop unused \OC\Memcache\Factory::createLowLatency ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	2 years ago
Joas Schilling	93f0399a92	fix(memcache): Fix comparison of Memcache configs to classes ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2 years ago
Daniel Kesselberg	7cab58237d	chore: remove version check for apc extension ... APC is gone since PHP 7.0. Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>	2 years ago
Faraz Samapoor	e7cc7653b8	Refactors "strpos" calls in lib/private to improve code readability. ... Signed-off-by: Faraz Samapoor <fsamapoor@gmail.com>	3 years ago
Varun Patil	c6cee282b3	redis: move lua scripts to class and add type hints ... Signed-off-by: Varun Patil <varunpatil@ucla.edu>	3 years ago
Varun Patil	39e805fffa	redis: use atomic operations everywhere ... This removes a lot of acrobatics in the code and does each operation atomically using a lua script. This also reduces several round trips to the server, and the scripts are compiled and cached server-side. Notably, since all operations work only on a single key (except clear, which is broken anyway and shouldn't be used), they will continue to function and be atomic for Redis cluster. Signed-off-by: Varun Patil <varunpatil@ucla.edu>	3 years ago
Git'Fellow	c81ea3aa98	Fix RedisCluster ... Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>	3 years ago
Git'Fellow	fab390f884	Move from DEL to UNLINK ... Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>	3 years ago
Robin Appelman	853ec60f3e	also cache backend for user in memory instead of always going to redis ... Signed-off-by: Robin Appelman <robin@icewind.nl>	3 years ago
Côme Chilliet	f5c361cf44	composer run cs:fix ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 years ago
Julius Härtl	023b80e617	Only setup redis connection if needed ... Signed-off-by: Julius Härtl <jus@bitgrid.net>	3 years ago
Côme Chilliet	826e234ecf	Correctly handle Redis::keys returning false ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 years ago
Arthur Schiwon	90104bc1c4	memcached should not throw arbitrary exceptions ... Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>	4 years ago
Carl Schwan	3f97bcdc75	Enable binary protocol again ... Signed-off-by: Carl Schwan <carl@carlschwan.eu>	4 years ago
Carl Schwan	ba88187649	Add hit information to profiler ... This might be helpful later on for the cache ui that is worked on in https://github.com/nextcloud/profiler/pull/21 Signed-off-by: Carl Schwan <carl@carlschwan.eu>	4 years ago
Carl Schwan	7d272c54d0	Add a built-in profiler inside Nextcloud ... The webui is provided by a seperate application named profiler Signed-off-by: Carl Schwan <carl@carlschwan.eu>	4 years ago
Côme Chilliet	6be7aa112f	Migrate from ILogger to LoggerInterface in lib/private ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	4 years ago
Carl Schwan	e3a12b3482	Fix psalm issues in theming app ... After this change, we are down to only one psalm warning for this app and related to the Application.php. This also make composer psam:update-baseline not silently ignore new errors. Signed-off-by: Carl Schwan <carl@carlschwan.eu>	4 years ago
Côme Chilliet	36d7c73e69	Always call flush() as getAllKeys() is broken ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	4 years ago
Carl Schwan	6312c0df69	Check style update ... Signed-off-by: Carl Schwan <carl@carlschwan.eu>	4 years ago
Carl Schwan	aeecb72e96	Fix a few psalm issues and moved back to psalm/phar 4.18 ... Signed-off-by: Carl Schwan <carl@carlschwan.eu>	4 years ago
Carl Schwan	52760a95d9	Check if directoy is writable instead of possibly missing file ... Signed-off-by: Carl Schwan <carl@carlschwan.eu>	4 years ago
Joas Schilling	168c673755	Allow to log DB, redis and LDAP requests into files ... Signed-off-by: Joas Schilling <coding@schilljs.com>	4 years ago
Côme Chilliet	113756db30	Fix ArrayAccess and JsonSerializable return types ... First round of modifications for PHP 8.1 Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	4 years ago
MichaIng	0304eea58d	Fix in locking cache check ... The intention obviously was to check whether $lockingCacheClass is defined, and existing class, and available. It was however checked whether the $distributedCacheClass is an existing class, which would have caused an exception already in the previous distributed cache check. Signed-off-by: MichaIng <micha@dietpi.com>	5 years ago
Gary Kim	b78f3a57d1	Migrate HintException to OCP ... Signed-off-by: Gary Kim <gary@garykim.dev>	5 years ago