nextcloud-server

History

Ferdinand Thiessen 7def18bb43 perf(files_external): pipeline SFTP stream writes SFTPWriteStream sent a single SSH_FXP_WRITE packet and then blocked on its acknowledgement before sending the next one. That made every write a full round trip, and on low-latency links it additionally triggered a write-then-read (Nagle / delayed-ACK) stall, capping throughput at ~2 MB/s. Mirror phpseclib's SFTP::put() instead: send WRITE packets sized to the negotiated maximum without waiting for each acknowledgement, and drain the acknowledgements in batches (at NET_SFTP_UPLOAD_QUEUE_SIZE, and on flush / close). Throughput becomes bandwidth-bound instead of round-trip-bound. This also fixes a latent issue where the entire flush buffer was sent as a single SSH_FXP_WRITE that could exceed the negotiated maximum packet size. Write throughput, 8 KiB stream chunks, OpenSSH sftp-server (indicative, custom read stream and reads are unchanged as they were already pipelined): \| delay \| file size \| before (sync) \| after (pipelined) \| phpseclib sftp:// \| --------\|-----------\|---------------\|-------------------\|-------------------\| \| LAN \| 1 MB \| 1.8 MB/s \| 307 MB/s \| 28 MB/s \| \| LAN \| 8 MB \| 1.9 MB/s \| 332 MB/s \| 38 MB/s \| \| LAN \| 32 MB \| 1.9 MB/s \| 337 MB/s \| 37 MB/s \| \| ~20ms \| 1 MB \| 1.3 MB/s \| 6.3 MB/s \| 0.24 MB/s \| \| ~20ms \| 8 MB \| 1.7 MB/s \| 20.8 MB/s \| 0.24 MB/s \| Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>		1 month ago
..
Amazons3MultiPartTest.php	chore: Apply new coding standard to all files	3 months ago
Amazons3Test.php	fix(AmazonS3#getMetaData): preserve storage_mtime after parent clobbers it	1 month ago
ConfigurableStorageTrait.php	fix: Fix PHP warnings about including non-existing config files	11 months ago
FtpTest.php	chore: Apply new coding standard to all files	3 months ago
OwncloudTest.php	chore: Apply new coding standard to all files	3 months ago
SFTPWriteStreamTest.php	perf(files_external): pipeline SFTP stream writes	1 month ago
SftpTest.php	chore: Apply new coding standard to all files	3 months ago
SmbTest.php	chore: Apply new coding standard to all files	3 months ago
SwiftTest.php	chore: Apply new coding standard to all files	3 months ago
VersionedAmazonS3Test.php	fix(psalm): Fix static analysis issues in apps/*/tests	7 months ago
WebdavTest.php	chore: Apply new coding standard to all files	3 months ago