You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Daniel Calviño Sánchez b70b38ce31 Fix constructor spy in unit test with Sinon 4.1.3 ... When a constructor is spied using Sinon it is wrapped by a proxy function, which calls the original constructor when invoked. When "new Foo()" is executed a "Foo" object is created, "Foo" is invoked with the object as "this", and the object is returned as the result of the whole "new" expression. Before Sinon 4.1.3 the proxy called the original constructor directly using the "thisValue" of the spied call; "thisValue" was the object created by the "new" operator that called the proxy. The proxy assigned "thisValue" to "returnValue", so it was also the value returned by the proxy and, in turn, the value returned by the whole "new" expression. Since Sinon 4.1.3 (see pull request 1626) the proxy calls the original constructor using "new" instead of directly. The "thisValue" created by the outermost "new" (the one that called the proxy) is no longer used by the original constructor; the internal "new" creates a new object, which is the one passed to the original constructor and returned by the internal "new" expression. This object is also the value returned by the proxy ("returnValue") and, in turn, the value returned by the whole outermost "new" expression. Thus, now "returnValue" should be used instead of "thisValue" to get the object created by the spied constructor. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>		8 years ago
..
appSpec.js	Added unit tests for right sidebar	11 years ago
fileDropSpec.js	deleted forgotten code in test	9 years ago
publicAppSpec.js	Fix public link download button	9 years ago
shareSpec.js	Fix constructor spy in unit test with Sinon 4.1.3	8 years ago
sharedbreadcrumviewSpec.js	Fix AdBlock blocking share icon, ref #866	9 years ago
sharedfilelistSpec.js	rip out obsolete recipientsDisplayName	8 years ago