You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Christian Heimlich c4014586bd fix(files_external/SMB): Use 'null' explicitly for no workgroup ... Robin Appleman's SMB library is designed so that 'null' is to be used when no explicit workgroup is set: final class BasicAuth implements IAuth { /** @var string */ private $username; /** @var string|null */ private $workgroup; /** @var string */ private $password; //... However, it previously was loose with its checks and would still treat any falsy value (e.g. an empty string) as "not specified" when forming arguments for the various underlying utilities, such as `smbclient`. icewind/SMB@4a93467905 updated it's handling to be more strict and as such will now treat empty strings as distinct from null values for workgroups. An empty value for workgroup often doesn't make sense, unless the backend tool happens to convert it to "WORKGROUP". In the case of the `smbclient` utility, passing an empty string for the $workgroup paramters results in `-W ''` being used which is invalid syntax and so the invocation fails resulting in the user seeing an `[Icewind\SMB\Exception\ConnectionRefusedException]` error. Therefore, it is important to always pass 'null' to this constructor for $workgroup when there isn't one. Most paths in the 'files_external' app already handle this correctly, but this now altered path originally just took the raw value from the app backend and passed it as-is. Assuming the user left the "Domain" box empty in the frontend, this would be an empty string. Now the the SMB library's interface is correctly honored in that case. It's arguable that the SMB library should simply be updated to formally accept '' as a valid input meaning "no workgroup", restoring the old behavior in a canonical fashion, as there is almost no situation where one would want to pass an empty string and have it mean anything else; but regardless, there is no harm in being more explicit on the nextcloud/server side as well. Fixes #58445. Signed-off-by: Christian Heimlich <chris@pcserenity.com>		1 month ago
..
AmazonS3.php	chore: Apply new coding standard to all files	3 months ago
Backend.php	chore: Apply new coding standard to all files	3 months ago
DAV.php	chore: Apply new coding standard to all files	3 months ago
FTP.php	chore: Apply new coding standard to all files	3 months ago
InvalidBackend.php	chore: Apply new coding standard to all files	3 months ago
LegacyBackend.php	chore: Apply new coding standard to all files	3 months ago
Local.php	chore: Apply new coding standard to all files	3 months ago
OwnCloud.php	chore: Apply new coding standard to all files	3 months ago
SFTP.php	chore: Apply new coding standard to all files	3 months ago
SFTP_Key.php	chore: Apply new coding standard to all files	3 months ago
SMB.php	fix(files_external/SMB): Use 'null' explicitly for no workgroup	1 month ago
SMB_OC.php	chore: Apply new coding standard to all files	3 months ago
Swift.php	chore: Apply new coding standard to all files	3 months ago