|
|
|
|
use strict;
|
|
|
|
|
use warnings;
|
Refactor Perl test code
The original code was a bit clunky; make it more amenable for further
reuse by creating a new Perl package PostgresNode, which is an
object-oriented representation of a single server, with some support
routines such as init, start, stop, psql. This serves as a better basis
on which to build further test code, and enables writing tests that use
more than one server without too much complication.
This commit modifies a lot of the existing test files, mostly to remove
explicit calls to system commands (pg_ctl) replacing them with method
calls of a PostgresNode object. The result is quite a bit more
straightforward.
Also move some initialization code to BEGIN and INIT blocks instead of
having it straight in as top-level code.
This commit also introduces package RecursiveCopy so that we can copy
whole directories without having to depend on packages that may not be
present on vanilla Perl 5.8 installations.
I also ran perltidy on the modified files, which changes some code sites
that are not otherwise touched by this patch. I tried to avoid this,
but it ended up being more trouble than it's worth.
Authors: Michael Paquier, Álvaro Herrera
Review: Noah Misch
10 years ago
|
|
|
|
|
|
|
|
use PostgresNode;
|
|
|
|
|
use TestLib;
|
|
|
|
|
use Test::More tests => 34;
|
|
|
|
|
|
|
|
|
|
program_help_ok('reindexdb');
|
|
|
|
|
program_version_ok('reindexdb');
|
|
|
|
|
program_options_handling_ok('reindexdb');
|
|
|
|
|
|
|
|
|
|
my $node = get_new_node('main');
|
Refactor Perl test code
The original code was a bit clunky; make it more amenable for further
reuse by creating a new Perl package PostgresNode, which is an
object-oriented representation of a single server, with some support
routines such as init, start, stop, psql. This serves as a better basis
on which to build further test code, and enables writing tests that use
more than one server without too much complication.
This commit modifies a lot of the existing test files, mostly to remove
explicit calls to system commands (pg_ctl) replacing them with method
calls of a PostgresNode object. The result is quite a bit more
straightforward.
Also move some initialization code to BEGIN and INIT blocks instead of
having it straight in as top-level code.
This commit also introduces package RecursiveCopy so that we can copy
whole directories without having to depend on packages that may not be
present on vanilla Perl 5.8 installations.
I also ran perltidy on the modified files, which changes some code sites
that are not otherwise touched by this patch. I tried to avoid this,
but it ended up being more trouble than it's worth.
Authors: Michael Paquier, Álvaro Herrera
Review: Noah Misch
10 years ago
|
|
|
$node->init;
|
|
|
|
|
$node->start;
|
|
|
|
|
|
|
|
|
|
$ENV{PGOPTIONS} = '--client-min-messages=WARNING';
|
|
|
|
|
|
Refactor Perl test code
The original code was a bit clunky; make it more amenable for further
reuse by creating a new Perl package PostgresNode, which is an
object-oriented representation of a single server, with some support
routines such as init, start, stop, psql. This serves as a better basis
on which to build further test code, and enables writing tests that use
more than one server without too much complication.
This commit modifies a lot of the existing test files, mostly to remove
explicit calls to system commands (pg_ctl) replacing them with method
calls of a PostgresNode object. The result is quite a bit more
straightforward.
Also move some initialization code to BEGIN and INIT blocks instead of
having it straight in as top-level code.
This commit also introduces package RecursiveCopy so that we can copy
whole directories without having to depend on packages that may not be
present on vanilla Perl 5.8 installations.
I also ran perltidy on the modified files, which changes some code sites
that are not otherwise touched by this patch. I tried to avoid this,
but it ended up being more trouble than it's worth.
Authors: Michael Paquier, Álvaro Herrera
Review: Noah Misch
10 years ago
|
|
|
$node->issues_sql_like(
|
|
|
|
|
[ 'reindexdb', 'postgres' ],
|
|
|
|
|
qr/statement: REINDEX DATABASE postgres;/,
|
|
|
|
|
'SQL REINDEX run');
|
|
|
|
|
|
|
|
|
|
$node->safe_psql('postgres',
|
Refactor Perl test code
The original code was a bit clunky; make it more amenable for further
reuse by creating a new Perl package PostgresNode, which is an
object-oriented representation of a single server, with some support
routines such as init, start, stop, psql. This serves as a better basis
on which to build further test code, and enables writing tests that use
more than one server without too much complication.
This commit modifies a lot of the existing test files, mostly to remove
explicit calls to system commands (pg_ctl) replacing them with method
calls of a PostgresNode object. The result is quite a bit more
straightforward.
Also move some initialization code to BEGIN and INIT blocks instead of
having it straight in as top-level code.
This commit also introduces package RecursiveCopy so that we can copy
whole directories without having to depend on packages that may not be
present on vanilla Perl 5.8 installations.
I also ran perltidy on the modified files, which changes some code sites
that are not otherwise touched by this patch. I tried to avoid this,
but it ended up being more trouble than it's worth.
Authors: Michael Paquier, Álvaro Herrera
Review: Noah Misch
10 years ago
|
|
|
'CREATE TABLE test1 (a int); CREATE INDEX test1x ON test1 (a);');
|
|
|
|
|
$node->issues_sql_like(
|
|
|
|
|
[ 'reindexdb', '-t', 'test1', 'postgres' ],
|
Empty search_path in Autovacuum and non-psql/pgbench clients.
This makes the client programs behave as documented regardless of the
connect-time search_path and regardless of user-created objects. Today,
a malicious user with CREATE permission on a search_path schema can take
control of certain of these clients' queries and invoke arbitrary SQL
functions under the client identity, often a superuser. This is
exploitable in the default configuration, where all users have CREATE
privilege on schema "public".
This changes behavior of user-defined code stored in the database, like
pg_index.indexprs and pg_extension_config_dump(). If they reach code
bearing unqualified names, "does not exist" or "no schema has been
selected to create in" errors might appear. Users may fix such errors
by schema-qualifying affected names. After upgrading, consider watching
server logs for these errors.
The --table arguments of src/bin/scripts clients have been lax; for
example, "vacuumdb -Zt pg_am\;CHECKPOINT" performed a checkpoint. That
now fails, but for now, "vacuumdb -Zt 'pg_am(amname);CHECKPOINT'" still
performs a checkpoint.
Back-patch to 9.3 (all supported versions).
Reviewed by Tom Lane, though this fix strategy was not his first choice.
Reported by Arseniy Sharoglazov.
Security: CVE-2018-1058
8 years ago
|
|
|
qr/statement: REINDEX TABLE public\.test1;/,
|
|
|
|
|
'reindex specific table');
|
Refactor Perl test code
The original code was a bit clunky; make it more amenable for further
reuse by creating a new Perl package PostgresNode, which is an
object-oriented representation of a single server, with some support
routines such as init, start, stop, psql. This serves as a better basis
on which to build further test code, and enables writing tests that use
more than one server without too much complication.
This commit modifies a lot of the existing test files, mostly to remove
explicit calls to system commands (pg_ctl) replacing them with method
calls of a PostgresNode object. The result is quite a bit more
straightforward.
Also move some initialization code to BEGIN and INIT blocks instead of
having it straight in as top-level code.
This commit also introduces package RecursiveCopy so that we can copy
whole directories without having to depend on packages that may not be
present on vanilla Perl 5.8 installations.
I also ran perltidy on the modified files, which changes some code sites
that are not otherwise touched by this patch. I tried to avoid this,
but it ended up being more trouble than it's worth.
Authors: Michael Paquier, Álvaro Herrera
Review: Noah Misch
10 years ago
|
|
|
$node->issues_sql_like(
|
|
|
|
|
[ 'reindexdb', '-i', 'test1x', 'postgres' ],
|
Empty search_path in Autovacuum and non-psql/pgbench clients.
This makes the client programs behave as documented regardless of the
connect-time search_path and regardless of user-created objects. Today,
a malicious user with CREATE permission on a search_path schema can take
control of certain of these clients' queries and invoke arbitrary SQL
functions under the client identity, often a superuser. This is
exploitable in the default configuration, where all users have CREATE
privilege on schema "public".
This changes behavior of user-defined code stored in the database, like
pg_index.indexprs and pg_extension_config_dump(). If they reach code
bearing unqualified names, "does not exist" or "no schema has been
selected to create in" errors might appear. Users may fix such errors
by schema-qualifying affected names. After upgrading, consider watching
server logs for these errors.
The --table arguments of src/bin/scripts clients have been lax; for
example, "vacuumdb -Zt pg_am\;CHECKPOINT" performed a checkpoint. That
now fails, but for now, "vacuumdb -Zt 'pg_am(amname);CHECKPOINT'" still
performs a checkpoint.
Back-patch to 9.3 (all supported versions).
Reviewed by Tom Lane, though this fix strategy was not his first choice.
Reported by Arseniy Sharoglazov.
Security: CVE-2018-1058
8 years ago
|
|
|
qr/statement: REINDEX INDEX public\.test1x;/,
|
|
|
|
|
'reindex specific index');
|
Refactor Perl test code
The original code was a bit clunky; make it more amenable for further
reuse by creating a new Perl package PostgresNode, which is an
object-oriented representation of a single server, with some support
routines such as init, start, stop, psql. This serves as a better basis
on which to build further test code, and enables writing tests that use
more than one server without too much complication.
This commit modifies a lot of the existing test files, mostly to remove
explicit calls to system commands (pg_ctl) replacing them with method
calls of a PostgresNode object. The result is quite a bit more
straightforward.
Also move some initialization code to BEGIN and INIT blocks instead of
having it straight in as top-level code.
This commit also introduces package RecursiveCopy so that we can copy
whole directories without having to depend on packages that may not be
present on vanilla Perl 5.8 installations.
I also ran perltidy on the modified files, which changes some code sites
that are not otherwise touched by this patch. I tried to avoid this,
but it ended up being more trouble than it's worth.
Authors: Michael Paquier, Álvaro Herrera
Review: Noah Misch
10 years ago
|
|
|
$node->issues_sql_like(
|
|
|
|
|
[ 'reindexdb', '-S', 'pg_catalog', 'postgres' ],
|
|
|
|
|
qr/statement: REINDEX SCHEMA pg_catalog;/,
|
|
|
|
|
'reindex specific schema');
|
Refactor Perl test code
The original code was a bit clunky; make it more amenable for further
reuse by creating a new Perl package PostgresNode, which is an
object-oriented representation of a single server, with some support
routines such as init, start, stop, psql. This serves as a better basis
on which to build further test code, and enables writing tests that use
more than one server without too much complication.
This commit modifies a lot of the existing test files, mostly to remove
explicit calls to system commands (pg_ctl) replacing them with method
calls of a PostgresNode object. The result is quite a bit more
straightforward.
Also move some initialization code to BEGIN and INIT blocks instead of
having it straight in as top-level code.
This commit also introduces package RecursiveCopy so that we can copy
whole directories without having to depend on packages that may not be
present on vanilla Perl 5.8 installations.
I also ran perltidy on the modified files, which changes some code sites
that are not otherwise touched by this patch. I tried to avoid this,
but it ended up being more trouble than it's worth.
Authors: Michael Paquier, Álvaro Herrera
Review: Noah Misch
10 years ago
|
|
|
$node->issues_sql_like(
|
|
|
|
|
[ 'reindexdb', '-s', 'postgres' ],
|
|
|
|
|
qr/statement: REINDEX SYSTEM postgres;/,
|
|
|
|
|
'reindex system tables');
|
Refactor Perl test code
The original code was a bit clunky; make it more amenable for further
reuse by creating a new Perl package PostgresNode, which is an
object-oriented representation of a single server, with some support
routines such as init, start, stop, psql. This serves as a better basis
on which to build further test code, and enables writing tests that use
more than one server without too much complication.
This commit modifies a lot of the existing test files, mostly to remove
explicit calls to system commands (pg_ctl) replacing them with method
calls of a PostgresNode object. The result is quite a bit more
straightforward.
Also move some initialization code to BEGIN and INIT blocks instead of
having it straight in as top-level code.
This commit also introduces package RecursiveCopy so that we can copy
whole directories without having to depend on packages that may not be
present on vanilla Perl 5.8 installations.
I also ran perltidy on the modified files, which changes some code sites
that are not otherwise touched by this patch. I tried to avoid this,
but it ended up being more trouble than it's worth.
Authors: Michael Paquier, Álvaro Herrera
Review: Noah Misch
10 years ago
|
|
|
$node->issues_sql_like(
|
|
|
|
|
[ 'reindexdb', '-v', '-t', 'test1', 'postgres' ],
|
Empty search_path in Autovacuum and non-psql/pgbench clients.
This makes the client programs behave as documented regardless of the
connect-time search_path and regardless of user-created objects. Today,
a malicious user with CREATE permission on a search_path schema can take
control of certain of these clients' queries and invoke arbitrary SQL
functions under the client identity, often a superuser. This is
exploitable in the default configuration, where all users have CREATE
privilege on schema "public".
This changes behavior of user-defined code stored in the database, like
pg_index.indexprs and pg_extension_config_dump(). If they reach code
bearing unqualified names, "does not exist" or "no schema has been
selected to create in" errors might appear. Users may fix such errors
by schema-qualifying affected names. After upgrading, consider watching
server logs for these errors.
The --table arguments of src/bin/scripts clients have been lax; for
example, "vacuumdb -Zt pg_am\;CHECKPOINT" performed a checkpoint. That
now fails, but for now, "vacuumdb -Zt 'pg_am(amname);CHECKPOINT'" still
performs a checkpoint.
Back-patch to 9.3 (all supported versions).
Reviewed by Tom Lane, though this fix strategy was not his first choice.
Reported by Arseniy Sharoglazov.
Security: CVE-2018-1058
8 years ago
|
|
|
qr/statement: REINDEX \(VERBOSE\) TABLE public\.test1;/,
|
|
|
|
|
'reindex with verbose output');
|
|
|
|
|
|
|
|
|
|
# the same with --concurrently
|
|
|
|
|
$node->issues_sql_like(
|
|
|
|
|
[ 'reindexdb', '--concurrently', 'postgres' ],
|
|
|
|
|
qr/statement: REINDEX DATABASE CONCURRENTLY postgres;/,
|
|
|
|
|
'SQL REINDEX CONCURRENTLY run');
|
|
|
|
|
|
|
|
|
|
$node->issues_sql_like(
|
|
|
|
|
[ 'reindexdb', '--concurrently', '-t', 'test1', 'postgres' ],
|
|
|
|
|
qr/statement: REINDEX TABLE CONCURRENTLY public\.test1;/,
|
|
|
|
|
'reindex specific table concurrently');
|
|
|
|
|
$node->issues_sql_like(
|
|
|
|
|
[ 'reindexdb', '--concurrently', '-i', 'test1x', 'postgres' ],
|
|
|
|
|
qr/statement: REINDEX INDEX CONCURRENTLY public\.test1x;/,
|
|
|
|
|
'reindex specific index concurrently');
|
|
|
|
|
$node->issues_sql_like(
|
|
|
|
|
[ 'reindexdb', '--concurrently', '-S', 'public', 'postgres' ],
|
|
|
|
|
qr/statement: REINDEX SCHEMA CONCURRENTLY public;/,
|
|
|
|
|
'reindex specific schema concurrently');
|
|
|
|
|
$node->command_fails(
|
|
|
|
|
[ 'reindexdb', '--concurrently', '-s', 'postgres' ],
|
|
|
|
|
'reindex system tables concurrently');
|
|
|
|
|
$node->issues_sql_like(
|
|
|
|
|
[ 'reindexdb', '-v', '-t', 'test1', 'postgres' ],
|
|
|
|
|
qr/statement: REINDEX \(VERBOSE\) TABLE public\.test1;/,
|
|
|
|
|
'reindex with verbose output');
|
|
|
|
|
|
|
|
|
|
# connection strings
|
|
|
|
|
$node->command_ok([qw(reindexdb --echo --table=pg_am dbname=template1)],
|
|
|
|
|
'reindexdb table with connection string');
|
|
|
|
|
$node->command_ok(
|
|
|
|
|
[qw(reindexdb --echo dbname=template1)],
|
|
|
|
|
'reindexdb database with connection string');
|
|
|
|
|
$node->command_ok(
|
|
|
|
|
[qw(reindexdb --echo --system dbname=template1)],
|
|
|
|
|
'reindexdb system with connection string');
|
