Create libpgcommon, and move pg_malloc et al to it
libpgcommon is a new static library to allow sharing code among the
various frontend programs and backend; this lets us eliminate duplicate
implementations of common routines. We avoid libpgport, because that's
intended as a place for porting issues; per discussion, it seems better
to keep them separate.
The first use case, and the only implemented by this patch, is pg_malloc
and friends, which many frontend programs were already using.
At the same time, we can use this to provide palloc emulation functions
for the frontend; this way, some palloc-using files in the backend can
also be used by the frontend cleanly. To do this, we change palloc() in
the backend to be a function instead of a macro on top of
MemoryContextAlloc(). This was previously believed to cause loss of
performance, but this implementation has been tweaked by Tom and Andres
so that on modern compilers it provides a slight improvement over the
previous one.
This lets us clean up some places that were already with
localized hacks.
Most of the pg_malloc/palloc changes in this patch were authored by
Andres Freund. Zoltán Böszörményi also independently provided a form of
that. libpgcommon infrastructure was authored by Álvaro.
13 years ago
|
|
|
/*
|
|
|
|
|
* fe_memutils.h
|
|
|
|
|
* memory management support for frontend code
|
|
|
|
|
*
|
|
|
|
|
* Copyright (c) 2003-2024, PostgreSQL Global Development Group
|
Create libpgcommon, and move pg_malloc et al to it
libpgcommon is a new static library to allow sharing code among the
various frontend programs and backend; this lets us eliminate duplicate
implementations of common routines. We avoid libpgport, because that's
intended as a place for porting issues; per discussion, it seems better
to keep them separate.
The first use case, and the only implemented by this patch, is pg_malloc
and friends, which many frontend programs were already using.
At the same time, we can use this to provide palloc emulation functions
for the frontend; this way, some palloc-using files in the backend can
also be used by the frontend cleanly. To do this, we change palloc() in
the backend to be a function instead of a macro on top of
MemoryContextAlloc(). This was previously believed to cause loss of
performance, but this implementation has been tweaked by Tom and Andres
so that on modern compilers it provides a slight improvement over the
previous one.
This lets us clean up some places that were already with
localized hacks.
Most of the pg_malloc/palloc changes in this patch were authored by
Andres Freund. Zoltán Böszörményi also independently provided a form of
that. libpgcommon infrastructure was authored by Álvaro.
13 years ago
|
|
|
*
|
|
|
|
|
* src/include/common/fe_memutils.h
|
|
|
|
|
*/
|
|
|
|
|
#ifndef FE_MEMUTILS_H
|
|
|
|
|
#define FE_MEMUTILS_H
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* Flags for pg_malloc_extended and palloc_extended, deliberately named
|
|
|
|
|
* the same as the backend flags.
|
|
|
|
|
*/
|
|
|
|
|
#define MCXT_ALLOC_HUGE 0x01 /* allow huge allocation (> 1 GB) not
|
|
|
|
|
* actually used for frontends */
|
|
|
|
|
#define MCXT_ALLOC_NO_OOM 0x02 /* no failure if out-of-memory */
|
|
|
|
|
#define MCXT_ALLOC_ZERO 0x04 /* zero allocated memory */
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* "Safe" memory allocation functions --- these exit(1) on failure
|
|
|
|
|
* (except pg_malloc_extended with MCXT_ALLOC_NO_OOM)
|
|
|
|
|
*/
|
|
|
|
|
extern char *pg_strdup(const char *in);
|
Create libpgcommon, and move pg_malloc et al to it
libpgcommon is a new static library to allow sharing code among the
various frontend programs and backend; this lets us eliminate duplicate
implementations of common routines. We avoid libpgport, because that's
intended as a place for porting issues; per discussion, it seems better
to keep them separate.
The first use case, and the only implemented by this patch, is pg_malloc
and friends, which many frontend programs were already using.
At the same time, we can use this to provide palloc emulation functions
for the frontend; this way, some palloc-using files in the backend can
also be used by the frontend cleanly. To do this, we change palloc() in
the backend to be a function instead of a macro on top of
MemoryContextAlloc(). This was previously believed to cause loss of
performance, but this implementation has been tweaked by Tom and Andres
so that on modern compilers it provides a slight improvement over the
previous one.
This lets us clean up some places that were already with
localized hacks.
Most of the pg_malloc/palloc changes in this patch were authored by
Andres Freund. Zoltán Böszörményi also independently provided a form of
that. libpgcommon infrastructure was authored by Álvaro.
13 years ago
|
|
|
extern void *pg_malloc(size_t size);
|
|
|
|
|
extern void *pg_malloc0(size_t size);
|
|
|
|
|
extern void *pg_malloc_extended(size_t size, int flags);
|
|
|
|
|
extern void *pg_realloc(void *ptr, size_t size);
|
|
|
|
|
extern void pg_free(void *ptr);
|
Create libpgcommon, and move pg_malloc et al to it
libpgcommon is a new static library to allow sharing code among the
various frontend programs and backend; this lets us eliminate duplicate
implementations of common routines. We avoid libpgport, because that's
intended as a place for porting issues; per discussion, it seems better
to keep them separate.
The first use case, and the only implemented by this patch, is pg_malloc
and friends, which many frontend programs were already using.
At the same time, we can use this to provide palloc emulation functions
for the frontend; this way, some palloc-using files in the backend can
also be used by the frontend cleanly. To do this, we change palloc() in
the backend to be a function instead of a macro on top of
MemoryContextAlloc(). This was previously believed to cause loss of
performance, but this implementation has been tweaked by Tom and Andres
so that on modern compilers it provides a slight improvement over the
previous one.
This lets us clean up some places that were already with
localized hacks.
Most of the pg_malloc/palloc changes in this patch were authored by
Andres Freund. Zoltán Böszörményi also independently provided a form of
that. libpgcommon infrastructure was authored by Álvaro.
13 years ago
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* Variants with easier notation and more type safety
|
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* Allocate space for one object of type "type"
|
|
|
|
|
*/
|
|
|
|
|
#define pg_malloc_object(type) ((type *) pg_malloc(sizeof(type)))
|
|
|
|
|
#define pg_malloc0_object(type) ((type *) pg_malloc0(sizeof(type)))
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* Allocate space for "count" objects of type "type"
|
|
|
|
|
*/
|
|
|
|
|
#define pg_malloc_array(type, count) ((type *) pg_malloc(sizeof(type) * (count)))
|
|
|
|
|
#define pg_malloc0_array(type, count) ((type *) pg_malloc0(sizeof(type) * (count)))
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* Change size of allocation pointed to by "pointer" to have space for "count"
|
|
|
|
|
* objects of type "type"
|
|
|
|
|
*/
|
|
|
|
|
#define pg_realloc_array(pointer, type, count) ((type *) pg_realloc(pointer, sizeof(type) * (count)))
|
|
|
|
|
|
|
|
|
|
/* Equivalent functions, deliberately named the same as backend functions */
|
|
|
|
|
extern char *pstrdup(const char *in);
|
|
|
|
|
extern char *pnstrdup(const char *in, Size size);
|
|
|
|
|
extern void *palloc(Size size);
|
|
|
|
|
extern void *palloc0(Size size);
|
|
|
|
|
extern void *palloc_extended(Size size, int flags);
|
|
|
|
|
extern void *repalloc(void *pointer, Size size);
|
|
|
|
|
extern void pfree(void *pointer);
|
|
|
|
|
|
|
|
|
|
#define palloc_object(type) ((type *) palloc(sizeof(type)))
|
|
|
|
|
#define palloc0_object(type) ((type *) palloc0(sizeof(type)))
|
|
|
|
|
#define palloc_array(type, count) ((type *) palloc(sizeof(type) * (count)))
|
|
|
|
|
#define palloc0_array(type, count) ((type *) palloc0(sizeof(type) * (count)))
|
|
|
|
|
#define repalloc_array(pointer, type, count) ((type *) repalloc(pointer, sizeof(type) * (count)))
|
|
|
|
|
|
|
|
|
|
/* sprintf into a palloc'd buffer --- these are in psprintf.c */
|
|
|
|
|
extern char *psprintf(const char *fmt,...) pg_attribute_printf(1, 2);
|
|
|
|
|
extern size_t pvsnprintf(char *buf, size_t len, const char *fmt, va_list args) pg_attribute_printf(3, 0);
|
Create libpgcommon, and move pg_malloc et al to it
libpgcommon is a new static library to allow sharing code among the
various frontend programs and backend; this lets us eliminate duplicate
implementations of common routines. We avoid libpgport, because that's
intended as a place for porting issues; per discussion, it seems better
to keep them separate.
The first use case, and the only implemented by this patch, is pg_malloc
and friends, which many frontend programs were already using.
At the same time, we can use this to provide palloc emulation functions
for the frontend; this way, some palloc-using files in the backend can
also be used by the frontend cleanly. To do this, we change palloc() in
the backend to be a function instead of a macro on top of
MemoryContextAlloc(). This was previously believed to cause loss of
performance, but this implementation has been tweaked by Tom and Andres
so that on modern compilers it provides a slight improvement over the
previous one.
This lets us clean up some places that were already with
localized hacks.
Most of the pg_malloc/palloc changes in this patch were authored by
Andres Freund. Zoltán Böszörményi also independently provided a form of
that. libpgcommon infrastructure was authored by Álvaro.
13 years ago
|
|
|
|
Phase 2 of pgindent updates.
Change pg_bsd_indent to follow upstream rules for placement of comments
to the right of code, and remove pgindent hack that caused comments
following #endif to not obey the general rule.
Commit e3860ffa4dd0dad0dd9eea4be9cc1412373a8c89 wasn't actually using
the published version of pg_bsd_indent, but a hacked-up version that
tried to minimize the amount of movement of comments to the right of
code. The situation of interest is where such a comment has to be
moved to the right of its default placement at column 33 because there's
code there. BSD indent has always moved right in units of tab stops
in such cases --- but in the previous incarnation, indent was working
in 8-space tab stops, while now it knows we use 4-space tabs. So the
net result is that in about half the cases, such comments are placed
one tab stop left of before. This is better all around: it leaves
more room on the line for comment text, and it means that in such
cases the comment uniformly starts at the next 4-space tab stop after
the code, rather than sometimes one and sometimes two tabs after.
Also, ensure that comments following #endif are indented the same
as comments following other preprocessor commands such as #else.
That inconsistency turns out to have been self-inflicted damage
from a poorly-thought-through post-indent "fixup" in pgindent.
This patch is much less interesting than the first round of indent
changes, but also bulkier, so I thought it best to separate the effects.
Discussion: https://postgr.es/m/E1dAmxK-0006EE-1r@gemulon.postgresql.org
Discussion: https://postgr.es/m/30527.1495162840@sss.pgh.pa.us
9 years ago
|
|
|
#endif /* FE_MEMUTILS_H */
|
