Refactor script execution state machine in pgbench.

Browse Source

The doCustom() function had grown into quite a mess. Rewrite it, in a more
explicit state machine style, for readability.

This also fixes one minor bug: if a script consisted entirely of meta
commands, doCustom() never returned to the caller, so progress reports
with the -P option were not printed. I don't want to backpatch this
refactoring, and the bug is quite insignificant, so only commit this to
master, and leave the bug unfixed in back-branches.

Review and original bug report by Fabien Coelho.

Discussion: <alpine.DEB.2.20.1607090850120.3412@sto>

pull/17/head

Heikki Linnakangas 9 years ago

parent da6c4f6ca8

commit 12788ae49e

1 changed files with 661 additions and 445 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Show Stats Download Patch File Download Diff File

1. 1106
     src/bin/pgbench/pgbench.c

1106

src/bin/pgbench/pgbench.c

View File

File diff suppressed because it is too large Load Diff

Write Preview

Loading…

Cancel

Save