Fix two src/test/modules Makefiles

commit_ts and test_pg_dump were declaring targets before including the
PGXS stanza, which meant that the "all" target customarily defined as
the first (and therefore default target) was not the default anymore.
Fix that by moving those target definitions to after PGXS.

commit_ts was initially good, but I broke it in commit 9def031bd2;
test_pg_dump was born broken, probably copying from commit_ts' mistake.

In passing, fix a comment mistake in test_pg_dump/Makefile.

Backpatch to 9.6.

Noted by Tom Lane.
pull/17/head
Alvaro Herrera 9 years ago
parent df5d9bb8d5
commit 19acee8c5a
  1. 10
      src/test/modules/commit_ts/Makefile
  2. 12
      src/test/modules/test_pg_dump/Makefile

@ -3,11 +3,6 @@
REGRESS = commit_timestamp
REGRESS_OPTS = --temp-config=$(top_srcdir)/src/test/modules/commit_ts/commit_ts.conf
check: prove-check
prove-check:
$(prove_check)
ifdef USE_PGXS
PG_CONFIG = pg_config
PGXS := $(shell $(PG_CONFIG) --pgxs)
@ -18,3 +13,8 @@ top_builddir = ../../../..
include $(top_builddir)/src/Makefile.global
include $(top_srcdir)/contrib/contrib-global.mk
endif
check: prove-check
prove-check:
$(prove_check)

@ -1,4 +1,4 @@
# src/test/modules/test_rls_hooks/Makefile
# src/test/modules/test_pg_dump/Makefile
MODULE = test_pg_dump
PGFILEDESC = "test_pg_dump - Test pg_dump with an extension"
@ -8,11 +8,6 @@ DATA = test_pg_dump--1.0.sql
REGRESS = test_pg_dump
check: prove-check
prove-check:
$(prove_check)
ifdef USE_PGXS
PG_CONFIG = pg_config
PGXS := $(shell $(PG_CONFIG) --pgxs)
@ -23,3 +18,8 @@ top_builddir = ../../../..
include $(top_builddir)/src/Makefile.global
include $(top_srcdir)/contrib/contrib-global.mk
endif
check: prove-check
prove-check:
$(prove_check)

Loading…
Cancel
Save