open-dsi
/
postgres
mirror of https://github.com/postgres/postgres
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix and clarify information schema interval_precision fields

Browse Source 
The fields were previously wrongly typed as character_data; change to
cardinal_number.  Update the documentation and the implementation to
show more clearly that this applies to a feature not available in
PostgreSQL, rather than just not yet being implemented in the
information schema.
pull/1/head
Peter Eisentraut 14 years ago
parent 75726307e6
commit 3315020a09
2 changed files with 34 additions and 19 deletions
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Show Stats Download Patch File Download Diff File
  1. 37
      doc/src/sgml/information_schema.sgml
  2. 16
      src/backend/catalog/information_schema.sql

37
doc/src/sgml/information_schema.sgml
Unescape View File

@ -488,8 +488,13 @@
<row>
<entry><literal>interval_precision</literal></entry>
<entry><type>character_data</type></entry>
<entry>Not yet implemented</entry>
<entry><type>cardinal_number</type></entry>
<entry>
Applies to a feature not available
in <productname>PostgreSQL</productname>
(see <literal>datetime_precision</literal> for the fractional
seconds precision of interval type attributes)
</entry>
</row>
<row>
@ -1343,8 +1348,13 @@
<row>
<entry><literal>interval_precision</literal></entry>
<entry><type>character_data</type></entry>
<entry>Not yet implemented</entry>
<entry><type>cardinal_number</type></entry>
<entry>
Applies to a feature not available
in <productname>PostgreSQL</productname>
(see <literal>datetime_precision</literal> for the fractional
seconds precision of interval type columns)
</entry>
</row>
<row>
@ -2139,8 +2149,13 @@
<row>
<entry><literal>interval_precision</literal></entry>
<entry><type>character_data</type></entry>
<entry>Not yet implemented</entry>
<entry><type>cardinal_number</type></entry>
<entry>
Applies to a feature not available
in <productname>PostgreSQL</productname>
(see <literal>datetime_precision</literal> for the fractional
seconds precision of interval type domains)
</entry>
</row>
<row>
@ -2400,7 +2415,7 @@ ORDER BY c.ordinal_position;
<row>
<entry><literal>interval_precision</literal></entry>
<entry><type>character_data</type></entry>
<entry><type>cardinal_number</type></entry>
<entry>Always null, since this information is not applied to array element data types in <productname>PostgreSQL</></entry>
</row>
@ -3150,7 +3165,7 @@ ORDER BY c.ordinal_position;
<row>
<entry><literal>interval_precision</literal></entry>
<entry><type>character_data</type></entry>
<entry><type>cardinal_number</type></entry>
<entry>Always null, since this information is not applied to parameter data types in <productname>PostgreSQL</></entry>
</row>
@ -4037,7 +4052,7 @@ ORDER BY c.ordinal_position;
<row>
<entry><literal>interval_precision</literal></entry>
<entry><type>character_data</type></entry>
<entry><type>cardinal_number</type></entry>
<entry>Always null, since this information is not applied to return data types in <productname>PostgreSQL</></entry>
</row>
@ -4369,7 +4384,7 @@ ORDER BY c.ordinal_position;
<row>
<entry><literal>result_cast_interval_precision</literal></entry>
<entry><type>character_data</type></entry>
<entry><type>cardinal_number</type></entry>
<entry>Applies to a feature not available in <productname>PostgreSQL</></entry>
</row>
@ -6008,7 +6023,7 @@ ORDER BY c.ordinal_position;
<row>
<entry><literal>interval_precision</literal></entry>
<entry><type>character_data</type></entry>
<entry><type>cardinal_number</type></entry>
<entry>Applies to a feature not available in <productname>PostgreSQL</></entry>
</row>

16
src/backend/catalog/information_schema.sql
Unescape View File

@ -322,7 +322,7 @@ CREATE VIEW attributes AS
AS datetime_precision,
CAST(null AS character_data) AS interval_type, -- FIXME
CAST(null AS character_data) AS interval_precision, -- FIXME
CAST(null AS cardinal_number) AS interval_precision,
CAST(current_database() AS sql_identifier) AS attribute_udt_catalog,
CAST(nt.nspname AS sql_identifier) AS attribute_udt_schema,
@ -671,7 +671,7 @@ CREATE VIEW columns AS
AS datetime_precision,
CAST(null AS character_data) AS interval_type, -- FIXME
CAST(null AS character_data) AS interval_precision, -- FIXME
CAST(null AS cardinal_number) AS interval_precision,
CAST(null AS sql_identifier) AS character_set_catalog,
CAST(null AS sql_identifier) AS character_set_schema,
@ -937,7 +937,7 @@ CREATE VIEW domains AS
AS datetime_precision,
CAST(null AS character_data) AS interval_type, -- FIXME
CAST(null AS character_data) AS interval_precision, -- FIXME
CAST(null AS cardinal_number) AS interval_precision,
CAST(t.typdefault AS character_data) AS domain_default,
@ -1085,7 +1085,7 @@ CREATE VIEW parameters AS
CAST(null AS cardinal_number) AS numeric_scale,
CAST(null AS cardinal_number) AS datetime_precision,
CAST(null AS character_data) AS interval_type,
CAST(null AS character_data) AS interval_precision,
CAST(null AS cardinal_number) AS interval_precision,
CAST(current_database() AS sql_identifier) AS udt_catalog,
CAST(nt.nspname AS sql_identifier) AS udt_schema,
CAST(t.typname AS sql_identifier) AS udt_name,
@ -1353,7 +1353,7 @@ CREATE VIEW routines AS
CAST(null AS cardinal_number) AS numeric_scale,
CAST(null AS cardinal_number) AS datetime_precision,
CAST(null AS character_data) AS interval_type,
CAST(null AS character_data) AS interval_precision,
CAST(null AS cardinal_number) AS interval_precision,
CAST(current_database() AS sql_identifier) AS type_udt_catalog,
CAST(nt.nspname AS sql_identifier) AS type_udt_schema,
CAST(t.typname AS sql_identifier) AS type_udt_name,
@ -1407,7 +1407,7 @@ CREATE VIEW routines AS
CAST(null AS cardinal_number) AS result_cast_numeric_scale,
CAST(null AS cardinal_number) AS result_cast_datetime_precision,
CAST(null AS character_data) AS result_cast_interval_type,
CAST(null AS character_data) AS result_cast_interval_precision,
CAST(null AS cardinal_number) AS result_cast_interval_precision,
CAST(null AS sql_identifier) AS result_cast_type_udt_catalog,
CAST(null AS sql_identifier) AS result_cast_type_udt_schema,
CAST(null AS sql_identifier) AS result_cast_type_udt_name,
@ -2212,7 +2212,7 @@ CREATE VIEW user_defined_types AS
CAST(null AS cardinal_number) AS numeric_scale,
CAST(null AS cardinal_number) AS datetime_precision,
CAST(null AS character_data) AS interval_type,
CAST(null AS character_data) AS interval_precision,
CAST(null AS cardinal_number) AS interval_precision,
CAST(null AS sql_identifier) AS source_dtd_identifier,
CAST(null AS sql_identifier) AS ref_dtd_identifier
@ -2448,7 +2448,7 @@ CREATE VIEW element_types AS
CAST(null AS cardinal_number) AS numeric_scale,
CAST(null AS cardinal_number) AS datetime_precision,
CAST(null AS character_data) AS interval_type,
CAST(null AS character_data) AS interval_precision,
CAST(null AS cardinal_number) AS interval_precision,
CAST(null AS character_data) AS domain_default, -- XXX maybe a bug in the standard

Write Preview
Loading…
Cancel
Save