From 61630ceaf26208dbb93f0f2d2a0ca8e16824888c Mon Sep 17 00:00:00 2001 From: Andreas Karlsson Date: Thu, 13 Mar 2025 23:51:03 +0100 Subject: [PATCH] Make sure we abort on failed read of previous WAL key It makes no sense to continue after we failed to read from the file, especially since prev_key is used despite it containing junk now. --- contrib/pg_tde/src/access/pg_tde_tdemap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/pg_tde/src/access/pg_tde_tdemap.c b/contrib/pg_tde/src/access/pg_tde_tdemap.c index 6b5b2ad9dee..4130ddc847b 100644 --- a/contrib/pg_tde/src/access/pg_tde_tdemap.c +++ b/contrib/pg_tde/src/access/pg_tde_tdemap.c @@ -940,7 +940,7 @@ pg_tde_wal_last_key_set_lsn(XLogRecPtr lsn, const char *keyfile_path) if (pg_pread(fd, &prev_key, INTERNAL_KEY_DAT_LEN, prev_key_pos) != INTERNAL_KEY_DAT_LEN) { LWLockRelease(lock_pk); - ereport(WARNING, + ereport(ERROR, (errcode_for_file_access(), errmsg("could not read previous WAL key: %m"))); }