Simplify new test suite handling of passwordcheck

This changes the use of a custom configuration file to enforce the value
of preload_shared_libraries to simply load the library during the tests.
This removes the restriction of running installcheck on the tests, and
simplifies its makefile contrary to what has been introduced in af7211e.

Author: Michael Paquier <michael.paquier@gmail.com>
pull/31/head^2
Peter Eisentraut 8 years ago
parent 62a16572d5
commit 637a934ab9
  1. 3
      contrib/passwordcheck/Makefile
  2. 1
      contrib/passwordcheck/expected/passwordcheck.out
  3. 1
      contrib/passwordcheck/passwordcheck.conf
  4. 2
      contrib/passwordcheck/sql/passwordcheck.sql

@ -8,10 +8,7 @@ PGFILEDESC = "passwordcheck - strengthen user password checks"
# PG_CPPFLAGS = -DUSE_CRACKLIB '-DCRACKLIB_DICTPATH="/usr/lib/cracklib_dict"'
# SHLIB_LINK = -lcrack
REGRESS_OPTS = --temp-config $(srcdir)/passwordcheck.conf
REGRESS = passwordcheck
# disabled because these tests require setting shared_preload_libraries
NO_INSTALLCHECK = 1
ifdef USE_PGXS
PG_CONFIG = pg_config

@ -1,3 +1,4 @@
LOAD 'passwordcheck';
CREATE USER regress_user1;
-- ok
ALTER USER regress_user1 PASSWORD 'a_nice_long_password';

@ -1 +0,0 @@
shared_preload_libraries = 'passwordcheck'

@ -1,3 +1,5 @@
LOAD 'passwordcheck';
CREATE USER regress_user1;
-- ok

Loading…
Cancel
Save