Disable installcheck tests for test_session_hooks

The module requires a preloaded library and the defect can't be cured by
a LOAD instruction in the test script. To achieve this we override the
installcheck target in the module's Makefile, and exclude ithe module in
vcregress.pl.

Along the way, revert commit 9989f92aab.
pull/31/head^2
Andrew Dunstan 8 years ago
parent 9989f92aab
commit 745948422c
  1. 1
      src/test/modules/Makefile
  2. 4
      src/test/modules/test_session_hooks/Makefile
  3. 2
      src/tools/msvc/vcregress.pl

@ -15,6 +15,7 @@ SUBDIRS = \
test_pg_dump \
test_rbtree \
test_rls_hooks \
test_session_hooks \
test_shm_mq \
worker_spi

@ -19,3 +19,7 @@ top_builddir = ../../../..
include $(top_builddir)/src/Makefile.global
include $(top_srcdir)/contrib/contrib-global.mk
endif
# override installcheck - this module requires preloading the test module
installcheck:
@echo Cannot run $@ for test_session_hooks. Run "'make check'" instead.

@ -383,6 +383,8 @@ sub modulescheck
my $mstat = 0;
foreach my $module (glob("*"))
{
# test_session_hooks can't run installcheck, so skip it here
next if $module eq 'test_session_hooks';
subdircheck("$topdir/src/test/modules", $module);
my $status = $? >> 8;
$mstat ||= $status;

Loading…
Cancel
Save