From 77038d6d0b49622e719fc00ed46db0ab47d2b747 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=81lvaro=20Herrera?= Date: Mon, 15 Dec 2025 12:17:37 +0100 Subject: [PATCH] Disable recently added CIC/RI isolation tests We have tried to stabilize them several times already, but they are very flaky -- apparently there's some intrinsic instability that's hard to solve with the isolationtester framework. They are very noisy in CI runs (whereas buildfarm has not registered any such failures). They may need to be rewritten completely. In the meantime just comment them out in Makefile/meson.build, leaving the spec files around. Per complaint from Andres Freund. Discussion: https://postgr.es/m/202512112014.icpomgc37zx4@alvherre.pgsql --- src/test/modules/injection_points/Makefile | 15 +++++++++------ src/test/modules/injection_points/meson.build | 11 ++++++----- 2 files changed, 15 insertions(+), 11 deletions(-) diff --git a/src/test/modules/injection_points/Makefile b/src/test/modules/injection_points/Makefile index c85034eb8cc..bfdb3f53377 100644 --- a/src/test/modules/injection_points/Makefile +++ b/src/test/modules/injection_points/Makefile @@ -14,12 +14,15 @@ REGRESS_OPTS = --dlpath=$(top_builddir)/src/test/regress ISOLATION = basic \ inplace \ - syscache-update-pruned \ - index-concurrently-upsert \ - index-concurrently-upsert-predicate \ - reindex-concurrently-upsert \ - reindex-concurrently-upsert-on-constraint \ - reindex-concurrently-upsert-partitioned + syscache-update-pruned + +# Temporarily disabled because of flakiness +#ISOLATION =+ +# index-concurrently-upsert \ +# index-concurrently-upsert-predicate \ +# reindex-concurrently-upsert \ +# reindex-concurrently-upsert-on-constraint \ +# reindex-concurrently-upsert-partitioned # The injection points are cluster-wide, so disable installcheck NO_INSTALLCHECK = 1 diff --git a/src/test/modules/injection_points/meson.build b/src/test/modules/injection_points/meson.build index 8d6f662040d..493e11053dc 100644 --- a/src/test/modules/injection_points/meson.build +++ b/src/test/modules/injection_points/meson.build @@ -46,11 +46,12 @@ tests += { 'basic', 'inplace', 'syscache-update-pruned', - 'index-concurrently-upsert', - 'index-concurrently-upsert-predicate', - 'reindex-concurrently-upsert', - 'reindex-concurrently-upsert-on-constraint', - 'reindex-concurrently-upsert-partitioned', + # temporarily disabled because of flakiness + # 'index-concurrently-upsert', + # 'index-concurrently-upsert-predicate', + # 'reindex-concurrently-upsert', + # 'reindex-concurrently-upsert-on-constraint', + # 'reindex-concurrently-upsert-partitioned', ], 'runningcheck': false, # see syscache-update-pruned # Some tests wait for all snapshots, so avoid parallel execution