Clarify the 'rows' parameter in create_append_path

This is extracted from a larger patch to improve the UNION planner.
While working on that, I found myself having to check what the 'rows'
parameter is for.  It's not obvious that passing a negative number is the
way to have the rows estimate calculated and to find that out you need
to read code in create_append_path() and in cost_append().

Discussion: https://postgr.es/m/CAApHDvpb_63XQodmxKUF8vb9M7CxyUyT4sWvEgqeQU-GB7QFoQ@mail.gmail.com
pull/157/head
David Rowley 1 year ago
parent 8fd0498de2
commit 87027cb55b
  1. 4
      src/backend/optimizer/util/pathnode.c

@ -1237,6 +1237,10 @@ create_tidrangescan_path(PlannerInfo *root, RelOptInfo *rel,
*
* Note that we must handle subpaths = NIL, representing a dummy access path.
* Also, there are callers that pass root = NULL.
*
* 'rows', when passed as a non-negative number, will be used to overwrite the
* returned path's row estimate. Otherwise, the row estimate is calculated
* by totalling the row estimates from the 'subpaths' list.
*/
AppendPath *
create_append_path(PlannerInfo *root,

Loading…
Cancel
Save