Remove unnecessary NULL test.

Spotted by Coverity and reported by Michael Paquier. Per discussion, we don't necessarily care about making Coverity happy in all such instances, but we can go ahead and change them where it otherwise seems to improve the code.
10 years ago · 8a8c581a8c
parent 31c018ecda
commit 8a8c581a8c
1 changed files with 1 additions and 2 deletions
--- a/src/bin/pg_upgrade/controldata.c
+++ b/src/bin/pg_upgrade/controldata.c
@ -402,8 +402,7 @@ get_control_data(ClusterInfo *cluster, bool live_check)
 		}
 	}

-	if (output)
-		pclose(output);
+	pclose(output);

 	/*
 	 * Restore environment variables