cc1: warnings being treated as errors
datum.c: In function `DatumGetSize':
datum.c:57: warning: unsigned value >= 0 is always 1
gmake[3]: *** [datum.o] Error 1

There was:
    if (byVal) {
        if (len >= 0 && len <= sizeof(Datum)) {

but len has type Size (unsigned int) and so now there is:
    if (byVal) {
        if (len <= sizeof(Datum)) {
            size = len;
        } else {
            elog(WARN,
                 "datumGetSize: Error: type=%ld, byVaL with len=%d",
                 (long) type, len);
        }
    } else { /*  not byValue */
REL2_0B
Vadim B. Mikheev 29 years ago
parent 9ec39eb6e3
commit 8c68e07561
  1. 4
      src/backend/utils/adt/datum.c

@ -6,7 +6,7 @@
*
*
* IDENTIFICATION
* $Header: /cvsroot/pgsql/src/backend/utils/adt/datum.c,v 1.3 1996/11/08 05:59:41 momjian Exp $
* $Header: /cvsroot/pgsql/src/backend/utils/adt/datum.c,v 1.3.2.1 1996/12/14 07:54:22 vadim Exp $
*
*-------------------------------------------------------------------------
*/
@ -54,7 +54,7 @@ datumGetSize(Datum value, Oid type, bool byVal, Size len)
Size size = 0;
if (byVal) {
if (len >= 0 && len <= sizeof(Datum)) {
if (len <= sizeof(Datum)) {
size = len;
} else {
elog(WARN,

Loading…
Cancel
Save