mirror of https://github.com/postgres/postgres
Until now, REINDEX was not able to work with partitioned tables and indexes, forcing users to reindex partitions one by one. This extends REINDEX INDEX and REINDEX TABLE so as they can accept a partitioned index and table in input, respectively, to reindex all the partitions assigned to them with physical storage (foreign tables, partitioned tables and indexes are then discarded). This shares some logic with schema and database REINDEX as each partition gets processed in its own transaction after building a list of relations to work on. This choice has the advantage to minimize the number of invalid indexes to one partition with REINDEX CONCURRENTLY in the event a cancellation or failure in-flight, as the only indexes handled at once in a single REINDEX CONCURRENTLY loop are the ones from the partition being working on. Isolation tests are added to emulate some cases I bumped into while developing this feature, particularly with the concurrent drop of a leaf partition reindexed. However, this is rather limited as LOCK would cause REINDEX to block in the first transaction building the list of partitions. Per its multi-transaction nature, this new flavor cannot run in a transaction block, similarly to REINDEX SCHEMA, SYSTEM and DATABASE. Author: Justin Pryzby, Michael Paquier Reviewed-by: Anastasia Lubennikova Discussion: https://postgr.es/m/db12e897-73ff-467e-94cb-4af03705435f.adger.lj@alibaba-inc.compull/57/head
Michael Paquier
5 years ago
parent
a547e68675
commit
a6642b3ae0
@ -0,0 +1,107 @@ |
||||
Parsed test spec with 3 sessions |
||||
|
||||
starting permutation: begin1 lockexcl1 reindex2 drop3 end1 |
||||
step begin1: BEGIN; |
||||
step lockexcl1: LOCK reind_conc_parent IN ACCESS EXCLUSIVE MODE; |
||||
step reindex2: REINDEX TABLE reind_conc_parent; <waiting ...> |
||||
step drop3: DROP TABLE reind_conc_10_20; <waiting ...> |
||||
step end1: COMMIT; |
||||
step reindex2: <... completed> |
||||
step drop3: <... completed> |
||||
|
||||
starting permutation: begin1 lockexcl1 reindex_conc2 drop3 end1 |
||||
step begin1: BEGIN; |
||||
step lockexcl1: LOCK reind_conc_parent IN ACCESS EXCLUSIVE MODE; |
||||
step reindex_conc2: REINDEX TABLE CONCURRENTLY reind_conc_parent; <waiting ...> |
||||
step drop3: DROP TABLE reind_conc_10_20; <waiting ...> |
||||
step end1: COMMIT; |
||||
step reindex_conc2: <... completed> |
||||
step drop3: <... completed> |
||||
|
||||
starting permutation: begin1 lockshare1 reindex2 drop3 end1 |
||||
step begin1: BEGIN; |
||||
step lockshare1: LOCK reind_conc_parent IN SHARE MODE; |
||||
step reindex2: REINDEX TABLE reind_conc_parent; |
||||
step drop3: DROP TABLE reind_conc_10_20; <waiting ...> |
||||
step end1: COMMIT; |
||||
step drop3: <... completed> |
||||
|
||||
starting permutation: begin1 lockshare1 reindex_conc2 drop3 end1 |
||||
step begin1: BEGIN; |
||||
step lockshare1: LOCK reind_conc_parent IN SHARE MODE; |
||||
step reindex_conc2: REINDEX TABLE CONCURRENTLY reind_conc_parent; <waiting ...> |
||||
step drop3: DROP TABLE reind_conc_10_20; <waiting ...> |
||||
step end1: COMMIT; |
||||
step reindex_conc2: <... completed> |
||||
step drop3: <... completed> |
||||
|
||||
starting permutation: begin1 lockupdate1 reindex2 drop3 end1 |
||||
step begin1: BEGIN; |
||||
step lockupdate1: LOCK reind_conc_parent IN SHARE UPDATE EXCLUSIVE MODE; |
||||
step reindex2: REINDEX TABLE reind_conc_parent; <waiting ...> |
||||
step drop3: DROP TABLE reind_conc_10_20; <waiting ...> |
||||
step end1: COMMIT; |
||||
step reindex2: <... completed> |
||||
step drop3: <... completed> |
||||
|
||||
starting permutation: begin1 lockupdate1 reindex_conc2 drop3 end1 |
||||
step begin1: BEGIN; |
||||
step lockupdate1: LOCK reind_conc_parent IN SHARE UPDATE EXCLUSIVE MODE; |
||||
step reindex_conc2: REINDEX TABLE CONCURRENTLY reind_conc_parent; <waiting ...> |
||||
step drop3: DROP TABLE reind_conc_10_20; <waiting ...> |
||||
step end1: COMMIT; |
||||
step reindex_conc2: <... completed> |
||||
step drop3: <... completed> |
||||
|
||||
starting permutation: begin1 lockpartexcl1 reindex2 drop3 end1 |
||||
step begin1: BEGIN; |
||||
step lockpartexcl1: LOCK reind_conc_10_20 IN ACCESS EXCLUSIVE MODE; |
||||
step reindex2: REINDEX TABLE reind_conc_parent; <waiting ...> |
||||
step drop3: DROP TABLE reind_conc_10_20; <waiting ...> |
||||
step end1: COMMIT; |
||||
step reindex2: <... completed> |
||||
step drop3: <... completed> |
||||
|
||||
starting permutation: begin1 lockpartexcl1 reindex_conc2 drop3 end1 |
||||
step begin1: BEGIN; |
||||
step lockpartexcl1: LOCK reind_conc_10_20 IN ACCESS EXCLUSIVE MODE; |
||||
step reindex_conc2: REINDEX TABLE CONCURRENTLY reind_conc_parent; <waiting ...> |
||||
step drop3: DROP TABLE reind_conc_10_20; <waiting ...> |
||||
step end1: COMMIT; |
||||
step reindex_conc2: <... completed> |
||||
step drop3: <... completed> |
||||
|
||||
starting permutation: begin1 lockpartshare1 reindex2 drop3 end1 |
||||
step begin1: BEGIN; |
||||
step lockpartshare1: LOCK reind_conc_10_20 IN SHARE MODE; |
||||
step reindex2: REINDEX TABLE reind_conc_parent; |
||||
step drop3: DROP TABLE reind_conc_10_20; <waiting ...> |
||||
step end1: COMMIT; |
||||
step drop3: <... completed> |
||||
|
||||
starting permutation: begin1 lockpartshare1 reindex_conc2 drop3 end1 |
||||
step begin1: BEGIN; |
||||
step lockpartshare1: LOCK reind_conc_10_20 IN SHARE MODE; |
||||
step reindex_conc2: REINDEX TABLE CONCURRENTLY reind_conc_parent; <waiting ...> |
||||
step drop3: DROP TABLE reind_conc_10_20; <waiting ...> |
||||
step end1: COMMIT; |
||||
step reindex_conc2: <... completed> |
||||
step drop3: <... completed> |
||||
|
||||
starting permutation: begin1 lockpartupdate1 reindex2 drop3 end1 |
||||
step begin1: BEGIN; |
||||
step lockpartupdate1: LOCK reind_conc_10_20 IN SHARE UPDATE EXCLUSIVE MODE; |
||||
step reindex2: REINDEX TABLE reind_conc_parent; <waiting ...> |
||||
step drop3: DROP TABLE reind_conc_10_20; <waiting ...> |
||||
step end1: COMMIT; |
||||
step reindex2: <... completed> |
||||
step drop3: <... completed> |
||||
|
||||
starting permutation: begin1 lockpartupdate1 reindex_conc2 drop3 end1 |
||||
step begin1: BEGIN; |
||||
step lockpartupdate1: LOCK reind_conc_10_20 IN SHARE UPDATE EXCLUSIVE MODE; |
||||
step reindex_conc2: REINDEX TABLE CONCURRENTLY reind_conc_parent; <waiting ...> |
||||
step drop3: DROP TABLE reind_conc_10_20; <waiting ...> |
||||
step end1: COMMIT; |
||||
step reindex_conc2: <... completed> |
||||
step drop3: <... completed> |
||||
@ -0,0 +1,59 @@ |
||||
# REINDEX with partitioned tables |
||||
# |
||||
# Ensure that concurrent and non-concurrent operations work correctly when |
||||
# a REINDEX is performed on a partitioned table or index. |
||||
|
||||
# In the cases dealt with here, partition leaves are dropped in parallel of |
||||
# a REINDEX. DROP TABLE gets blocked by the first transaction of REINDEX |
||||
# building the list of partitions, so it will finish executing once REINDEX |
||||
# is done. |
||||
|
||||
setup |
||||
{ |
||||
CREATE TABLE reind_conc_parent (id int) PARTITION BY RANGE (id); |
||||
CREATE TABLE reind_conc_0_10 PARTITION OF reind_conc_parent |
||||
FOR VALUES FROM (0) TO (10); |
||||
CREATE TABLE reind_conc_10_20 PARTITION OF reind_conc_parent |
||||
FOR VALUES FROM (10) TO (20); |
||||
INSERT INTO reind_conc_parent VALUES (generate_series(0, 19)); |
||||
} |
||||
|
||||
teardown |
||||
{ |
||||
DROP TABLE reind_conc_parent; |
||||
} |
||||
|
||||
session "s1" |
||||
step "begin1" { BEGIN; } |
||||
step "lockexcl1" { LOCK reind_conc_parent IN ACCESS EXCLUSIVE MODE; } |
||||
step "lockshare1" { LOCK reind_conc_parent IN SHARE MODE; } |
||||
step "lockupdate1" { LOCK reind_conc_parent IN SHARE UPDATE EXCLUSIVE MODE; } |
||||
step "lockpartexcl1" { LOCK reind_conc_10_20 IN ACCESS EXCLUSIVE MODE; } |
||||
step "lockpartshare1" { LOCK reind_conc_10_20 IN SHARE MODE; } |
||||
step "lockpartupdate1" { LOCK reind_conc_10_20 IN SHARE UPDATE EXCLUSIVE MODE; } |
||||
step "end1" { COMMIT; } |
||||
|
||||
session "s2" |
||||
step "reindex2" { REINDEX TABLE reind_conc_parent; } |
||||
step "reindex_conc2" { REINDEX TABLE CONCURRENTLY reind_conc_parent; } |
||||
|
||||
session "s3" |
||||
step "drop3" { DROP TABLE reind_conc_10_20; } |
||||
|
||||
# An existing partition leaf is dropped after reindex is done when the |
||||
# parent is locked. |
||||
permutation "begin1" "lockexcl1" "reindex2" "drop3" "end1" |
||||
permutation "begin1" "lockexcl1" "reindex_conc2" "drop3" "end1" |
||||
permutation "begin1" "lockshare1" "reindex2" "drop3" "end1" |
||||
permutation "begin1" "lockshare1" "reindex_conc2" "drop3" "end1" |
||||
permutation "begin1" "lockupdate1" "reindex2" "drop3" "end1" |
||||
permutation "begin1" "lockupdate1" "reindex_conc2" "drop3" "end1" |
||||
|
||||
# An existing partition leaf is dropped after reindex is done when this |
||||
# leaf is locked. |
||||
permutation "begin1" "lockpartexcl1" "reindex2" "drop3" "end1" |
||||
permutation "begin1" "lockpartexcl1" "reindex_conc2" "drop3" "end1" |
||||
permutation "begin1" "lockpartshare1" "reindex2" "drop3" "end1" |
||||
permutation "begin1" "lockpartshare1" "reindex_conc2" "drop3" "end1" |
||||
permutation "begin1" "lockpartupdate1" "reindex2" "drop3" "end1" |
||||
permutation "begin1" "lockpartupdate1" "reindex_conc2" "drop3" "end1" |
||||
Loading…
Reference in new issue