From aaa80c4f61d7dccf7e550dd47cb1c09e5cc8eb8b Mon Sep 17 00:00:00 2001 From: Andreas Karlsson Date: Mon, 5 May 2025 18:12:46 +0200 Subject: [PATCH] Remove unhelpful hint on key provider not found The hint added nothing and while we could hint about what function they should use to create a key provider this error happens also when alternating or deleting an existing key provider making any hint pretty much useless. --- contrib/pg_tde/expected/key_provider.out | 1 - contrib/pg_tde/src/catalog/tde_keyring.c | 3 +-- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/contrib/pg_tde/expected/key_provider.out b/contrib/pg_tde/expected/key_provider.out index d7c05c8e353..8b8c45c15c0 100644 --- a/contrib/pg_tde/expected/key_provider.out +++ b/contrib/pg_tde/expected/key_provider.out @@ -50,7 +50,6 @@ SELECT pg_tde_verify_key(); SELECT pg_tde_change_database_key_provider_file('not-existent-provider','/tmp/pg_tde_test_keyring.per'); ERROR: key provider "not-existent-provider" does not exists -HINT: Create the key provider SELECT * FROM pg_tde_list_all_database_key_providers(); id | provider_name | provider_type | options ----+----------------+---------------+-------------------------------------------- diff --git a/contrib/pg_tde/src/catalog/tde_keyring.c b/contrib/pg_tde/src/catalog/tde_keyring.c index ac32f9f251d..8be9c7548ad 100644 --- a/contrib/pg_tde/src/catalog/tde_keyring.c +++ b/contrib/pg_tde/src/catalog/tde_keyring.c @@ -1030,8 +1030,7 @@ GetKeyProviderByName(const char *provider_name, Oid dbOid) { ereport(ERROR, errcode(ERRCODE_INVALID_PARAMETER_VALUE), - errmsg("key provider \"%s\" does not exists", provider_name), - errhint("Create the key provider")); + errmsg("key provider \"%s\" does not exists", provider_name)); } return keyring; }