Fix use-after-ReleaseSysCache problem in ATExecAlterColumnType.

Introduced by commit bbe0a81db6. Per buildfarm member prion.
5 years ago · d00fbdc431
parent bbe0a81db6
commit d00fbdc431
1 changed files with 2 additions and 2 deletions
--- a/src/backend/commands/tablecmds.c
+++ b/src/backend/commands/tablecmds.c
@ -11953,8 +11953,6 @@ ATExecAlterColumnType(AlteredTableInfo *tab, Relation rel,
 	attTup->attalign = tform->typalign;
 	attTup->attstorage = tform->typstorage;

-	ReleaseSysCache(typeTuple);
-
 	/* Setup attribute compression */
 	if (rel->rd_rel->relkind == RELKIND_RELATION ||
 		rel->rd_rel->relkind == RELKIND_PARTITIONED_TABLE)
@ -11972,6 +11970,8 @@ ATExecAlterColumnType(AlteredTableInfo *tab, Relation rel,
 	else
 		attTup->attcompression = InvalidCompressionMethod;

+	ReleaseSysCache(typeTuple);
+
 	CatalogTupleUpdate(attrelation, &heapTup->t_self, heapTup);

 	table_close(attrelation, RowExclusiveLock);