Add pg_upgrade C comment about why we check all relkinds for regtypes.

14 years ago · ecf7a2ea38
parent cc53a1e7cc
commit ecf7a2ea38
1 changed files with 5 additions and 0 deletions
--- a/contrib/pg_upgrade/check.c
+++ b/contrib/pg_upgrade/check.c
@ -644,6 +644,11 @@ check_for_reg_data_type_usage(ClusterInfo *cluster)
 		DbInfo	   *active_db = &cluster->dbarr.dbs[dbnum];
 		PGconn	   *conn = connectToServer(cluster, active_db->db_name);

+		/*
+		 *	While several relkinds don't store any data, e.g. views, they
+		 *	can be used to define data types of other columns, so we
+		 *	check all relkinds.
+		 */
 		res = executeQueryOrDie(conn,
 								"SELECT n.nspname, c.relname, a.attname "
 								"FROM	pg_catalog.pg_class c, "