60 Commits (REL9_1_STABLE)

Author	SHA1	Message	Date
Noah Misch	a2385cac13	Obstruct shell, SQL, and conninfo injection via database and role names. ... Due to simplistic quoting and confusion of database names with conninfo strings, roles with the CREATEDB or CREATEROLE option could escalate to superuser privileges when a superuser next ran certain maintenance commands. The new coding rule for PQconnectdbParams() calls, documented at conninfo_array_parse(), is to pass expand_dbname=true and wrap literal database names in a trivial connection string. Escape zero-length values in appendConnStrVal(). Back-patch to 9.1 (all supported versions). Nathan Bossart, Michael Paquier, and Noah Misch. Reviewed by Peter Eisentraut. Reported by Nathan Bossart. Security: CVE-2016-5424	9 years ago
Bruce Momjian	321db71239	pg_upgrade: only allow template0 to be non-connectable ... This patch causes pg_upgrade to error out during its check phase if: (1) template0 is marked connectable or (2) any other database is marked non-connectable This is done because, in the first case, pg_upgrade would fail because the pg_dumpall --globals restore would fail, and in the second case, the database would not be restored, leading to data loss. Report by Matt Landry (1), Stephen Frost (2) Backpatch through 9.0	11 years ago
Bruce Momjian	08aaae40e1	pg_upgrade: quote directory names in delete_old_cluster script ... This allows the delete script to properly function when special characters appear in directory paths, e.g. spaces. Backpatch through 9.0	11 years ago
Heikki Linnakangas	94095e341c	Add missing SYSTEMQUOTEs ... Some popen() calls were missing SYSTEMQUOTEs, which caused initdb and pg_upgrade to fail on Windows, if the installation path contained both spaces and @ signs. Patch by Nikhil Deshpande. Backpatch to all supported versions.	12 years ago
Bruce Momjian	ce4f365188	pg_upgrade: don't copy/link files for invalid indexes ... Now that pg_dump no longer dumps invalid indexes, per commit 683abc73df, have pg_upgrade also skip them. Previously pg_upgrade threw an error if invalid indexes existed. Backpatch to 9.2, 9.1, and 9.0 (where pg_upgrade was added to git)	13 years ago
Bruce Momjian	97a60fa5a0	Fix pg_upgrade for invalid indexes ... All versions of pg_upgrade upgraded invalid indexes caused by CREATE INDEX CONCURRENTLY failures and marked them as valid. The patch adds a check to all pg_upgrade versions and throws an error during upgrade or --check. Backpatch to 9.2, 9.1, 9.0. Patch slightly adjusted.	13 years ago
Andrew Dunstan	a69b7a1c34	Indent fix_path_separator() header properly.	13 years ago
Andrew Dunstan	d10ddf4d51	Use correct path separator for Windows builtin commands. ... pg_upgrade produces a platform-specific script to remove the old directory, but on Windows it has not been making sure that the paths it writes as arguments for rmdir and del use the backslash path separator, which will cause these scripts to fail. The fix is backpatched to Release 9.0.	13 years ago
Bruce Momjian	af97980b9a	In pg_upgrade, verify that the install user has the same oid on both ... clusters, and make sure the new cluster has no additional users. Backpatch to 9.1.	14 years ago
Bruce Momjian	2815574615	In pg_upgrade, remove dependency on pg_config, as that might not be in ... the non-development install. Instead, use the LOAD mechanism to check for the pg_upgrade_support shared object, like we do for other shared object checks. Backpatch to 9.1. Report from Àlvaro	14 years ago
Bruce Momjian	98fbce0931	In pg_upgrade, allow tables using regclass to be upgraded because we ... preserve pg_class oids since PG 9.0.	14 years ago
Bruce Momjian	8cdd62068d	In pg_upgrade, disallow migration of 8.3 clusters using contrib/ltree ... because its internal format was changed in 8.4. Backpatch to 9.0 and 9.1. Report by depesz, diagnosis by Tom.	14 years ago
Tom Lane	333eb32081	Fix not-backwards-compatible pg_upgrade test for prepared transactions. ... There's no reason for this test to use the undocumented pg_prepared_xact() function, when it can use the stable API pg_prepared_xacts instead. Fixes breakage against 8.3, as reported by Justin Arnold.	15 years ago
Bruce Momjian	d9db32401c	In pg_upgrade, check that the binary and data directories are the same ... major version. Backpatch to 9.1. Dan McGee	15 years ago
Bruce Momjian	c6635bd7ba	Adjust pg_upgrade check for pg_upgrade_support to happen after the ... binary directory has been validated. Backpatch to 9.1. Dan McGee	15 years ago
Bruce Momjian	3ccd16c5a9	Fix pg_upgrade status message capitalization mistake. ... Backpatch to 9.1 and 9.0. Dan McGee	15 years ago
Bruce Momjian	5561fe2184	In pg_upgrade, check there are no prepared transactions. ... Backpatch to 9.1.	15 years ago
Bruce Momjian	6560407c7d	Pgindent run before 9.1 beta2.	15 years ago
Bruce Momjian	11c08c3fd7	In pg_upgrade, do case-insensitive checks of locale, encoding, and ctype ... because these are often inconsistently capitalized.	15 years ago
Peter Eisentraut	0ee391b77a	/contrib/foo -> contrib/foo ... Since contrib is a relative directory specification, a leading slash is inappropriate.	15 years ago
Bruce Momjian	78318d63d7	In pg_upgrade, add status message about superuser check.	15 years ago
Bruce Momjian	1609ca5adb	In pg_upgrade, report non-super-user username in error message.	15 years ago
Bruce Momjian	81301b8578	Check that the pg_upgrade user specified is a super-user. ... Also report the error message when the post-pg_ctl connection fails. Per private bug report from EnterpriseDB.	15 years ago
Bruce Momjian	5c5f83507c	Adjust pg_upgrade FATAL error messages to have consistent newlines. ... Also adjust some error message capitalization for consistency.	15 years ago
Bruce Momjian	44091442db	In pg_upgrade, avoid one start/stop of the postmaster; use the -w ... (wait) flag for pg_ctl start/stop; remove the unused "quiet" flag in the functions for starting/stopping the postmaster.	15 years ago
Bruce Momjian	76dd09bbec	Add postmaster/postgres undocumented -b option for binary upgrades. ... This option turns off autovacuum, prevents non-super-user connections, and enables oid setting hooks in the backend. The code continues to use the old autoavacuum disable settings for servers with earlier catalog versions. This includes a catalog version bump to identify servers that support the -b option.	15 years ago
Bruce Momjian	0262251c33	Pg_upgrade C comment addition. ... Document why we do the missing new database check during the check phase.	15 years ago
Bruce Momjian	7228d02989	Throw error for mismatched pg_upgrade clusters ... If someone removes the 'postgres' database from the old cluster and the new cluster has a 'postgres' database, the number of databases will not match. We actually could upgrade such a setup, but it would violate the 1-to-1 mapping of database counts, so we throw an error instead. Previously they got an error during the upgrade, and not at the check stage; PG 9.0.4 does the same.	15 years ago
Bruce Momjian	bf50caf105	pgindent run before PG 9.1 beta 1.	15 years ago
Peter Eisentraut	c75163842c	Replace the confusing exit_nicely() by an atexit/on_exit hook	15 years ago
Bruce Momjian	d367d41d66	Fix file descriptor leaks in pg_upgrade in failure code paths.	15 years ago
Tom Lane	dfe18f18d2	Fix a couple more missing "static" markers.	15 years ago
Bruce Momjian	fe8f15d5d2	Adjust pg_upgrade error message, array freeing, and add error check.	15 years ago
Bruce Momjian	2b6e2dee78	Fix wrong verb in pg_upgrade text message, per Haas.	15 years ago
Bruce Momjian	0a5f119931	A toast relid field are no longer needed in pg_upgrade's rel arrays, so ... remove them. Also other renaming.	15 years ago
Bruce Momjian	5d950e3b0c	Stamp copyrights for year 2011.	15 years ago
Bruce Momjian	67c9e4442f	Furter pg_upgrade optimizations to reduce function call argument count.	15 years ago
Bruce Momjian	6e6bee987f	In pg_upgrade, remove use of whichCluster, and just pass old/new cluster ... pointers, which simplifies the code. This was not possible in 9.0 because everything was in a single nested struct, but is possible now. Per suggestion from Tom.	15 years ago
Bruce Momjian	16b5e08dec	Use "upgrade" in preference over "migrate" in pg_upgrade messages and ... documentation. (Many were left over from the old pg_migrator naming.)	15 years ago
Bruce Momjian	691a67b922	Rename pg_upgrade 'log' to 'log_opts', to avoid platform naming conflict.	15 years ago
Bruce Momjian	07456b45e6	Pgindent run on pg_upgrade source after restructuring.	15 years ago
Bruce Momjian	e13f7e9a71	Restructure the pg_upgrade code to use several global structures rather ... than packing everything into 'ctx' and passing that to every function.	15 years ago
Bruce Momjian	722d5beeb2	In pg_upgrade, rename SHELL_EXT to SCRIPT_EXT, for clarity.	15 years ago
Bruce Momjian	51eeccd6cc	Add removal of PG_VERSION to optional old cluster deletion script. ... Backpatch to 9.0.X.	15 years ago
Bruce Momjian	9df96f9bb1	In pg_upgrade, rename macro EXEC_EXT to SHELL_EXT for clarity. ... Backpatch to 9.0.X.	15 years ago
Magnus Hagander	9f2e211386	Remove cvs keywords from all files.	15 years ago
Bruce Momjian	8af787ea24	Adjust check_for_isn_and_int8_passing_mismatch() so it is called for all ... migrations. Backpatch to 9.0.	16 years ago
Bruce Momjian	f31b1fd7c1	Prevent pg_upgrade from migrating databases that use reg* data types ... where the oid is not preserved by pg_upgrade (everything but pg_type). Update documentation. Per bug report from depstein@alliedtesting.com.	16 years ago
Bruce Momjian	804f96accb	In pg_upgrade, prevent psql AUTOCOMMIT=off by not loading .psqlrc.	16 years ago
Bruce Momjian	239d769e7e	pgindent run for 9.0, second run	16 years ago