4 Commits (master)

Author	SHA1	Message	Date
Álvaro Herrera	cd7b204b2d	Disallow direct use of the pgrepack logical decoding plugin ... Nothing is to be gained from using pgrepack outside of REPACK (CONCURRENTLY), and it leads to assertion failures in assertion-enabled builds, and to crashes due to bogus memory lifetime in production builds. Reject attempts to do that with a clean error report. Clean up the nearby code a tad while at it. The only functional changes in that are that the output_writer_private context is allocated and partially filled by the pgrepack output plugin; and that ->relid therein is now always present (rather than only in assertion-enabled builds). Other than that it's just minor code rearrangement and added comments. Author: Álvaro Herrera <alvherre@kurilemu.de> Reported-by: Nikita Kalinin <n.kalinin@postgrespro.ru> Suggested-by: Zhijie Hou <houzj.fnst@fujitsu.com> Reviewed-by: Antonin Houska <ah@cybertec.at> (older version) Reviewed-by: Srinath Reddy Sadipiralla <srinath2133@gmail.com> (older version) Discussion: https://postgr.es/m/19500-38a02529a69353a5@postgresql.org	2 days ago
Álvaro Herrera	2670cc298f	Cover additional errors and corner conditions in repack.c ... The coverage report shows that some error cases were not being tested; add test cases for them. While at it, move some recently added ones to the test_decoding suite: the preventative check added in 43649b6a53 now causes servers with wal_level=minimal to error out earlier than before. Author: Álvaro Herrera <alvherre@kurilemu.de> Reviewed-by: Baji Shaik <baji.pgdev@gmail.com> Discussion: https://postgr.es/m/ahiwD29RNfVT4tjQ@alvherre.pgsql	2 weeks ago
Álvaro Herrera	eb2e2eb4d4	Don't lose column values on REPACK ... Commit 28d534e2ae introduced reform_tuple() with a fast path that returns the source tuple verbatim when no dropped columns require fixing up. I (Álvaro) failed to realize that this broke handling of columns with a 'missingval' defined: after a VACUUM FULL, CLUSTER, or REPACK operation, the catalogued missingval is thrown away, so the tuples are no longer correct. Fix by forcing the rewrite when the tuple is shorter than the tuple descriptor. Author: Satya Narlapuram <satyanarlapuram@gmail.com> Discussion: https://postgr.es/m/CAHg+QDeoccU5CudrJpmSKZfKZ1gRMNY=5BxSC=JpHgkonzgcOw@mail.gmail.com	1 month ago
Álvaro Herrera	4b2aa4b39c	Move REPACK (CONCURRENTLY) test out of stock regression tests ... These tests sometimes run with wal_level=minimal, which does not allow to run REPACK (CONCURRENTLY). Move them to test_decoding, which is ensured to run with high enough wal_level. Discussion: https://postgr.es/m/260901.1776696126@sss.pgh.pa.us	2 months ago