postgres

Commit Graph

Author	SHA1	Message	Date
Andres Freund	a91242b1bc	Deal with paths containing \ and spaces in basebackup_to_shell tests As $gzip is embedded in postgresql.conf \ needs to be escaped, otherwise guc.c will take it as a string escape. Similarly, if "$gzip" contains spaces, the prior incantation will fail. Both of these are common on windows. Reviewed-by: Peter Eisentraut <peter.eisentraut@enterprisedb.com> Discussion: https://postgr.es/m/ce1b6eb3-5736-6f38-9775-b7020128b8d8@enterprisedb.com Backpatch: 15-, where the test was added in `027fa0fd72`	4 years ago
Andres Freund	fd4bad1655	Remove now superfluous declarations of dlsym()ed symbols. The prior commit declared them centrally. Author: Andres Freund <andres@anarazel.de> Reviewed-By: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/20211101020311.av6hphdl6xbjbuif@alap3.anarazel.de	4 years ago
Tom Lane	23e7b38bfe	Pre-beta mechanical code beautification. Run pgindent, pgperltidy, and reformat-dat-files. I manually fixed a couple of comments that pgindent uglified.	4 years ago
Andres Freund	b5f44225b8	Mark a few 'bbsink' related functions / variables static. Discussion: https://postgr.es/m/20220506234924.6mxxotl3xl63db3l@alap3.anarazel.de	4 years ago
Michael Paquier	7307988abd	basebackup_to_shell: Add missing MarkGUCPrefixReserved() Oversight in `c6306db24`, as per a requirement from `88103567`. All the other modules in the tree, be they in contrib/ or src/test/modules/, already do that. Author: Bharath Rupireddy Discussion: https://postgr.es/m/CALj2ACUy7q_KwSMda+2SHPSWep32tNUM8cXGRS3=-Vfodo9OUg@mail.gmail.com	4 years ago
Joe Conway	9752436f04	Use has_privs_for_roles for predefined role checks: round 2 Similar to commit `6198420ad`, replace is_member_of_role with has_privs_for_role for predefined role access checks in recently committed basebackup code. In passing fix a double-word error in a nearby comment. Discussion: https://postgr.es/m/flat/CAGB+Vh4Zv_TvKt2tv3QNS6tUM_F_9icmuj0zjywwcgVi4PAhFA@mail.gmail.com	4 years ago
Robert Haas	fea1cc49e4	In basebackup_to_shell tests, properly set up pg_hba.conf. Discussion: http://postgr.es/m/485495.1648692468@sss.pgh.pa.us	4 years ago
Tom Lane	f8e0d900af	Add .gitignore for basebackup_to_shell. Nathan Bossart Discussion: https://postgr.es/m/20220330223531.GA134543@nathanxps13	4 years ago
Robert Haas	027fa0fd72	basebackup_to_shell: Add TAP test. Per gripe from Andres Freund. Thanks to Andres Freund, Thomas Munro, and Andrew Dunstan for advice on how to make this test work even on Windows. Discussion: https://postgr.es/m/CA+Tgmoat+zbzzZQJ7poXyUwiqxQxTaUid=auB4FejZ15VvDh4Q@mail.gmail.com	4 years ago
Robert Haas	c6306db24b	Add 'basebackup_to_shell' contrib module. As a demonstration of the sort of thing that can be done by adding a custom backup target, this defines a 'shell' target which executes a command defined by the system administrator. The command is executed once for each tar archive generate by the backup and once for the backup manifest, if any. Each time the command is executed, it receives the contents of th file for which it is executed via standard input. The configured command can use %f to refer to the name of the archive (e.g. base.tar, $TABLESPACE_OID.tar, backup_manifest) and %d to refer to the target detail (pg_basebackup --target shell:DETAIL). A target detail is required if %d appears in the configured command and forbidden if it does not. Patch by me, reviewed by Abhijit Menon-Sen. Discussion: http://postgr.es/m/CA+TgmoaqvdT-u3nt+_kkZ7bgDAyqDB0i-+XOMmr5JN2Rd37hxw@mail.gmail.com	4 years ago

10 Commits (0778eb79b1e2957743bbd577fc3d862a3dc007cf)