9 Commits (0778eb79b1e2957743bbd577fc3d862a3dc007cf)

Author	SHA1	Message	Date
Andrew Dunstan	c835dcdab6	Fix pgperlsyncheck following SSL TAP test refactoring ... Commit 4a7e964fc6 made pgperlsyncheck fail, but apparently nobody noticed, although the buildfarm module that does more or less the same thing was modified. So fix the in-core test. I will look at unifying the two sets of tests so we avoid a future mismatch.	4 years ago
Daniel Gustafsson	bb466c6b09	Prohibit map and grep in void context ... map and grep are not intended to be used as mutators, iterating with side-effects should be done with for or foreach loops. This fixes the one occurrence of the pattern, and bumps the perlcritic policy to severity 5 for the map and grep policies. Author: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org> Reviewed-by: Michael Paquier <michael@paquier.xyz> Reviewed-by: Andrew Dunstan <andrew@dunslane.net> Reviewed-by: Julien Rouhaud <rjuju123@gmail.com> Discussion: https://postgr.es/m/87fsvzhhc4.fsf@wibble.ilmari.org	4 years ago
Andrew Dunstan	0516f94d18	Stop requiring an explicit return from perl subroutines ... The consensus of the project appears to be that this provides little benefit and is simply an annoyance. Discussion: https://postgr.es/m/27481.1586618092@sss.pgh.pa.us	6 years ago
Andrew Dunstan	7be5d8df1f	Use perl warnings pragma consistently ... We've had a mixture of the warnings pragma, the -w switch on the shebang line, and no warnings at all. This patch removes the -w swicth and add the warnings pragma to all perl sources missing it. It raises the severity of the TestingAndDebugging::RequireUseWarnings perlcritic policy to level 5, so that we catch any future violations. Discussion: https://postgr.es/m/20200412074245.GB623763@rfd.leadboat.com	6 years ago
Andrew Dunstan	8930e43ecd	Print policy name in perlcritic messages ... This makes it easier to do a web search for details of the policy that's been violated, as well as displaying the name that might be needed for a policy override. Various perlcritic settings changes are being discussed, but this one should be uncontroversial.	6 years ago
Peter Eisentraut	0fcf5e0e6e	Fix whitespace	8 years ago
Andrew Dunstan	e3eb8be77e	Exclude files in .git from list of perl files ... The .git directory might contain perl files, as hooks, for example. Since we have no control over these they should be excluded from things like our perlcritic checks. Per offline report from Mike Blackwell.	8 years ago
Andrew Dunstan	85dd744a70	Move perlcritic files to new perlcheck directory	8 years ago
Andrew Dunstan	af616ce483	Add a script to detect perl compile time errors and warnings ... Also add a function that centralizes the logic for locating all our perl files and use it in pgperlcritic and pgperltidy as well as the new pgperlcheck.	8 years ago